[Xfce4-commits] [xfce/xfdesktop] 03/04: fix coverity cid 1432966 Logically dead code

noreply at xfce.org noreply at xfce.org
Thu May 4 14:16:25 CEST 2017


This is an automated email from the git hooks/post-receive script.

eric pushed a commit to branch master
in repository xfce/xfdesktop.

commit 8701fdf2c1964df7f55c0d60883eb593adb629f7
Author: Eric Koegel <eric.koegel at gmail.com>
Date:   Thu May 4 15:13:25 2017 +0300

    fix coverity cid 1432966 Logically dead code
---
 src/xfce-backdrop.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/xfce-backdrop.c b/src/xfce-backdrop.c
index 23bfa5c..36b5881 100644
--- a/src/xfce-backdrop.c
+++ b/src/xfce-backdrop.c
@@ -221,12 +221,8 @@ create_gradient(GdkRGBA *color1, GdkRGBA *color2, gint width, gint height,
 
     if(style == XFCE_BACKDROP_COLOR_VERT_GRADIENT) {
         pat = cairo_pattern_create_linear (0.0, 0.0,  0.0, height);
-    } else if(style == XFCE_BACKDROP_COLOR_HORIZ_GRADIENT) {
-        pat = cairo_pattern_create_linear (0.0, 0.0,  width, 0.0);
     } else {
-        cairo_destroy(cr);
-        cairo_surface_destroy(surface);
-        return NULL;
+        pat = cairo_pattern_create_linear (0.0, 0.0,  width, 0.0);
     }
 
     cairo_pattern_add_color_stop_rgba (pat, 1, color2->red, color2->green, color2->blue, color2->alpha);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Xfce4-commits mailing list