[Xfce4-commits] [xfce/xfdesktop] 01/04: fix coverity cid 1432968 Dereference before null check

noreply at xfce.org noreply at xfce.org
Thu May 4 14:16:23 CEST 2017


This is an automated email from the git hooks/post-receive script.

eric pushed a commit to branch master
in repository xfce/xfdesktop.

commit 387f16ad64f9820cc5a68875fbd13b0700fa9344
Author: Eric Koegel <eric.koegel at gmail.com>
Date:   Thu May 4 15:11:04 2017 +0300

    fix coverity cid 1432968 Dereference before null check
---
 src/xfce-backdrop.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/xfce-backdrop.c b/src/xfce-backdrop.c
index 956994f..23bfa5c 100644
--- a/src/xfce-backdrop.c
+++ b/src/xfce-backdrop.c
@@ -1797,7 +1797,7 @@ xfce_backdrop_loader_size_prepared_cb(GdkPixbufLoader *loader,
                                       gpointer user_data)
 {
     XfceBackdropImageData *image_data = user_data;
-    XfceBackdrop *backdrop = image_data->backdrop;
+    XfceBackdrop *backdrop;
     gdouble xscale, yscale;
 
     TRACE("entering");
@@ -1805,6 +1805,8 @@ xfce_backdrop_loader_size_prepared_cb(GdkPixbufLoader *loader,
     if(image_data == NULL)
         return;
 
+    backdrop = image_data->backdrop;
+
     /* canceled? quit now */
     if(g_cancellable_is_cancelled(image_data->cancellable)) {
         xfce_backdrop_image_data_release(image_data);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Xfce4-commits mailing list