[Xfce4-commits] [apps/ristretto] 01/01: Fix possible NULL pointer dereference; found by Coverity

noreply at xfce.org noreply at xfce.org
Thu Sep 22 10:06:14 CEST 2016


This is an automated email from the git hooks/post-receive script.

f2404 pushed a commit to branch master
in repository apps/ristretto.

commit e3c45e0aaf7d1486deb8aa7178ce420deff4e562
Author: Igor <f2404 at yandex.ru>
Date:   Thu Sep 22 11:06:09 2016 +0300

    Fix possible NULL pointer dereference; found by Coverity
---
 src/xfce_wallpaper_manager.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/xfce_wallpaper_manager.c b/src/xfce_wallpaper_manager.c
index 2c4826c..c396377 100644
--- a/src/xfce_wallpaper_manager.c
+++ b/src/xfce_wallpaper_manager.c
@@ -635,13 +635,13 @@ rstto_xfce_wallpaper_manager_dispose (GObject *object)
 {
     RsttoXfceWallpaperManager *xfce_wallpaper_manager = RSTTO_XFCE_WALLPAPER_MANAGER (object);
 
-    if (xfce_wallpaper_manager->priv->channel)
-    {
-        g_object_unref (xfce_wallpaper_manager->priv->channel);
-        xfce_wallpaper_manager->priv->channel = NULL;
-    }
     if (xfce_wallpaper_manager->priv)
     {
+        if (xfce_wallpaper_manager->priv->channel)
+        {
+            g_object_unref (xfce_wallpaper_manager->priv->channel);
+            xfce_wallpaper_manager->priv->channel = NULL;
+        }
         g_free (xfce_wallpaper_manager->priv);
         xfce_wallpaper_manager->priv = NULL;
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Xfce4-commits mailing list