[Xfce4-commits] [apps/xfce4-terminal] 01/01: Fix focus-in and key-release events handler to propagate the event further

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

f2404 pushed a commit to branch master
in repository apps/xfce4-terminal.

commit 7e657dcf660b1b6ea2fc94cffb1f08f4d01063b5
Author: Igor <f2404 at yandex.ru>
Date:   Wed Sep 7 18:52:27 2016 +0300

    Fix focus-in and key-release events handler to propagate the event further
    
    This resolves the focus issue with hollow cursor:
    https://bugzilla.xfce.org/show_bug.cgi?id=12807
---
 terminal/terminal-app.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/terminal/terminal-app.c b/terminal/terminal-app.c
index 233fc3c..9c77ab3 100644
--- a/terminal/terminal-app.c
+++ b/terminal/terminal-app.c
@@ -58,7 +58,7 @@ static void     terminal_app_update_accels            (TerminalApp        *app);
 static void     terminal_app_update_mnemonics         (TerminalApp        *app);
 static gboolean terminal_app_accel_map_load           (gpointer            user_data);
 static gboolean terminal_app_accel_map_save           (gpointer            user_data);
-static void     terminal_app_unset_urgent_bell        (TerminalWindow     *window,
+static gboolean terminal_app_unset_urgent_bell        (TerminalWindow     *window,
                                                        GdkEvent           *event,
                                                        TerminalApp        *app);
 static void     terminal_app_new_window               (TerminalWindow     *window,
@@ -303,7 +303,7 @@ terminal_app_accel_map_load (gpointer user_data)
 
 
 
-static void
+static gboolean
 terminal_app_unset_urgent_bell (TerminalWindow *window,
                                 GdkEvent       *event,
                                 TerminalApp    *app)
@@ -315,11 +315,13 @@ terminal_app_unset_urgent_bell (TerminalWindow *window,
                 "misc-bell-urgent", &enabled,
                 NULL);
 
-  if (!enabled)
-    return;
+  if (enabled)
+    {
+      toplevel = gtk_widget_get_toplevel (GTK_WIDGET (window));
+      gtk_window_set_urgency_hint (GTK_WINDOW (toplevel), FALSE);
+    }
 
-  toplevel = gtk_widget_get_toplevel (GTK_WIDGET (window));
-  gtk_window_set_urgency_hint (GTK_WINDOW (toplevel), FALSE);
+  return FALSE;
 }
 
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.