[Xfce4-commits] [apps/xfce4-terminal] 01/01: Set preferences dialog type hint to make it show on top

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

f2404 pushed a commit to branch master
in repository apps/xfce4-terminal.

commit efea6c3af2eb5e9300517c83dcd866bfc4039c0c
Author: Igor <f2404 at yandex.ru>
Date:   Thu Oct 27 16:25:49 2016 +0300

    Set preferences dialog type hint to make it show on top
---
 terminal/terminal-preferences-dialog.c | 1 +
 terminal/terminal-window.c             | 9 +--------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/terminal/terminal-preferences-dialog.c b/terminal/terminal-preferences-dialog.c
index 07b5fe1..077467c 100644
--- a/terminal/terminal-preferences-dialog.c
+++ b/terminal/terminal-preferences-dialog.c
@@ -998,5 +998,6 @@ terminal_preferences_dialog_new (gboolean show_drop_down)
 
   dialog = gtk_builder_get_object (builder, "dialog");
   terminal_return_val_if_fail (XFCE_IS_TITLED_DIALOG (dialog), NULL);
+  gtk_window_set_type_hint (GTK_WINDOW (dialog), GDK_WINDOW_TYPE_HINT_DIALOG);
   return GTK_WIDGET (dialog);
 }
diff --git a/terminal/terminal-window.c b/terminal/terminal-window.c
index 0fdabdc..063ef76 100644
--- a/terminal/terminal-window.c
+++ b/terminal/terminal-window.c
@@ -1604,14 +1604,7 @@ terminal_window_action_prefs (GtkAction      *action,
 
   if (window->preferences_dialog != NULL)
     {
-      /* do not set this in fullscreen mode as preferences would be hidden behind the terminal window */
-      if (!gtk_toggle_action_get_active (GTK_TOGGLE_ACTION (window->action_fullscreen)))
-        gtk_window_set_transient_for (GTK_WINDOW (window->preferences_dialog), GTK_WINDOW (window));
-
-      /* move preferences on top in dropdown mode */
-      if (window->drop_down)
-        gtk_window_set_keep_above (GTK_WINDOW (window->preferences_dialog), TRUE);
-
+      gtk_window_set_transient_for (GTK_WINDOW (window->preferences_dialog), GTK_WINDOW (window));
       gtk_window_present (GTK_WINDOW (window->preferences_dialog));
     }
 }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.