[Xfce4-commits] [apps/ristretto] 01/02: Fix memory leaks in Preferences and Privacy dialogs

noreply at xfce.org noreply at xfce.org
Sat Oct 15 14:46:59 CEST 2016


This is an automated email from the git hooks/post-receive script.

f2404 pushed a commit to branch master
in repository apps/ristretto.

commit 96c0eff37038c893a6c407e83e3348f6cbbc5067
Author: Igor <f2404 at yandex.ru>
Date:   Sat Oct 15 15:46:30 2016 +0300

    Fix memory leaks in Preferences and Privacy dialogs
---
 src/preferences_dialog.c | 14 ++++++++++----
 src/privacy_dialog.c     | 15 ++++++++++-----
 2 files changed, 20 insertions(+), 9 deletions(-)

diff --git a/src/preferences_dialog.c b/src/preferences_dialog.c
index 6faebba..0b21f71 100644
--- a/src/preferences_dialog.c
+++ b/src/preferences_dialog.c
@@ -554,12 +554,18 @@ static void
 rstto_preferences_dialog_dispose (GObject *object)
 {
     RsttoPreferencesDialog *dialog = RSTTO_PREFERENCES_DIALOG (object);
-    if (dialog->priv->settings)
+    if (dialog->priv)
     {
-        g_object_unref (dialog->priv->settings);
-        dialog->priv->settings = NULL;
+        if (dialog->priv->settings)
+        {
+            g_object_unref (dialog->priv->settings);
+            dialog->priv->settings = NULL;
+        }
+
+        g_free (dialog->priv);
+        dialog->priv = NULL;
     }
-    
+
     G_OBJECT_CLASS(parent_class)->dispose(object);
 }
 
diff --git a/src/privacy_dialog.c b/src/privacy_dialog.c
index 0be7f7b..63cd250 100644
--- a/src/privacy_dialog.c
+++ b/src/privacy_dialog.c
@@ -289,13 +289,18 @@ rstto_recent_chooser_init (GtkRecentChooserIface *iface)
 static void
 rstto_privacy_dialog_dispose (GObject *object)
 {
-    RsttoPrivacyDialog *dialog = RSTTO_PRIVACY_DIALOG (object);
-    if (dialog->priv->settings)
+    if (dialog->priv)
     {
-        g_object_unref (dialog->priv->settings);
-        dialog->priv->settings = NULL;
+        if (dialog->priv->settings)
+        {
+            g_object_unref (dialog->priv->settings);
+            dialog->priv->settings = NULL;
+        }
+
+        g_free (dialog->priv);
+        dialog->priv = NULL;
     }
-    
+
     G_OBJECT_CLASS(parent_class)->dispose(object);
 }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Xfce4-commits mailing list