[Xfce4-commits] [apps/xfdashboard] 01/01: Let plugin decide which widget should be visible and do not enfore all widgets to be visible in settings application. Doing so could make widgets visible which shouldn't ... at least not unconditionally.

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

nomad pushed a commit to branch master
in repository apps/xfdashboard.

commit fc14c1e161fb4d5bb225c505dbfb049264a177bb
Author: Stephan Haller <nomad at froevel.de>
Date:   Sat Feb 27 14:22:03 2016 +0100

    Let plugin decide which widget should be visible and do not enfore all widgets to be visible in settings application. Doing so could make widgets visible which shouldn't ... at least not unconditionally.
---
 plugins/clock-view/plugin.c | 3 +++
 plugins/hot-corner/plugin.c | 3 +++
 settings/plugins.c          | 1 -
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/plugins/clock-view/plugin.c b/plugins/clock-view/plugin.c
index dda579b..bc0763c 100644
--- a/plugins/clock-view/plugin.c
+++ b/plugins/clock-view/plugin.c
@@ -267,6 +267,9 @@ static GObject* plugin_configure(XfdashboardPlugin *self, gpointer inUserData)
 	/* Release allocated resources */
 	if(settings) g_object_unref(settings);
 
+	/* Make all widgets visible */
+	gtk_widget_show_all(layout);
+
 	/* Return layout widget containing all other widgets */
 	return(G_OBJECT(layout));
 }
diff --git a/plugins/hot-corner/plugin.c b/plugins/hot-corner/plugin.c
index 0a96cb4..e7399e0 100644
--- a/plugins/hot-corner/plugin.c
+++ b/plugins/hot-corner/plugin.c
@@ -379,6 +379,9 @@ static GObject* plugin_configure(XfdashboardPlugin *self, gpointer inUserData)
 	/* Release allocated resources */
 	if(settings) g_object_unref(settings);
 
+	/* Make all widgets visible */
+	gtk_widget_show_all(layout);
+
 	/* Return layout widget containing all other widgets */
 	return(G_OBJECT(layout));
 }
diff --git a/settings/plugins.c b/settings/plugins.c
index 08e1806..52e90d1 100644
--- a/settings/plugins.c
+++ b/settings/plugins.c
@@ -213,7 +213,6 @@ static gboolean _xfdashboard_settings_plugins_call_preferences(XfdashboardSettin
 		gint								response;
 
 		/* Add returned widget from plugin to dialog */
-		gtk_widget_show_all(pluginPreferencesWidget);
 		gtk_container_add(GTK_CONTAINER(priv->widgetPluginPreferencesWidgetBox), pluginPreferencesWidget);
 
 		/* Show dialog in modal mode but do not care about dialog's response code

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.