[Xfce4-commits] [apps/parole] 01/01: Workaround for bug 12169

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

bluesabre pushed a commit to branch master
in repository apps/parole.

commit a6ad963080605596f8cda165b60d913d96193f59
Author: Sean Davis <smd.seandavis at gmail.com>
Date:   Mon Sep 7 08:19:48 2015 -0400

    Workaround for bug 12169
---
 src/gst/parole-gst.c |   18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/src/gst/parole-gst.c b/src/gst/parole-gst.c
index a0f31af..05ccdb0 100644
--- a/src/gst/parole-gst.c
+++ b/src/gst/parole-gst.c
@@ -2623,11 +2623,19 @@ void parole_gst_terminate (ParoleGst *gst)
 
 void parole_gst_shutdown (ParoleGst *gst)
 {
-    if ( g_signal_handler_is_connected (gst->priv->playbin, gst->priv->sig1) )
-        g_signal_handler_disconnect (gst->priv->playbin, gst->priv->sig1);
-
-    if ( g_signal_handler_is_connected (gst->priv->playbin, gst->priv->sig2) )
-        g_signal_handler_disconnect (gst->priv->playbin, gst->priv->sig2);
+    /**
+     * FIXME: See https://bugzilla.xfce.org/show_bug.cgi?id=12169
+     * Seems to be some last-second threading issues. When parole is closed,
+     * these signals are disconnected before the process ends. With recent
+     * library versions, parole crashes at this point. Since the signals will
+     * be disconnected when everything stops, should not be necessary to
+     * disconnect these signals manually.
+        if ( g_signal_handler_is_connected (gst->priv->playbin, gst->priv->sig1) )
+            g_signal_handler_disconnect (gst->priv->playbin, gst->priv->sig1);
+
+        if ( g_signal_handler_is_connected (gst->priv->playbin, gst->priv->sig2) )
+            g_signal_handler_disconnect (gst->priv->playbin, gst->priv->sig2);
+    */
 
     if ( gst->priv->bus )
         g_object_unref (gst->priv->bus);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.