[Xfce4-commits] [xfce/xfdesktop] 18/35: coverity cid 1292725 Dereference before null check

noreply at xfce.org noreply at xfce.org
Sun May 17 11:38:06 CEST 2015


This is an automated email from the git hooks/post-receive script.

eric pushed a commit to branch xfce-4.12
in repository xfce/xfdesktop.

commit 964471f19338ed0d362124bd78f04f06d3d2814d
Author: Eric Koegel <eric.koegel at gmail.com>
Date:   Wed Apr 1 19:53:21 2015 +0300

    coverity cid 1292725 Dereference before null check
---
 src/xfdesktop-file-icon-manager.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/xfdesktop-file-icon-manager.c b/src/xfdesktop-file-icon-manager.c
index 0f74aba..fff8049 100644
--- a/src/xfdesktop-file-icon-manager.c
+++ b/src/xfdesktop-file-icon-manager.c
@@ -1000,6 +1000,9 @@ xfdesktop_file_icon_menu_paste_into_folder(GtkWidget *widget,
     GFile *file;
     GList *selected;
 
+    if (!fmanager || !XFDESKTOP_IS_FILE_ICON_MANAGER(fmanager))
+        return;
+
     selected = xfdesktop_icon_view_get_selected_items(fmanager->priv->icon_view);
     g_return_if_fail(g_list_length(selected) == 1);
     icon = XFDESKTOP_FILE_ICON(selected->data);
@@ -1012,7 +1015,7 @@ xfdesktop_file_icon_menu_paste_into_folder(GtkWidget *widget,
 
     file = xfdesktop_file_icon_peek_file(icon);
 
-    if(widget && fmanager)
+    if(widget)
         xfdesktop_clipboard_manager_paste_files(clipboard_manager, file, widget, NULL);
 }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Xfce4-commits mailing list