[Xfce4-commits] [apps/orage] 01/01: 4.11.2.16 Coverity fix 41265 null check too late

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

juha pushed a commit to branch master
in repository apps/orage.

commit f8218b1aa78c1e031e22a4b3f5d4344db24f61e5
Author: Juha Kautto <juha at xfce.org>
Date:   Wed Mar 11 12:46:25 2015 +0200

    4.11.2.16 Coverity fix 41265 null check too late
    
    Added null check earlier before using the variable
---
 configure.in.in  |    2 +-
 src/event-list.c |    7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/configure.in.in b/configure.in.in
index df0c4eb..b2ec0fc 100644
--- a/configure.in.in
+++ b/configure.in.in
@@ -9,7 +9,7 @@ dnl Written for Xfce by Juha Kautto <juha at xfce.org>
 dnl
 
 dnl Version information
-m4_define([orage_version], [4.11.2.15-git])
+m4_define([orage_version], [4.11.2.16-git])
 
 m4_define([gtk_minimum_version], [2.14.0])
 m4_define([xfce_minimum_version], [4.8.0])
diff --git a/src/event-list.c b/src/event-list.c
index 6fc3ec0..3a6c2bb 100644
--- a/src/event-list.c
+++ b/src/event-list.c
@@ -1066,12 +1066,13 @@ static void drag_data_get(GtkWidget *widget, GdkDragContext *context
             g_free(uid);
         }
     }
-    if (!gtk_selection_data_set_text(selection_data, result->str, -1))
-        g_warning("drag_data_get failed\n");
     g_list_foreach(list, (GFunc)gtk_tree_path_free, NULL);
     g_list_free(list);
-    if (result)
+    if (result) {
+        if (!gtk_selection_data_set_text(selection_data, result->str, -1))
+            g_warning("drag_data_get failed\n");
         g_string_free(result, TRUE);
+    }
 }
 
 static void build_menu(el_win *el)

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.