[Xfce4-commits] [apps/orage] 01/01: 4.11.2.r64 Coverity fix 31720 strcpy without length check

noreply at xfce.org noreply at xfce.org
Thu Mar 5 10:08:21 CET 2015


This is an automated email from the git hooks/post-receive script.

juha pushed a commit to branch master
in repository apps/orage.

commit 14f80d55f73ba61cc5319632939464e9f67584b8
Author: Juha Kautto <juha at xfce.org>
Date:   Thu Mar 5 11:07:33 2015 +0200

    4.11.2.r64 Coverity fix 31720 strcpy without length check
    
    Added check for length to prevent overrun
---
 configure.in.in  |    2 +-
 src/event-list.c |    5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/configure.in.in b/configure.in.in
index f096a75..2e8bff7 100644
--- a/configure.in.in
+++ b/configure.in.in
@@ -9,7 +9,7 @@ dnl Written for Xfce by Juha Kautto <juha at xfce.org>
 dnl
 
 dnl Version information
-m4_define([orage_version], [4.11.2.5-git])
+m4_define([orage_version], [4.11.2.6-git])
 
 m4_define([gtk_minimum_version], [2.14.0])
 m4_define([xfce_minimum_version], [4.8.0])
diff --git a/src/event-list.c b/src/event-list.c
index 09c40fc..8cb551f 100644
--- a/src/event-list.c
+++ b/src/event-list.c
@@ -667,8 +667,9 @@ static void journal_data(el_win *el)
     char     a_day[9];  /* yyyymmdd */
 
     el->days = 10*365; /* long enough time to get everything from future */
-    strcpy(a_day, orage_i18_date_to_icaldate(gtk_button_get_label(
-            GTK_BUTTON(el->journal_start_button))));
+    strncpy(a_day, orage_i18_date_to_icaldate(gtk_button_get_label(
+            GTK_BUTTON(el->journal_start_button))), 8);
+    a_day[8] = '\0';
 
     app_data(el, a_day, NULL);
 }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Xfce4-commits mailing list