[Xfce4-commits] [xfce/xfwm4] 01/04: Add a note about XDamageDestroy() causing XErrors

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

olivier pushed a commit to branch master
in repository xfce/xfwm4.

commit a45721e6d6cb0423968eb11a4f894fbf605ec683
Author: Olivier Fourdan <fourdan at xfce.org>
Date:   Fri Jan 30 21:53:04 2015 +0100

    Add a note about XDamageDestroy() causing XErrors
    
    Signed-off-by: Olivier Fourdan <fourdan at xfce.org>
---
 src/compositor.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/compositor.c b/src/compositor.c
index fcd3fe3..5af29ce 100644
--- a/src/compositor.c
+++ b/src/compositor.c
@@ -817,6 +817,12 @@ free_win_data (CWindow *cw, gboolean delete)
     {
         if (cw->damage)
         {
+            /* The damage may be already destroyed along with the attached resource,
+             * (see http://lists.x.org/archives/xorg-devel/2011-March/020831.html)
+             * so there is a high probability that the following will generate an
+             * X error eventually, but there's no way to be sure so just destroy
+             * the damage and ignore the error.
+             */
             XDamageDestroy (display_info->dpy, cw->damage);
             cw->damage = None;
         }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.