[Xfce4-commits] [xfce/thunar] 01/01: Fix cppcheck possible errors/warnings

noreply at xfce.org noreply at xfce.org
Sat Feb 21 23:07:47 CET 2015


This is an automated email from the git hooks/post-receive script.

hjudt pushed a commit to branch master
in repository xfce/thunar.

commit bdb3aecd33c4e42552848925de8138baed9d64c7
Author: Harald Judt <h.judt at gmx.at>
Date:   Sat Feb 21 23:05:44 2015 +0100

    Fix cppcheck possible errors/warnings
---
 thunar/thunar-chooser-dialog.c   |    2 +-
 thunar/thunar-location-buttons.c |    3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/thunar/thunar-chooser-dialog.c b/thunar/thunar-chooser-dialog.c
index 9c16dd3..dd9914d 100644
--- a/thunar/thunar-chooser-dialog.c
+++ b/thunar/thunar-chooser-dialog.c
@@ -392,7 +392,7 @@ thunar_chooser_dialog_response (GtkDialog *widget,
   GtkTreeIter          iter;
   const gchar         *content_type;
   const gchar         *exec;
-  GAppInfo            *app_info;
+  GAppInfo            *app_info = NULL;
   gboolean             succeed = TRUE;
   GError              *error = NULL;
   gchar               *path;
diff --git a/thunar/thunar-location-buttons.c b/thunar/thunar-location-buttons.c
index a6e06f4..6979ec6 100644
--- a/thunar/thunar-location-buttons.c
+++ b/thunar/thunar-location-buttons.c
@@ -1079,6 +1079,9 @@ thunar_location_buttons_scroll_right (GtkWidget             *button,
         break;
       }
 
+  if (G_UNLIKELY (right_button == NULL))
+      return;
+
   /* find the last visible button on the 'left' end */
   for (lp = g_list_last (buttons->list); lp != NULL; lp = lp->prev)
     if (gtk_widget_get_child_visible (GTK_WIDGET (lp->data)))

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Xfce4-commits mailing list