[Xfce4-commits] [panel-plugins/xfce4-whiskermenu-plugin] 345/473: Fixed crash when accessing null launcher in assert.

noreply at xfce.org noreply at xfce.org
Mon Feb 16 23:58:35 CET 2015


This is an automated email from the git hooks/post-receive script.

gottcode pushed a commit to branch master
in repository panel-plugins/xfce4-whiskermenu-plugin.

commit 3c214f77c21ff00ef00df009ead36309cbcbf72a
Author: Graeme Gott <graeme at gottcode.org>
Date:   Wed Mar 12 12:31:18 2014 -0400

    Fixed crash when accessing null launcher in assert.
---
 panel-plugin/list-page.cpp |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/panel-plugin/list-page.cpp b/panel-plugin/list-page.cpp
index 04d9fea..1508ff7 100644
--- a/panel-plugin/list-page.cpp
+++ b/panel-plugin/list-page.cpp
@@ -154,9 +154,9 @@ void ListPage::on_row_changed(GtkTreeModel* model, GtkTreePath* path, GtkTreeIte
 
 	Launcher* launcher;
 	gtk_tree_model_get(model, iter, LauncherView::COLUMN_LAUNCHER, &launcher, -1);
-	g_assert(launcher->get_type() == Launcher::Type);
 	if (launcher)
 	{
+		g_assert(launcher->get_type() == Launcher::Type);
 		m_desktop_ids[pos] = launcher->get_desktop_id();
 		wm_settings->set_modified();
 	}
@@ -171,9 +171,9 @@ void ListPage::on_row_inserted(GtkTreeModel* model, GtkTreePath* path, GtkTreeIt
 	std::string desktop_id;
 	Launcher* launcher;
 	gtk_tree_model_get(model, iter, LauncherView::COLUMN_LAUNCHER, &launcher, -1);
-	g_assert(launcher->get_type() == Launcher::Type);
 	if (launcher)
 	{
+		g_assert(launcher->get_type() == Launcher::Type);
 		desktop_id = launcher->get_desktop_id();
 	}
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Xfce4-commits mailing list