[Xfce4-commits] [panel-plugins/xfce4-whiskermenu-plugin] 59/473: Prevent accidental implicit typecasting.

noreply at xfce.org noreply at xfce.org
Mon Feb 16 23:53:49 CET 2015


This is an automated email from the git hooks/post-receive script.

gottcode pushed a commit to branch master
in repository panel-plugins/xfce4-whiskermenu-plugin.

commit 865bb2628eb5c3a1ff612c79bd2de8207132d0d3
Author: Graeme Gott <graeme at gottcode.org>
Date:   Wed Jul 3 10:46:54 2013 -0400

    Prevent accidental implicit typecasting.
---
 src/applications_page.hpp    |    4 ++--
 src/configuration_dialog.hpp |    2 +-
 src/filter_page.hpp          |    2 +-
 src/launcher.hpp             |    2 +-
 src/launcher_model.hpp       |    2 +-
 src/menu.hpp                 |    2 +-
 src/page.hpp                 |    2 +-
 src/panel_plugin.hpp         |    2 +-
 src/query.cpp                |    6 ++++++
 src/query.hpp                |    3 ++-
 src/resizer_widget.hpp       |    2 +-
 src/search_page.hpp          |    2 +-
 12 files changed, 19 insertions(+), 12 deletions(-)

diff --git a/src/applications_page.hpp b/src/applications_page.hpp
index 587e5f8..a9b43af 100644
--- a/src/applications_page.hpp
+++ b/src/applications_page.hpp
@@ -41,7 +41,7 @@ class ApplicationsPage : public FilterPage
 	class Category
 	{
 	public:
-		Category(GarconMenuDirectory* directory);
+		explicit Category(GarconMenuDirectory* directory);
 
 		const gchar* get_icon() const
 		{
@@ -59,7 +59,7 @@ class ApplicationsPage : public FilterPage
 	};
 
 public:
-	ApplicationsPage(Menu* menu);
+	explicit ApplicationsPage(Menu* menu);
 	~ApplicationsPage();
 
 	void load_applications();
diff --git a/src/configuration_dialog.hpp b/src/configuration_dialog.hpp
index 3ba3320..5462414 100644
--- a/src/configuration_dialog.hpp
+++ b/src/configuration_dialog.hpp
@@ -32,7 +32,7 @@ class PanelPlugin;
 class ConfigurationDialog
 {
 public:
-	ConfigurationDialog(PanelPlugin* plugin);
+	explicit ConfigurationDialog(PanelPlugin* plugin);
 	~ConfigurationDialog();
 
 private:
diff --git a/src/filter_page.hpp b/src/filter_page.hpp
index db4b008..fc8753d 100644
--- a/src/filter_page.hpp
+++ b/src/filter_page.hpp
@@ -25,7 +25,7 @@ namespace WhiskerMenu
 class FilterPage : public Page
 {
 public:
-	FilterPage(Menu* menu);
+	explicit FilterPage(Menu* menu);
 	~FilterPage();
 
 	GtkTreeModel* get_model() const;
diff --git a/src/launcher.hpp b/src/launcher.hpp
index 39fb921..1fdad30 100644
--- a/src/launcher.hpp
+++ b/src/launcher.hpp
@@ -34,7 +34,7 @@ class Query;
 class Launcher
 {
 public:
-	Launcher(GarconMenuItem* item);
+	explicit Launcher(GarconMenuItem* item);
 	~Launcher();
 
 	const gchar* get_icon() const
diff --git a/src/launcher_model.hpp b/src/launcher_model.hpp
index 42156ef..731bd43 100644
--- a/src/launcher_model.hpp
+++ b/src/launcher_model.hpp
@@ -31,7 +31,7 @@ class LauncherModel
 {
 public:
 	LauncherModel();
-	LauncherModel(GtkListStore* model);
+	explicit LauncherModel(GtkListStore* model);
 	~LauncherModel();
 
 	GtkTreeModel* get_model() const
diff --git a/src/menu.hpp b/src/menu.hpp
index 5a56e6f..6cee971 100644
--- a/src/menu.hpp
+++ b/src/menu.hpp
@@ -42,7 +42,7 @@ class SearchPage;
 class Menu
 {
 public:
-	Menu(XfceRc* settings);
+	explicit Menu(XfceRc* settings);
 	~Menu();
 
 	GtkWidget* get_widget() const
diff --git a/src/page.hpp b/src/page.hpp
index 17d2561..a350466 100644
--- a/src/page.hpp
+++ b/src/page.hpp
@@ -35,7 +35,7 @@ class Menu;
 class Page
 {
 public:
-	Page(Menu* menu);
+	explicit Page(Menu* menu);
 	virtual ~Page();
 
 	GtkWidget* get_widget() const
diff --git a/src/panel_plugin.hpp b/src/panel_plugin.hpp
index a30932c..710f943 100644
--- a/src/panel_plugin.hpp
+++ b/src/panel_plugin.hpp
@@ -35,7 +35,7 @@ class Menu;
 class PanelPlugin
 {
 public:
-	PanelPlugin(XfcePanelPlugin* plugin);
+	explicit PanelPlugin(XfcePanelPlugin* plugin);
 	~PanelPlugin();
 
 	GtkWidget* get_button() const
diff --git a/src/query.cpp b/src/query.cpp
index fe91ee3..c9af7cc 100644
--- a/src/query.cpp
+++ b/src/query.cpp
@@ -37,6 +37,12 @@ static inline bool is_start_word(const std::string& string, std::string::size_ty
 
 //-----------------------------------------------------------------------------
 
+Query::Query()
+{
+}
+
+//-----------------------------------------------------------------------------
+
 Query::Query(const std::string& query)
 {
 	set(query);
diff --git a/src/query.hpp b/src/query.hpp
index 4e04b22..d70eb5b 100644
--- a/src/query.hpp
+++ b/src/query.hpp
@@ -26,7 +26,8 @@ namespace WhiskerMenu
 class Query
 {
 public:
-	Query(const std::string& query = std::string());
+	Query();
+	explicit Query(const std::string& query);
 	~Query();
 
 	bool empty() const
diff --git a/src/resizer_widget.hpp b/src/resizer_widget.hpp
index 730f458..e5d9175 100644
--- a/src/resizer_widget.hpp
+++ b/src/resizer_widget.hpp
@@ -32,7 +32,7 @@ namespace WhiskerMenu
 class ResizerWidget
 {
 public:
-	ResizerWidget(GtkWindow* window);
+	explicit ResizerWidget(GtkWindow* window);
 	~ResizerWidget();
 
 	GtkWidget* get_widget() const
diff --git a/src/search_page.hpp b/src/search_page.hpp
index 020b1cd..047ce9a 100644
--- a/src/search_page.hpp
+++ b/src/search_page.hpp
@@ -32,7 +32,7 @@ class LauncherView;
 class SearchPage : public FilterPage
 {
 public:
-	SearchPage(Menu* menu);
+	explicit SearchPage(Menu* menu);
 	~SearchPage();
 
 	void set_filter(const gchar* filter);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Xfce4-commits mailing list