[Xfce4-commits] [apps/xfdashboard] 01/02: Fix comments in XfdashboardFocusable regarding selection support

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

nomad pushed a commit to branch master
in repository apps/xfdashboard.

commit 802611b306a6b5ed694b054237f3cd18dba571f0
Author: Stephan Haller <nomad at froevel.de>
Date:   Wed Dec 16 09:22:16 2015 +0100

    Fix comments in XfdashboardFocusable regarding selection support
---
 xfdashboard/focusable.c |   20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/xfdashboard/focusable.c b/xfdashboard/focusable.c
index d46dd1b..fb7afab 100644
--- a/xfdashboard/focusable.c
+++ b/xfdashboard/focusable.c
@@ -750,9 +750,8 @@ ClutterActor* xfdashboard_focusable_get_selection(XfdashboardFocusable *self)
 
 	iface=XFDASHBOARD_FOCUSABLE_GET_IFACE(self);
 
-	/* If this focusable actor does not support selection we should ask for
-	 * the current selection and avoid the warning being printed if this
-	 * virtual function was not overridden.
+	/* If this focusable actor does not support selection return NULL
+	 * to indicate that no selection is available.
 	 */
 	if(!xfdashboard_focusable_supports_selection(self)) return(NULL);
 
@@ -779,9 +778,8 @@ gboolean xfdashboard_focusable_set_selection(XfdashboardFocusable *self, Clutter
 
 	iface=XFDASHBOARD_FOCUSABLE_GET_IFACE(self);
 
-	/* If this focusable actor does not support selection we should ask for
-	 * the current selection and avoid the warning being printed if this
-	 * virtual function was not overridden.
+	/* If this focusable actor does not support selection return FALSE
+	 * to indicate failure in setting selection.
 	 */
 	if(!xfdashboard_focusable_supports_selection(self)) return(FALSE);
 
@@ -865,9 +863,8 @@ ClutterActor* xfdashboard_focusable_find_selection(XfdashboardFocusable *self, C
 
 	iface=XFDASHBOARD_FOCUSABLE_GET_IFACE(self);
 
-	/* If this focusable actor does not support selection we should ask for
-	 * the current selection and avoid the warning being printed if this
-	 * virtual function was not overridden.
+	/* If this focusable actor does not support selection return NULL
+	 * to indicate that no selection cannot be found.
 	 */
 	if(!xfdashboard_focusable_supports_selection(self)) return(NULL);
 
@@ -892,9 +889,8 @@ gboolean xfdashboard_focusable_activate_selection(XfdashboardFocusable *self, Cl
 
 	iface=XFDASHBOARD_FOCUSABLE_GET_IFACE(self);
 
-	/* If this focusable actor does not support selection we should ask for
-	 * the current selection and avoid the warning being printed if this
-	 * virtual function was not overridden.
+	/* If this focusable actor does not support selection return FALSE
+	 * to indicate failure in activating selection as no one is available.
 	 */
 	if(!xfdashboard_focusable_supports_selection(self)) return(FALSE);
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.