[Xfce4-commits] [panel-plugins/xfce4-hardware-monitor-plugin] 13/13: Finally fixed why the CurveView text overlay sometimes doesnt show on initialisation

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

omegaphil pushed a commit to branch master
in repository panel-plugins/xfce4-hardware-monitor-plugin.

commit 539e35a9a147c015c79bfbb0d8148c03b15886b4
Author: OmegaPhil <OmegaPhil at startmail.com>
Date:   Wed Aug 12 17:34:13 2015 +0100

    Finally fixed why the CurveView text overlay sometimes doesnt show on initialisation
---
 src/applet.cpp     |    6 ++++--
 src/curve-view.cpp |    5 +----
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/applet.cpp b/src/applet.cpp
index d9a7b76..2cc73f7 100644
--- a/src/applet.cpp
+++ b/src/applet.cpp
@@ -162,14 +162,16 @@ Applet::Applet(XfcePanelPlugin *plugin)
   viewer_type("curve"),
   viewer_font(""),
   viewer_size(96),  // Arbitrary default, see later in this function for notes
-  background_color(0x00000000),  // black as the night
+  background_color(0x000000FF),  // Black as the night - note that the
+                                 // transparency bits need to be set to max to
+                                 // ensure the colour is visible
   use_background_color(false),
   next_color(0),
   viewer_text_overlay_enabled(false),
   viewer_text_overlay_format_string("%a %m"),
   viewer_text_overlay_separator(" "),
   viewer_text_overlay_font(""),
-  viewer_text_overlay_color(0x00000000),
+  viewer_text_overlay_color(0x000000FF),
   viewer_text_overlay_position(CurveView::top_left)
 {
   // Search for settings file
diff --git a/src/curve-view.cpp b/src/curve-view.cpp
index f23b674..cc3b06b 100644
--- a/src/curve-view.cpp
+++ b/src/curve-view.cpp
@@ -346,10 +346,7 @@ void CurveView::do_draw_loop()
     if (graph_max_compact_needed)
       find_and_replace(overlay_text, graph_max_compact, max_formatted_compact);
 
-    /* Checking if overlay is already initialised
-     * Possibility that text is not shown at start up - not failing consistently
-     * now though, when it does, even resetting via switching views is not enough */
-    // TODO: Still a bug here
+    // Checking if overlay is already initialised
     if (!text_overlay)
     {
       /* Font and colour are required to output text, anchor is used to define

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.