[Xfce4-commits] [xfce/xfwm4] 01/02: Use source indication in activate window

[noreply at xfce.org]

This is an automated email from the git hooks/post-receive script.

olivier pushed a commit to branch master
in repository xfce/xfwm4.

commit 1a20a884e5cd33255e822f42a73bbe83ff89aea1
Author: Olivier Fourdan <fourdan at xfce.org>
Date:   Wed Dec 10 22:21:19 2014 +0100

    Use source indication in activate window
    
    Bug: 10747
    
    xfce4-panel was not setting the source indication
    for NET_ACTIVE_WINDOW messages so we could not use it.
    
    Bug 10508 got that fiex in xfce4-panel so we can (and must)
    use the source indication.
    
    Note, this will break with earlier (broken) xfce4-panel
    versions.
    
    Signed-off-by: Olivier Fourdan <fourdan at xfce.org>
---
 src/client.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/client.c b/src/client.c
index db04561..033a40a 100644
--- a/src/client.c
+++ b/src/client.c
@@ -2511,12 +2511,12 @@ clientActivate (Client *c, guint32 timestamp, gboolean source_is_application)
         }
         clientRaise (sibling, None);
         clientShow (sibling, TRUE);
-        if (source_is_application || screen_info->params->click_to_focus || (c->type & WINDOW_TYPE_DONT_FOCUS))
+        if (!source_is_application || screen_info->params->click_to_focus || (c->type & WINDOW_TYPE_DONT_FOCUS))
         {
             /*
                It's a bit tricky here, we want to honor the activate request only if:
 
-               - The window use the _NET_ACTIVE_WINDOW protocol and identify itself as an application,
+               - The window use the _NET_ACTIVE_WINDOW protocol and identify itself as a pager,
                - Or we use the click to focus model, in that case we focus the raised window anyway,
                - Or the request comes from an application that we would not focus by default,
                  such as panels for example

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.