[Xfce4-commits] [apps/parole] 01/01: Use libxfce4ui's versioned help call for the docs

noreply at xfce.org noreply at xfce.org
Tue Dec 9 01:21:58 CET 2014


This is an automated email from the git hooks/post-receive script.

ochosi pushed a commit to branch master
in repository apps/parole.

commit 707e6bbcf0da60c232107ed806a45c5b3b9d0557
Author: Simon Steinbeiss <simon.steinbeiss at elfenbeinturm.at>
Date:   Tue Dec 9 01:21:24 2014 +0100

    Use libxfce4ui's versioned help call for the docs
---
 configure.ac.in     |   10 ++++++++++
 src/parole-player.c |   14 +-------------
 2 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/configure.ac.in b/configure.ac.in
index 04a9241..a05c487 100644
--- a/configure.ac.in
+++ b/configure.ac.in
@@ -61,6 +61,16 @@ AC_SUBST([PAROLE_VERSION_MAJOR])
 AC_SUBST([PAROLE_VERSION_MINOR])
 AC_SUBST([PAROLE_VERSION_MICRO])
 
+dnl define a short version string for parole
+m4_append([parole_version_short], ["])
+m4_append([parole_version_short], [parole_version_major])
+m4_append([parole_version_short], [.])
+m4_append([parole_version_short], [parole_version_minor])
+m4_append([parole_version_short], ["])
+
+dnl define parole's short version (major.minor)
+AC_DEFINE([PAROLE_VERSION_SHORT], [parole_version_short], [Short version string of parole])
+
 # ===================================================== #
 #   Check for headers needed for standard interfaces    #
 # ===================================================== #
diff --git a/src/parole-player.c b/src/parole-player.c
index 26ea662..c771efb 100644
--- a/src/parole-player.c
+++ b/src/parole-player.c
@@ -2817,19 +2817,7 @@ on_bug_report_clicked (GtkWidget *w, ParolePlayer *player)
 static void
 on_contents_clicked (GtkWidget *w, ParolePlayer *player)
 {
-    GtkWidget *dialog;
-    if (!gtk_show_uri(NULL, "http://docs.xfce.org/apps/parole/start", GDK_CURRENT_TIME, NULL))
-    {
-        dialog = gtk_message_dialog_new(GTK_WINDOW(player->priv->window),
-                                        GTK_DIALOG_DESTROY_WITH_PARENT,
-                                        GTK_MESSAGE_ERROR,
-                                        GTK_BUTTONS_CLOSE,
-                                        _("Unable to open default web browser"));
-        gtk_message_dialog_format_secondary_text(GTK_MESSAGE_DIALOG(dialog),
-                _("Please go to http://docs.xfce.org/apps/parole/start to read Parole's online documentation."));
-        gtk_dialog_run(GTK_DIALOG(dialog));
-        gtk_widget_destroy(dialog);
-    }
+    xfce_dialog_show_help_with_version (NULL, "parole", "start", NULL, PAROLE_VERSION_SHORT);
 }
 
 static gboolean

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the Xfce4-commits mailing list