[Xfce4-commits] <midori:master> midori/midori-browser.c: Initialize variable `id` in `midori_bookmark_folder_button_new`

[Christian Dywan]

Updating branch refs/heads/master
         to 66efc4ad2d04cfd973753a25fdf25479ad529ce4 (commit)
       from 626407f20bc46562d2dd1abb16abaa18c9f29c9d (commit)

commit 66efc4ad2d04cfd973753a25fdf25479ad529ce4
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Wed Jan 9 11:18:35 2013 +0100

    midori/midori-browser.c: Initialize variable `id` in `midori_bookmark_folder_button_new`
    
        $ clang --version
        Debian clang version 3.2-9 (tags/RELEASE_32/final) (based on LLVM 3.2)
        Target: i386-pc-linux-gnu
        Thread model: posix
        […]
        [ 26/151] cc: midori/midori-browser.c -> _build/default/midori/midori-browser_1.o
        clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
        warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
        1 warning generated.
        [ 27/151] cc: midori/midori-extension.c -> _build/default/midori/midori-extension_1.o
        clang: warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'?
        warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
        ../midori/midori-browser.c:750:9: warning: variable 'id' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
            if (gtk_combo_box_get_active_iter (GTK_COMBO_BOX (combo), &iter))
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        ../midori/midori-browser.c:762:12: note: uninitialized use occurs here
            return id;
                   ^~
        ../midori/midori-browser.c:750:5: note: remove the 'if' if its condition is always true
            if (gtk_combo_box_get_active_iter (GTK_COMBO_BOX (combo), &iter))
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        ../midori/midori-browser.c:745:14: note: initialize the variable 'id' to silence this warning
            gint64 id;
                     ^
                      = 0
        1 warning generated.
    
    Addresses: https://bugs.launchpad.net/midori/+bug/1097670

 midori/midori-browser.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/midori/midori-browser.c b/midori/midori-browser.c
index 33471c3..1b28c39 100644
--- a/midori/midori-browser.c
+++ b/midori/midori-browser.c
@@ -742,7 +742,7 @@ midori_bookmark_folder_button_new (KatzeArray* array,
 static gint64
 midori_bookmark_folder_button_get_active (GtkWidget* combo)
 {
-    gint64 id;
+    gint64 id = 0;
     GtkTreeIter iter;
 
     g_return_val_if_fail (GTK_IS_COMBO_BOX (combo), 0);