[Xfce4-commits] <midori:master> webkit_web_view_get_tls_info provides an unowned ref - so ref it

Christian Dywan noreply at xfce.org
Sun Apr 7 21:34:02 CEST 2013


Updating branch refs/heads/master
         to e7e101038e12d2f1bf3bec610f2450ffcd4902bd (commit)
       from 68b2b4fb66cfb651adf5e526fae03ca5c4d533a9 (commit)

commit e7e101038e12d2f1bf3bec610f2450ffcd4902bd
Author: Christian Dywan <christian at twotoasts.de>
Date:   Sun Apr 7 21:32:42 2013 +0200

    webkit_web_view_get_tls_info provides an unowned ref - so ref it

 midori/midori-view.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/midori/midori-view.c b/midori/midori-view.c
index 93dd632..90a0047 100644
--- a/midori/midori-view.c
+++ b/midori/midori-view.c
@@ -735,7 +735,9 @@ midori_view_get_tls_info (MidoriView*           view,
     #ifdef HAVE_WEBKIT2
     WebKitWebView* web_view = WEBKIT_WEB_VIEW (view->web_view);
     *hostname = midori_uri_parse_hostname (webkit_web_view_get_uri (web_view), NULL);
-    return webkit_web_view_get_tls_info (web_view, tls_cert, tls_flags);
+    gboolean success = webkit_web_view_get_tls_info (web_view, tls_cert, tls_flags);
+    g_object_ref (*tls_cert);
+    return success;
     #else
     SoupMessage* message = midori_map_get_message (webkit_network_request_get_message (request));
     if (message != NULL)
@@ -861,8 +863,9 @@ midori_view_web_view_navigation_decision_cb (WebKitWebView*             web_view
                 else
                     g_warn_if_reached ();
                 g_object_unref (gcr_cert);
-                g_object_unref (tls_cert);
             }
+            if (tls_cert != NULL)
+                g_object_unref (tls_cert);
             g_free (hostname);
         }
     }


More information about the Xfce4-commits mailing list