[Xfce4-commits] <thunar:master> Don't update entry name after rename (bug #8452).

Nick Schermer noreply at xfce.org
Tue Oct 2 17:46:01 CEST 2012


Updating branch refs/heads/master
         to 02de74a76f493837a12925248187206651f26439 (commit)
       from 32b56bc3b41074a468404679ea50e4db0f54f6b4 (commit)

commit 02de74a76f493837a12925248187206651f26439
Author: Nick Schermer <nick at xfce.org>
Date:   Tue Oct 2 17:43:19 2012 +0200

    Don't update entry name after rename (bug #8452).
    
    If the job succeeded the typed name is also the new name. In the
    worst case, we have to wait 800ms for the file monitor.
    
    What could easily happen was an invalid file because of the rename
    resulting in a possible segfault.

 thunar/thunar-properties-dialog.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/thunar/thunar-properties-dialog.c b/thunar/thunar-properties-dialog.c
index fef4417..8370a9b 100644
--- a/thunar/thunar-properties-dialog.c
+++ b/thunar/thunar-properties-dialog.c
@@ -686,18 +686,10 @@ static void
 thunar_properties_dialog_rename_finished (ExoJob                 *job,
                                           ThunarPropertiesDialog *dialog)
 {
-  const gchar *new_name;
-
   _thunar_return_if_fail (EXO_IS_JOB (job));
   _thunar_return_if_fail (THUNAR_IS_PROPERTIES_DIALOG (dialog));
   _thunar_return_if_fail (g_list_length (dialog->files) == 1);
 
-  /* determine the new display name */
-  new_name = thunar_file_get_display_name (THUNAR_FILE (dialog->files->data));
-
-  /* reset the entry widget to the new name */
-  gtk_entry_set_text (GTK_ENTRY (dialog->name_entry), new_name);
-
   g_signal_handlers_disconnect_matched (job, G_SIGNAL_MATCH_DATA, 0, 0, NULL, NULL, dialog);
   g_object_unref (job);
 }


More information about the Xfce4-commits mailing list