[Xfce4-commits] <forum:master> Update to fluxbb 1.4.9.
Nick Schermer
noreply at xfce.org
Tue May 15 18:04:01 CEST 2012
Updating branch refs/heads/master
to a0a7c6ef04c1e611ba44347f2c245f9e15eaf7a1 (commit)
from 3ac209e486f1d3488b158a32a427fd3b2ca2c0cb (commit)
commit a0a7c6ef04c1e611ba44347f2c245f9e15eaf7a1
Author: Nick Schermer <nick at xfce.org>
Date: Tue May 15 18:02:55 2012 +0200
Update to fluxbb 1.4.9.
admin_bans.php | 12 ++--
admin_categories.php | 4 +-
admin_censoring.php | 2 +-
admin_forums.php | 4 +-
admin_groups.php | 10 ++--
admin_index.php | 2 +-
admin_loader.php | 4 +-
admin_maintenance.php | 8 ++--
admin_options.php | 94 ++++++++++++++++++------------------
admin_permissions.php | 6 ++-
admin_ranks.php | 6 +-
admin_reports.php | 2 +-
admin_users.php | 26 +++++-----
db_update.php | 28 ++++++------
delete.php | 8 ++--
edit.php | 8 ++--
help.php | 2 +-
include/common.php | 2 +-
include/dblayer/mysql.php | 8 ++--
include/dblayer/mysql_innodb.php | 8 ++--
include/dblayer/mysqli.php | 8 ++--
include/dblayer/mysqli_innodb.php | 8 ++--
include/dblayer/pgsql.php | 2 +-
include/dblayer/sqlite.php | 2 +-
include/functions.php | 33 +++++++------
include/parser.php | 8 ++--
include/search_idx.php | 5 ++-
include/utf8/strcspn.php | 2 +-
include/utf8/strspn.php | 2 +-
include/utf8/substr_replace.php | 2 +-
index.php | 2 +-
login.php | 2 +-
misc.php | 14 ++++-
moderate.php | 33 +++++++++----
post.php | 20 +++-----
profile.php | 54 ++++++++++++---------
register.php | 4 +-
search.php | 14 +++---
style/Technetium.css | 2 +-
userlist.php | 4 +-
viewforum.php | 14 +++---
viewtopic.php | 8 ++--
42 files changed, 262 insertions(+), 225 deletions(-)
diff --git a/admin_bans.php b/admin_bans.php
index ec5aa96..8b70428 100644
--- a/admin_bans.php
+++ b/admin_bans.php
@@ -15,7 +15,7 @@ require PUN_ROOT.'include/common_admin.php';
if ($pun_user['g_id'] != PUN_ADMIN && ($pun_user['g_moderator'] != '1' || $pun_user['g_mod_ban_users'] == '0'))
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the admin_bans.php language file
require PUN_ROOT.'lang/'.$admin_language.'/admin_bans.php';
@@ -183,10 +183,10 @@ else if (isset($_POST['add_edit_ban']))
confirm_referrer('admin_bans.php');
$ban_user = pun_trim($_POST['ban_user']);
- $ban_ip = trim($_POST['ban_ip']);
- $ban_email = strtolower(trim($_POST['ban_email']));
+ $ban_ip = pun_trim($_POST['ban_ip']);
+ $ban_email = strtolower(pun_trim($_POST['ban_email']));
$ban_message = pun_trim($_POST['ban_message']);
- $ban_expire = trim($_POST['ban_expire']);
+ $ban_expire = pun_trim($_POST['ban_expire']);
if ($ban_user == '' && $ban_ip == '' && $ban_email == '')
message($lang_admin_bans['Must enter message']);
@@ -330,8 +330,8 @@ else if (isset($_GET['find_ban']))
$form = array_map('pun_trim', $form);
$conditions = $query_str = array();
- $expire_after = isset($_GET['expire_after']) ? trim($_GET['expire_after']) : '';
- $expire_before = isset($_GET['expire_before']) ? trim($_GET['expire_before']) : '';
+ $expire_after = isset($_GET['expire_after']) ? pun_trim($_GET['expire_after']) : '';
+ $expire_before = isset($_GET['expire_before']) ? pun_trim($_GET['expire_before']) : '';
$order_by = isset($_GET['order_by']) && in_array($_GET['order_by'], array('username', 'ip', 'email', 'expire')) ? 'b.'.$_GET['order_by'] : 'b.username';
$direction = isset($_GET['direction']) && $_GET['direction'] == 'DESC' ? 'DESC' : 'ASC';
diff --git a/admin_categories.php b/admin_categories.php
index 5baf447..ab4d430 100644
--- a/admin_categories.php
+++ b/admin_categories.php
@@ -15,7 +15,7 @@ require PUN_ROOT.'include/common_admin.php';
if ($pun_user['g_id'] != PUN_ADMIN)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the admin_categories.php language file
require PUN_ROOT.'lang/'.$admin_language.'/admin_categories.php';
@@ -133,7 +133,7 @@ else if (isset($_POST['update'])) // Change position and name of the categories
foreach ($categories as $cat_id => $cur_cat)
{
$cur_cat['name'] = pun_trim($cur_cat['name']);
- $cur_cat['order'] = trim($cur_cat['order']);
+ $cur_cat['order'] = pun_trim($cur_cat['order']);
if ($cur_cat['name'] == '')
message($lang_admin_categories['Must enter name message']);
diff --git a/admin_censoring.php b/admin_censoring.php
index de2c844..420ca62 100644
--- a/admin_censoring.php
+++ b/admin_censoring.php
@@ -15,7 +15,7 @@ require PUN_ROOT.'include/common_admin.php';
if ($pun_user['g_id'] != PUN_ADMIN)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the admin_censoring.php language file
require PUN_ROOT.'lang/'.$admin_language.'/admin_censoring.php';
diff --git a/admin_forums.php b/admin_forums.php
index c069392..1f1c13f 100644
--- a/admin_forums.php
+++ b/admin_forums.php
@@ -15,7 +15,7 @@ require PUN_ROOT.'include/common_admin.php';
if ($pun_user['g_id'] != PUN_ADMIN)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the admin_forums.php language file
require PUN_ROOT.'lang/'.$admin_language.'/admin_forums.php';
@@ -159,7 +159,7 @@ else if (isset($_GET['edit_forum']))
$forum_desc = pun_linebreaks(pun_trim($_POST['forum_desc']));
$cat_id = intval($_POST['cat_id']);
$sort_by = intval($_POST['sort_by']);
- $redirect_url = isset($_POST['redirect_url']) ? trim($_POST['redirect_url']) : null;
+ $redirect_url = isset($_POST['redirect_url']) ? pun_trim($_POST['redirect_url']) : null;
if ($forum_name == '')
message($lang_admin_forums['Must enter name message']);
diff --git a/admin_groups.php b/admin_groups.php
index fa00b4f..888befc 100644
--- a/admin_groups.php
+++ b/admin_groups.php
@@ -15,7 +15,7 @@ require PUN_ROOT.'include/common_admin.php';
if ($pun_user['g_id'] != PUN_ADMIN)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the admin_censoring.php language file
require PUN_ROOT.'lang/'.$admin_language.'/admin_groups.php';
@@ -267,10 +267,10 @@ else if (isset($_POST['add_edit_group']))
$search = isset($_POST['search']) ? intval($_POST['search']) : '1';
$search_users = isset($_POST['search_users']) ? intval($_POST['search_users']) : '1';
$send_email = (isset($_POST['send_email']) && $_POST['send_email'] == '1') || $is_admin_group ? '1' : '0';
- $post_flood = isset($_POST['post_flood']) ? intval($_POST['post_flood']) : '0';
- $search_flood = isset($_POST['search_flood']) ? intval($_POST['search_flood']) : '0';
- $email_flood = isset($_POST['email_flood']) ? intval($_POST['email_flood']) : '0';
- $report_flood = isset($_POST['report_flood']) ? intval($_POST['report_flood']) : '0';
+ $post_flood = (isset($_POST['post_flood']) && $_POST['post_flood'] >= 0) ? intval($_POST['post_flood']) : '0';
+ $search_flood = (isset($_POST['search_flood']) && $_POST['search_flood'] >= 0) ? intval($_POST['search_flood']) : '0';
+ $email_flood = (isset($_POST['email_flood']) && $_POST['email_flood'] >= 0) ? intval($_POST['email_flood']) : '0';
+ $report_flood = (isset($_POST['report_flood']) && $_POST['report_flood'] >= 0) ? intval($_POST['report_flood']) : '0';
if ($title == '')
message($lang_admin_groups['Must enter title message']);
diff --git a/admin_index.php b/admin_index.php
index 3515e13..5d82031 100644
--- a/admin_index.php
+++ b/admin_index.php
@@ -15,7 +15,7 @@ require PUN_ROOT.'include/common_admin.php';
if (!$pun_user['is_admmod'])
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the admin_index.php language file
require PUN_ROOT.'lang/'.$admin_language.'/admin_index.php';
diff --git a/admin_loader.php b/admin_loader.php
index 4891f72..0eedc47 100644
--- a/admin_loader.php
+++ b/admin_loader.php
@@ -15,7 +15,7 @@ require PUN_ROOT.'include/common_admin.php';
if (!$pun_user['is_admmod'])
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// The plugin to load should be supplied via GET
$plugin = isset($_GET['plugin']) ? $_GET['plugin'] : '';
@@ -25,7 +25,7 @@ if (!preg_match('%^AM?P_(\w*?)\.php$%i', $plugin))
// AP_ == Admins only, AMP_ == admins and moderators
$prefix = substr($plugin, 0, strpos($plugin, '_'));
if ($pun_user['g_moderator'] == '1' && $prefix == 'AP')
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Make sure the file actually exists
if (!file_exists(PUN_ROOT.'plugins/'.$plugin))
diff --git a/admin_maintenance.php b/admin_maintenance.php
index 600d434..aff2958 100644
--- a/admin_maintenance.php
+++ b/admin_maintenance.php
@@ -17,12 +17,12 @@ require PUN_ROOT.'include/common_admin.php';
if ($pun_user['g_id'] != PUN_ADMIN)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the admin_maintenance.php language file
require PUN_ROOT.'lang/'.$admin_language.'/admin_maintenance.php';
-$action = isset($_REQUEST['action']) ? trim($_REQUEST['action']) : '';
+$action = isset($_REQUEST['action']) ? pun_trim($_REQUEST['action']) : '';
if ($action == 'rebuild')
{
@@ -125,7 +125,7 @@ h1 {
if ($action == 'prune')
{
- $prune_from = trim($_POST['prune_from']);
+ $prune_from = pun_trim($_POST['prune_from']);
$prune_sticky = intval($_POST['prune_sticky']);
if (isset($_POST['prune_comply']))
@@ -172,7 +172,7 @@ if ($action == 'prune')
redirect('admin_maintenance.php', $lang_admin_maintenance['Posts pruned redirect']);
}
- $prune_days = trim($_POST['req_prune_days']);
+ $prune_days = pun_trim($_POST['req_prune_days']);
if ($prune_days == '' || preg_match('%[^0-9]%', $prune_days))
message($lang_admin_maintenance['Days must be integer message']);
diff --git a/admin_options.php b/admin_options.php
index 3e8581e..48e2244 100644
--- a/admin_options.php
+++ b/admin_options.php
@@ -15,7 +15,7 @@ require PUN_ROOT.'include/common_admin.php';
if ($pun_user['g_id'] != PUN_ADMIN)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the admin_options.php language file
require PUN_ROOT.'lang/'.$admin_language.'/admin_options.php';
@@ -34,20 +34,20 @@ if (isset($_POST['form_sent']))
'default_style' => pun_trim($_POST['form']['default_style']),
'time_format' => pun_trim($_POST['form']['time_format']),
'date_format' => pun_trim($_POST['form']['date_format']),
- 'timeout_visit' => intval($_POST['form']['timeout_visit']),
- 'timeout_online' => intval($_POST['form']['timeout_online']),
- 'redirect_delay' => intval($_POST['form']['redirect_delay']),
+ 'timeout_visit' => (intval($_POST['form']['timeout_visit']) > 0) ? intval($_POST['form']['timeout_visit']) : 1,
+ 'timeout_online' => (intval($_POST['form']['timeout_online']) > 0) ? intval($_POST['form']['timeout_online']) : 1,
+ 'redirect_delay' => (intval($_POST['form']['redirect_delay']) >= 0) ? intval($_POST['form']['redirect_delay']) : 0,
'show_version' => $_POST['form']['show_version'] != '1' ? '0' : '1',
'show_user_info' => $_POST['form']['show_user_info'] != '1' ? '0' : '1',
'show_post_count' => $_POST['form']['show_post_count'] != '1' ? '0' : '1',
'smilies' => $_POST['form']['smilies'] != '1' ? '0' : '1',
'smilies_sig' => $_POST['form']['smilies_sig'] != '1' ? '0' : '1',
'make_links' => $_POST['form']['make_links'] != '1' ? '0' : '1',
- 'topic_review' => intval($_POST['form']['topic_review']),
+ 'topic_review' => (intval($_POST['form']['topic_review']) >= 0) ? intval($_POST['form']['topic_review']) : 0,
'disp_topics_default' => intval($_POST['form']['disp_topics_default']),
'disp_posts_default' => intval($_POST['form']['disp_posts_default']),
- 'indent_num_spaces' => intval($_POST['form']['indent_num_spaces']),
- 'quote_depth' => intval($_POST['form']['quote_depth']),
+ 'indent_num_spaces' => (intval($_POST['form']['indent_num_spaces']) >= 0) ? intval($_POST['form']['indent_num_spaces']) : 0,
+ 'quote_depth' => (intval($_POST['form']['quote_depth']) > 0) ? intval($_POST['form']['quote_depth']) : 1,
'quickpost' => $_POST['form']['quickpost'] != '1' ? '0' : '1',
'users_online' => $_POST['form']['users_online'] != '1' ? '0' : '1',
'censoring' => $_POST['form']['censoring'] != '1' ? '0' : '1',
@@ -65,9 +65,9 @@ if (isset($_POST['form_sent']))
'mailing_list' => pun_trim($_POST['form']['mailing_list']),
'avatars' => $_POST['form']['avatars'] != '1' ? '0' : '1',
'avatars_dir' => pun_trim($_POST['form']['avatars_dir']),
- 'avatars_width' => intval($_POST['form']['avatars_width']),
- 'avatars_height' => intval($_POST['form']['avatars_height']),
- 'avatars_size' => intval($_POST['form']['avatars_size']),
+ 'avatars_width' => (intval($_POST['form']['avatars_width']) > 0) ? intval($_POST['form']['avatars_width']) : 1,
+ 'avatars_height' => (intval($_POST['form']['avatars_height']) > 0) ? intval($_POST['form']['avatars_height']) : 1,
+ 'avatars_size' => (intval($_POST['form']['avatars_size']) > 0) ? intval($_POST['form']['avatars_size']) : 1,
'admin_email' => strtolower(pun_trim($_POST['form']['admin_email'])),
'webmaster_email' => strtolower(pun_trim($_POST['form']['webmaster_email'])),
'forum_subscriptions' => $_POST['form']['forum_subscriptions'] != '1' ? '0' : '1',
@@ -303,7 +303,7 @@ generate_admin_menu('options');
<tr>
<th scope="row"><?php echo $lang_admin_options['DST label'] ?></th>
<td>
- <input type="radio" name="form[default_dst]" value="1"<?php if ($pun_config['o_default_dst'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[default_dst]" value="0"<?php if ($pun_config['o_default_dst'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[default_dst]" id="form_default_dst_1" value="1"<?php if ($pun_config['o_default_dst'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_default_dst_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[default_dst]" id="form_default_dst_0" value="0"<?php if ($pun_config['o_default_dst'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_default_dst_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['DST help'] ?></span>
</td>
</tr>
@@ -411,42 +411,42 @@ generate_admin_menu('options');
<tr>
<th scope="row"><?php echo $lang_admin_options['Version number label'] ?></th>
<td>
- <input type="radio" name="form[show_version]" value="1"<?php if ($pun_config['o_show_version'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[show_version]" value="0"<?php if ($pun_config['o_show_version'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[show_version]" id="form_show_version_1" value="1"<?php if ($pun_config['o_show_version'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_show_version_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[show_version]" id="form_show_version_0" value="0"<?php if ($pun_config['o_show_version'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_show_version_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Version number help'] ?></span>
</td>
</tr>
<tr>
<th scope="row"><?php echo $lang_admin_options['Info in posts label'] ?></th>
<td>
- <input type="radio" name="form[show_user_info]" value="1"<?php if ($pun_config['o_show_user_info'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[show_user_info]" value="0"<?php if ($pun_config['o_show_user_info'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[show_user_info]" id="form_show_user_info_1" value="1"<?php if ($pun_config['o_show_user_info'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_show_user_info_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[show_user_info]" id="form_show_user_info_0" value="0"<?php if ($pun_config['o_show_user_info'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_show_user_info_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Info in posts help'] ?></span>
</td>
</tr>
<tr>
<th scope="row"><?php echo $lang_admin_options['Post count label'] ?></th>
<td>
- <input type="radio" name="form[show_post_count]" value="1"<?php if ($pun_config['o_show_post_count'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[show_post_count]" value="0"<?php if ($pun_config['o_show_post_count'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[show_post_count]" id="form_show_post_count_1" value="1"<?php if ($pun_config['o_show_post_count'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_show_post_count_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[show_post_count]" id="form_show_post_count_0" value="0"<?php if ($pun_config['o_show_post_count'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_show_post_count_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Post count help'] ?></span>
</td>
</tr>
<tr>
<th scope="row"><?php echo $lang_admin_options['Smilies label'] ?></th>
<td>
- <input type="radio" name="form[smilies]" value="1"<?php if ($pun_config['o_smilies'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[smilies]" value="0"<?php if ($pun_config['o_smilies'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[smilies]" id="form_smilies_1" value="1"<?php if ($pun_config['o_smilies'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_smilies_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[smilies]" id="form_smilies_0" value="0"<?php if ($pun_config['o_smilies'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_smilies_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Smilies help'] ?></span>
</td>
</tr>
<tr>
<th scope="row"><?php echo $lang_admin_options['Smilies sigs label'] ?></th>
<td>
- <input type="radio" name="form[smilies_sig]" value="1"<?php if ($pun_config['o_smilies_sig'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[smilies_sig]" value="0"<?php if ($pun_config['o_smilies_sig'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[smilies_sig]" id="form_smilies_sig_1" value="1"<?php if ($pun_config['o_smilies_sig'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_smilies_sig_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[smilies_sig]" id="form_smilies_sig_0" value="0"<?php if ($pun_config['o_smilies_sig'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_smilies_sig_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Smilies sigs help'] ?></span>
</td>
</tr>
<tr>
<th scope="row"><?php echo $lang_admin_options['Clickable links label'] ?></th>
<td>
- <input type="radio" name="form[make_links]" value="1"<?php if ($pun_config['o_make_links'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[make_links]" value="0"<?php if ($pun_config['o_make_links'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[make_links]" id="form_make_links_1" value="1"<?php if ($pun_config['o_make_links'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_make_links_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[make_links]" id="form_make_links_0" value="0"<?php if ($pun_config['o_make_links'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_make_links_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Clickable links help'] ?></span>
</td>
</tr>
@@ -497,70 +497,70 @@ generate_admin_menu('options');
<tr>
<th scope="row"><?php echo $lang_admin_options['Quick post label'] ?></th>
<td>
- <input type="radio" name="form[quickpost]" value="1"<?php if ($pun_config['o_quickpost'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[quickpost]" value="0"<?php if ($pun_config['o_quickpost'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[quickpost]" id="form_quickpost_1" value="1"<?php if ($pun_config['o_quickpost'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_quickpost_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[quickpost]" id="form_quickpost_0" value="0"<?php if ($pun_config['o_quickpost'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_quickpost_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Quick post help'] ?></span>
</td>
</tr>
<tr>
<th scope="row"><?php echo $lang_admin_options['Users online label'] ?></th>
<td>
- <input type="radio" name="form[users_online]" value="1"<?php if ($pun_config['o_users_online'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[users_online]" value="0"<?php if ($pun_config['o_users_online'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[users_online]" id="form_users_online_1" value="1"<?php if ($pun_config['o_users_online'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_users_online_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[users_online]" id="form_users_online_0" value="0"<?php if ($pun_config['o_users_online'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_users_online_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Users online help'] ?></span>
</td>
</tr>
<tr>
- <th scope="row"><a name="censoring"><?php echo $lang_admin_options['Censor words label'] ?></a></th>
+ <th scope="row"><a name="censoring"></a><?php echo $lang_admin_options['Censor words label'] ?></th>
<td>
- <input type="radio" name="form[censoring]" value="1"<?php if ($pun_config['o_censoring'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[censoring]" value="0"<?php if ($pun_config['o_censoring'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[censoring]" id="form_censoring_1" value="1"<?php if ($pun_config['o_censoring'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_censoring_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[censoring]" id="form_censoring_0" value="0"<?php if ($pun_config['o_censoring'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_censoring_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php printf($lang_admin_options['Censor words help'], '<a href="admin_censoring.php">'.$lang_admin_common['Censoring'].'</a>') ?></span>
</td>
</tr>
<tr>
- <th scope="row"><a name="signatures"><?php echo $lang_admin_options['Signatures label'] ?></a></th>
+ <th scope="row"><a name="signatures"></a><?php echo $lang_admin_options['Signatures label'] ?></th>
<td>
- <input type="radio" name="form[signatures]" value="1"<?php if ($pun_config['o_signatures'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[signatures]" value="0"<?php if ($pun_config['o_signatures'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[signatures]" id="form_signatures_1" value="1"<?php if ($pun_config['o_signatures'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_signatures_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[signatures]" id="form_signatures_0" value="0"<?php if ($pun_config['o_signatures'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_signatures_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Signatures help'] ?></span>
</td>
</tr>
<tr>
- <th scope="row"><a name="ranks"><?php echo $lang_admin_options['User ranks label'] ?></a></th>
+ <th scope="row"><a name="ranks"></a><?php echo $lang_admin_options['User ranks label'] ?></th>
<td>
- <input type="radio" name="form[ranks]" value="1"<?php if ($pun_config['o_ranks'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[ranks]" value="0"<?php if ($pun_config['o_ranks'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[ranks]" id="form_ranks_1" value="1"<?php if ($pun_config['o_ranks'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_ranks_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[ranks]" id="form_ranks_0" value="0"<?php if ($pun_config['o_ranks'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_ranks_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php printf($lang_admin_options['User ranks help'], '<a href="admin_ranks.php">'.$lang_admin_common['Ranks'].'</a>') ?></span>
</td>
</tr>
<tr>
<th scope="row"><?php echo $lang_admin_options['User has posted label'] ?></th>
<td>
- <input type="radio" name="form[show_dot]" value="1"<?php if ($pun_config['o_show_dot'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[show_dot]" value="0"<?php if ($pun_config['o_show_dot'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[show_dot]" id="form_show_dot_1" value="1"<?php if ($pun_config['o_show_dot'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_show_dot_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[show_dot]" id="form_show_dot_0" value="0"<?php if ($pun_config['o_show_dot'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_show_dot_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['User has posted help'] ?></span>
</td>
</tr>
<tr>
<th scope="row"><?php echo $lang_admin_options['Topic views label'] ?></th>
<td>
- <input type="radio" name="form[topic_views]" value="1"<?php if ($pun_config['o_topic_views'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[topic_views]" value="0"<?php if ($pun_config['o_topic_views'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[topic_views]" id="form_topic_views_1" value="1"<?php if ($pun_config['o_topic_views'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_topic_views_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[topic_views]" id="form_topic_views_0" value="0"<?php if ($pun_config['o_topic_views'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_topic_views_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Topic views help'] ?></span>
</td>
</tr>
<tr>
<th scope="row"><?php echo $lang_admin_options['Quick jump label'] ?></th>
<td>
- <input type="radio" name="form[quickjump]" value="1"<?php if ($pun_config['o_quickjump'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[quickjump]" value="0"<?php if ($pun_config['o_quickjump'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[quickjump]" id="form_quickjump_1" value="1"<?php if ($pun_config['o_quickjump'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_quickjump_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[quickjump]" id="form_quickjump_0" value="0"<?php if ($pun_config['o_quickjump'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_quickjump_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Quick jump help'] ?></span>
</td>
</tr>
<tr>
<th scope="row"><?php echo $lang_admin_options['GZip label'] ?></th>
<td>
- <input type="radio" name="form[gzip]" value="1"<?php if ($pun_config['o_gzip'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[gzip]" value="0"<?php if ($pun_config['o_gzip'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[gzip]" id="form_gzip_1" value="1"<?php if ($pun_config['o_gzip'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_gzip_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[gzip]" id="form_gzip_0" value="0"<?php if ($pun_config['o_gzip'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_gzip_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['GZip help'] ?></span>
</td>
</tr>
<tr>
<th scope="row"><?php echo $lang_admin_options['Search all label'] ?></th>
<td>
- <input type="radio" name="form[search_all_forums]" value="1"<?php if ($pun_config['o_search_all_forums'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[search_all_forums]" value="0"<?php if ($pun_config['o_search_all_forums'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[search_all_forums]" id="form_search_all_forums_1" value="1"<?php if ($pun_config['o_search_all_forums'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_search_all_forums_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[search_all_forums]" id="form_search_all_forums_0" value="0"<?php if ($pun_config['o_search_all_forums'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_search_all_forums_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Search all help'] ?></span>
</td>
</tr>
@@ -583,7 +583,7 @@ generate_admin_menu('options');
<tr>
<th scope="row"><?php echo $lang_admin_options['Default feed label'] ?></th>
<td>
- <input type="radio" name="form[feed_type]" value="0"<?php if ($pun_config['o_feed_type'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_options['None'] ?></strong> <input type="radio" name="form[feed_type]" value="1"<?php if ($pun_config['o_feed_type'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_options['RSS'] ?></strong> <input type="radio" name="form[feed_type]" value="2"<?php if ($pun_config['o_feed_type'] == '2') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_options['Atom'] ?></strong>
+ <input type="radio" name="form[feed_type]" id="form_feed_type_0" value="0"<?php if ($pun_config['o_feed_type'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_options['None'] ?></strong> <input type="radio" name="form[feed_type]" id="form_feed_type_1" value="1"<?php if ($pun_config['o_feed_type'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_feed_type_0"><strong><?php echo $lang_admin_options['RSS'] ?></strong></label> <input type="radio" name="form[feed_type]" id="form_feed_type_2" value="2"<?php if ($pun_config['o_feed_type'] == '2') echo ' checked="checked"' ?> /> <label class="conl" for="form_feed_type_1"><strong><?php echo $lang_admin_options['Atom'] ?></strong></label>
<span><?php echo $lang_admin_options['Default feed help'] ?></span>
</td>
</tr>
@@ -616,7 +616,7 @@ generate_admin_menu('options');
<tr>
<th scope="row"><?php echo $lang_admin_options['Reporting method label'] ?></th>
<td>
- <input type="radio" name="form[report_method]" value="0"<?php if ($pun_config['o_report_method'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_options['Internal'] ?></strong> <input type="radio" name="form[report_method]" value="1"<?php if ($pun_config['o_report_method'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_options['By e-mail'] ?></strong> <input type="radio" name="form[report_method]" value="2"<?php if ($pun_config['o_report_method'] == '2') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_options['Both'] ?></strong>
+ <input type="radio" name="form[report_method]" id="form_report_method_0" value="0"<?php if ($pun_config['o_report_method'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_options['Internal'] ?></strong> <input type="radio" name="form[report_method]" id="form_report_method_1" value="1"<?php if ($pun_config['o_report_method'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_report_method_0"><strong><?php echo $lang_admin_options['By e-mail'] ?></strong></label> <input type="radio" name="form[report_method]" id="form_report_method_2" value="2"<?php if ($pun_config['o_report_method'] == '2') echo ' checked="checked"' ?> /> <label class="conl" for="form_report_method_1"><strong><?php echo $lang_admin_options['Both'] ?></strong></label>
<span><?php echo $lang_admin_options['Reporting method help'] ?></span>
</td>
</tr>
@@ -639,7 +639,7 @@ generate_admin_menu('options');
<tr>
<th scope="row"><?php echo $lang_admin_options['Use avatars label'] ?></th>
<td>
- <input type="radio" name="form[avatars]" value="1"<?php if ($pun_config['o_avatars'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[avatars]" value="0"<?php if ($pun_config['o_avatars'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[avatars]" id="form_avatars_1" value="1"<?php if ($pun_config['o_avatars'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_avatars_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[avatars]" id="form_avatars_0" value="0"<?php if ($pun_config['o_avatars'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_avatars_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Use avatars help'] ?></span>
</td>
</tr>
@@ -697,14 +697,14 @@ generate_admin_menu('options');
<tr>
<th scope="row"><?php echo $lang_admin_options['Forum subscriptions label'] ?></th>
<td>
- <input type="radio" name="form[forum_subscriptions]" value="1"<?php if ($pun_config['o_forum_subscriptions'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[forum_subscriptions]" value="0"<?php if ($pun_config['o_forum_subscriptions'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[forum_subscriptions]" id="form_forum_subscriptions_1" value="1"<?php if ($pun_config['o_forum_subscriptions'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_forum_subscriptions_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[forum_subscriptions]" id="form_forum_subscriptions_0" value="0"<?php if ($pun_config['o_forum_subscriptions'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_forum_subscriptions_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Forum subscriptions help'] ?></span>
</td>
</tr>
<tr>
<th scope="row"><?php echo $lang_admin_options['Topic subscriptions label'] ?></th>
<td>
- <input type="radio" name="form[topic_subscriptions]" value="1"<?php if ($pun_config['o_topic_subscriptions'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[topic_subscriptions]" value="0"<?php if ($pun_config['o_topic_subscriptions'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[topic_subscriptions]" id="form_topic_subscriptions_1" value="1"<?php if ($pun_config['o_topic_subscriptions'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_topic_subscriptions_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[topic_subscriptions]" id="form_topic_subscriptions_0" value="0"<?php if ($pun_config['o_topic_subscriptions'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_topic_subscriptions_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Topic subscriptions help'] ?></span>
</td>
</tr>
@@ -725,7 +725,7 @@ generate_admin_menu('options');
<tr>
<th scope="row"><?php echo $lang_admin_options['SMTP password label'] ?></th>
<td>
- <span><input type="checkbox" name="form[smtp_change_pass]" value="1" /> <?php echo $lang_admin_options['SMTP change password help'] ?></span>
+ <span><input type="checkbox" name="form[smtp_change_pass]" id="form_smtp_change_pass" value="1" /> <label class="conl" for="form_smtp_change_pass"><?php echo $lang_admin_options['SMTP change password help'] ?></label></span>
<?php $smtp_pass = !empty($pun_config['o_smtp_pass']) ? random_key(pun_strlen($pun_config['o_smtp_pass']), true) : ''; ?>
<input type="password" name="form[smtp_pass1]" size="25" maxlength="50" value="<?php echo $smtp_pass ?>" />
<input type="password" name="form[smtp_pass2]" size="25" maxlength="50" value="<?php echo $smtp_pass ?>" />
@@ -735,7 +735,7 @@ generate_admin_menu('options');
<tr>
<th scope="row"><?php echo $lang_admin_options['SMTP SSL label'] ?></th>
<td>
- <input type="radio" name="form[smtp_ssl]" value="1"<?php if ($pun_config['o_smtp_ssl'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[smtp_ssl]" value="0"<?php if ($pun_config['o_smtp_ssl'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[smtp_ssl]" id="form_smtp_ssl_1" value="1"<?php if ($pun_config['o_smtp_ssl'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_smtp_ssl_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[smtp_ssl]" id="form_smtp_ssl_0" value="0"<?php if ($pun_config['o_smtp_ssl'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_smtp_ssl_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['SMTP SSL help'] ?></span>
</td>
</tr>
@@ -751,28 +751,28 @@ generate_admin_menu('options');
<tr>
<th scope="row"><?php echo $lang_admin_options['Allow new label'] ?></th>
<td>
- <input type="radio" name="form[regs_allow]" value="1"<?php if ($pun_config['o_regs_allow'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[regs_allow]" value="0"<?php if ($pun_config['o_regs_allow'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[regs_allow]" id="form_regs_allow_1" value="1"<?php if ($pun_config['o_regs_allow'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_regs_allow_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[regs_allow]" id="form_regs_allow_0" value="0"<?php if ($pun_config['o_regs_allow'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_regs_allow_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Allow new help'] ?></span>
</td>
</tr>
<tr>
<th scope="row"><?php echo $lang_admin_options['Verify label'] ?></th>
<td>
- <input type="radio" name="form[regs_verify]" value="1"<?php if ($pun_config['o_regs_verify'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[regs_verify]" value="0"<?php if ($pun_config['o_regs_verify'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[regs_verify]" id="form_regs_verify_1" value="1"<?php if ($pun_config['o_regs_verify'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_regs_verify_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[regs_verify]" id="form_regs_verify_0" value="0"<?php if ($pun_config['o_regs_verify'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_regs_verify_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Verify help'] ?></span>
</td>
</tr>
<tr>
<th scope="row"><?php echo $lang_admin_options['Report new label'] ?></th>
<td>
- <input type="radio" name="form[regs_report]" value="1"<?php if ($pun_config['o_regs_report'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[regs_report]" value="0"<?php if ($pun_config['o_regs_report'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[regs_report]" id="form_regs_report_1" value="1"<?php if ($pun_config['o_regs_report'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_regs_report_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[regs_report]" id="form_regs_report_0" value="0"<?php if ($pun_config['o_regs_report'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_regs_report_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Report new help'] ?></span>
</td>
</tr>
<tr>
<th scope="row"><?php echo $lang_admin_options['Use rules label'] ?></th>
<td>
- <input type="radio" name="form[rules]" value="1"<?php if ($pun_config['o_rules'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[rules]" value="0"<?php if ($pun_config['o_rules'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[rules]" id="form_rules_1" value="1"<?php if ($pun_config['o_rules'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_rules_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[rules]" id="form_rules_0" value="0"<?php if ($pun_config['o_rules'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_rules_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Use rules help'] ?></span>
</td>
</tr>
@@ -787,9 +787,9 @@ generate_admin_menu('options');
<th scope="row"><?php echo $lang_admin_options['E-mail default label'] ?></th>
<td>
<span><?php echo $lang_admin_options['E-mail default help'] ?></span>
- <input type="radio" name="form[default_email_setting]" value="0"<?php if ($pun_config['o_default_email_setting'] == '0') echo ' checked="checked"' ?> /> <?php echo $lang_admin_options['Display e-mail label'] ?><br />
- <input type="radio" name="form[default_email_setting]" value="1"<?php if ($pun_config['o_default_email_setting'] == '1') echo ' checked="checked"' ?> /> <?php echo $lang_admin_options['Hide allow form label'] ?><br />
- <input type="radio" name="form[default_email_setting]" value="2"<?php if ($pun_config['o_default_email_setting'] == '2') echo ' checked="checked"' ?> /> <?php echo $lang_admin_options['Hide both label'] ?><br />
+ <input type="radio" name="form[default_email_setting]" id="form_default_email_setting_0" value="0"<?php if ($pun_config['o_default_email_setting'] == '0') echo ' checked="checked"' ?> /> <?php echo $lang_admin_options['Display e-mail label'] ?><br />
+ <input type="radio" name="form[default_email_setting]" id="form_default_email_setting_1" value="1"<?php if ($pun_config['o_default_email_setting'] == '1') echo ' checked="checked"' ?> /> <?php echo $lang_admin_options['Hide allow form label'] ?><br />
+ <input type="radio" name="form[default_email_setting]" id="form_default_email_setting_2" value="2"<?php if ($pun_config['o_default_email_setting'] == '2') echo ' checked="checked"' ?> /> <?php echo $lang_admin_options['Hide both label'] ?><br />
</td>
</tr>
</table>
@@ -804,7 +804,7 @@ generate_admin_menu('options');
<tr>
<th scope="row"><?php echo $lang_admin_options['Display announcement label'] ?></th>
<td>
- <input type="radio" name="form[announcement]" value="1"<?php if ($pun_config['o_announcement'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[announcement]" value="0"<?php if ($pun_config['o_announcement'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[announcement]" id="form_announcement_1" value="1"<?php if ($pun_config['o_announcement'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_announcement_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[announcement]" id="form_announcement_0" value="0"<?php if ($pun_config['o_announcement'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_announcement_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Display announcement help'] ?></span>
</td>
</tr>
@@ -825,9 +825,9 @@ generate_admin_menu('options');
<div class="infldset">
<table class="aligntop" cellspacing="0">
<tr>
- <th scope="row"><a name="maintenance"><?php echo $lang_admin_options['Maintenance mode label'] ?></a></th>
+ <th scope="row"><a name="maintenance"></a><?php echo $lang_admin_options['Maintenance mode label'] ?></th>
<td>
- <input type="radio" name="form[maintenance]" value="1"<?php if ($pun_config['o_maintenance'] == '1') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['Yes'] ?></strong> <input type="radio" name="form[maintenance]" value="0"<?php if ($pun_config['o_maintenance'] == '0') echo ' checked="checked"' ?> /> <strong><?php echo $lang_admin_common['No'] ?></strong>
+ <input type="radio" name="form[maintenance]" id="form_maintenance_1" value="1"<?php if ($pun_config['o_maintenance'] == '1') echo ' checked="checked"' ?> /> <label class="conl" for="form_maintenance_1"><strong><?php echo $lang_admin_common['Yes'] ?></strong></label> <input type="radio" name="form[maintenance]" id="form_maintenance_0" value="0"<?php if ($pun_config['o_maintenance'] == '0') echo ' checked="checked"' ?> /> <label class="conl" for="form_maintenance_0"><strong><?php echo $lang_admin_common['No'] ?></strong></label>
<span><?php echo $lang_admin_options['Maintenance mode help'] ?></span>
</td>
</tr>
diff --git a/admin_permissions.php b/admin_permissions.php
index 6abf977..a239979 100644
--- a/admin_permissions.php
+++ b/admin_permissions.php
@@ -15,7 +15,7 @@ require PUN_ROOT.'include/common_admin.php';
if ($pun_user['g_id'] != PUN_ADMIN)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the admin_permissions.php language file
require PUN_ROOT.'lang/'.$admin_language.'/admin_permissions.php';
@@ -28,6 +28,10 @@ if (isset($_POST['form_sent']))
foreach ($form as $key => $input)
{
+ // Make sure the input is never a negative value
+ if($input < 0)
+ $input = 0;
+
// Only update values that have changed
if (array_key_exists('p_'.$key, $pun_config) && $pun_config['p_'.$key] != $input)
$db->query('UPDATE '.$db->prefix.'config SET conf_value='.$input.' WHERE conf_name=\'p_'.$db->escape($key).'\'') or error('Unable to update board config', __FILE__, __LINE__, $db->error());
diff --git a/admin_ranks.php b/admin_ranks.php
index 37e7e18..e054915 100644
--- a/admin_ranks.php
+++ b/admin_ranks.php
@@ -15,7 +15,7 @@ require PUN_ROOT.'include/common_admin.php';
if ($pun_user['g_id'] != PUN_ADMIN)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the admin_ranks.php language file
require PUN_ROOT.'lang/'.$admin_language.'/admin_ranks.php';
@@ -26,7 +26,7 @@ if (isset($_POST['add_rank']))
confirm_referrer('admin_ranks.php');
$rank = pun_trim($_POST['new_rank']);
- $min_posts = trim($_POST['new_min_posts']);
+ $min_posts = pun_trim($_POST['new_min_posts']);
if ($rank == '')
message($lang_admin_ranks['Must enter title message']);
@@ -59,7 +59,7 @@ else if (isset($_POST['update']))
$id = intval(key($_POST['update']));
$rank = pun_trim($_POST['rank'][$id]);
- $min_posts = trim($_POST['min_posts'][$id]);
+ $min_posts = pun_trim($_POST['min_posts'][$id]);
if ($rank == '')
message($lang_admin_ranks['Must enter title message']);
diff --git a/admin_reports.php b/admin_reports.php
index 58aa976..f2ce80d 100644
--- a/admin_reports.php
+++ b/admin_reports.php
@@ -15,7 +15,7 @@ require PUN_ROOT.'include/common_admin.php';
if (!$pun_user['is_admmod'])
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the admin_reports.php language file
require PUN_ROOT.'lang/'.$admin_language.'/admin_reports.php';
diff --git a/admin_users.php b/admin_users.php
index 063b0b8..a016871 100644
--- a/admin_users.php
+++ b/admin_users.php
@@ -15,7 +15,7 @@ require PUN_ROOT.'include/common_admin.php';
if (!$pun_user['is_admmod'])
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the admin_users.php language file
require PUN_ROOT.'lang/'.$admin_language.'/admin_users.php';
@@ -123,7 +123,7 @@ if (isset($_GET['ip_stats']))
if (isset($_GET['show_users']))
{
- $ip = trim($_GET['show_users']);
+ $ip = pun_trim($_GET['show_users']);
if (!@preg_match('%^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$%', $ip) && !@preg_match('%^((([0-9A-Fa-f]{1,4}:){7}[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){6}:[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){5}:([0-9A-Fa-f]{1,4}:)?[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){4}:([0-9A-Fa-f]{1,4}:){0,2}[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){3}:([0-9A-Fa-f]{1,4}:){0,3}[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){2}:([0-9A-Fa-f]{1,4}:){0,4}[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){6}((\b((25[0-5])|(1\d{2})|(2[0-4]\d)|(\d{1,2}))\b)\.){3}(\b((25[0-5])|(1\d{2})|(2[0-4]\d)|(\d{1,2}))\b))|(([0-9A-Fa-f]{1,4}:){0,5}:((\b((25[0-5])|(1\d{2})|(2[0-4]\d)|(\d{1,2}))\b)\.){3}(\b((25[0-5])|(1\d{2})|(2[0-4]\d)|(\d{1,2}))\b))|(::([0-9A-Fa-f]{1,4}:){0,5}((\b((25[0-5])|(1\d{2})|(2[0-4]\d)|(\d{1,2}))\b)\.){3}(\b((25[0-5])|(1\d{2})|(2[0-4]\d)|(\d{1,2}))\b))|([0-9A-Fa-f]{1,4}::([0-9A-Fa-f]{1,4}:){0,5}[0-9A-Fa-f]{1,4})|(::([0-9A-Fa-f]{1,4}:){0,6}[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){1,7}:))$%', $ip))
message($lang_admin_users['Bad IP message']);
@@ -257,7 +257,7 @@ if (isset($_GET['show_users']))
else if (isset($_POST['move_users']) || isset($_POST['move_users_comply']))
{
if ($pun_user['g_id'] > PUN_ADMIN)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
confirm_referrer('admin_users.php');
@@ -383,7 +383,7 @@ else if (isset($_POST['move_users']) || isset($_POST['move_users_comply']))
else if (isset($_POST['delete_users']) || isset($_POST['delete_users_comply']))
{
if ($pun_user['g_id'] > PUN_ADMIN)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
confirm_referrer('admin_users.php');
@@ -532,7 +532,7 @@ else if (isset($_POST['delete_users']) || isset($_POST['delete_users_comply']))
else if (isset($_POST['ban_users']) || isset($_POST['ban_users_comply']))
{
if ($pun_user['g_id'] != PUN_ADMIN && ($pun_user['g_moderator'] != '1' || $pun_user['g_mod_ban_users'] == '0'))
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
confirm_referrer('admin_users.php');
@@ -680,14 +680,14 @@ else if (isset($_GET['find_user']))
$form = array_map('pun_trim', $form);
$conditions = $query_str = array();
- $posts_greater = isset($_GET['posts_greater']) ? trim($_GET['posts_greater']) : '';
- $posts_less = isset($_GET['posts_less']) ? trim($_GET['posts_less']) : '';
- $last_post_after = isset($_GET['last_post_after']) ? trim($_GET['last_post_after']) : '';
- $last_post_before = isset($_GET['last_post_before']) ? trim($_GET['last_post_before']) : '';
- $last_visit_after = isset($_GET['last_visit_after']) ? trim($_GET['last_visit_after']) : '';
- $last_visit_before = isset($_GET['last_visit_before']) ? trim($_GET['last_visit_before']) : '';
- $registered_after = isset($_GET['registered_after']) ? trim($_GET['registered_after']) : '';
- $registered_before = isset($_GET['registered_before']) ? trim($_GET['registered_before']) : '';
+ $posts_greater = isset($_GET['posts_greater']) ? pun_trim($_GET['posts_greater']) : '';
+ $posts_less = isset($_GET['posts_less']) ? pun_trim($_GET['posts_less']) : '';
+ $last_post_after = isset($_GET['last_post_after']) ? pun_trim($_GET['last_post_after']) : '';
+ $last_post_before = isset($_GET['last_post_before']) ? pun_trim($_GET['last_post_before']) : '';
+ $last_visit_after = isset($_GET['last_visit_after']) ? pun_trim($_GET['last_visit_after']) : '';
+ $last_visit_before = isset($_GET['last_visit_before']) ? pun_trim($_GET['last_visit_before']) : '';
+ $registered_after = isset($_GET['registered_after']) ? pun_trim($_GET['registered_after']) : '';
+ $registered_before = isset($_GET['registered_before']) ? pun_trim($_GET['registered_before']) : '';
$order_by = isset($_GET['order_by']) && in_array($_GET['order_by'], array('username', 'email', 'num_posts', 'last_post', 'last_visit', 'registered')) ? $_GET['order_by'] : 'username';
$direction = isset($_GET['direction']) && $_GET['direction'] == 'DESC' ? 'DESC' : 'ASC';
$user_group = isset($_GET['user_group']) ? intval($_GET['user_group']) : -1;
diff --git a/db_update.php b/db_update.php
index 7706230..51f4ff9 100644
--- a/db_update.php
+++ b/db_update.php
@@ -7,7 +7,7 @@
*/
// The FluxBB version this script updates to
-define('UPDATE_TO', '1.4.8');
+define('UPDATE_TO', '1.4.9');
define('UPDATE_TO_DB_REVISION', 15);
define('UPDATE_TO_SI_REVISION', 2);
@@ -254,7 +254,7 @@ function dcr2utf8($src)
//
function convert_to_utf8(&$str, $old_charset)
{
- if ($str === null || $str == '')
+ if (is_null($str) || $str == '')
return false;
$save = $str;
@@ -331,7 +331,7 @@ function alter_table_utf8($table)
$result = $db->query('SHOW FULL COLUMNS FROM '.$table) or error('Unable to fetch column information', __FILE__, __LINE__, $db->error());
while ($cur_column = $db->fetch_assoc($result))
{
- if ($cur_column['Collation'] === null)
+ if (is_null($cur_column['Collation']))
continue;
list($type) = explode('(', $cur_column['Type']);
@@ -359,7 +359,7 @@ function convert_table_utf8($table, $callback, $old_charset, $key = null, $start
if ($mysql)
{
// Only set up the tables if we are doing this in 1 go, or its the first go
- if ($start_at === null || $start_at == 0)
+ if (is_null($start_at) || $start_at == 0)
{
// Drop any temp table that exists, in-case it's left over from a failed update
$db->drop_table($table.'_utf8', true) or error('Unable to drop left over temp table', __FILE__, __LINE__, $db->error());
@@ -375,7 +375,7 @@ function convert_table_utf8($table, $callback, $old_charset, $key = null, $start
$db->set_names($old_connection_charset);
// Move & Convert everything
- $result = $db->query('SELECT * FROM '.$table.($start_at === null ? '' : ' WHERE '.$key.'>'.$start_at).' ORDER BY '.$key.' ASC'.($start_at === null ? '' : ' LIMIT '.PER_PAGE), false) or error('Unable to select from old table', __FILE__, __LINE__, $db->error());
+ $result = $db->query('SELECT * FROM '.$table.(is_null($start_at) ? '' : ' WHERE '.$key.'>'.$start_at).' ORDER BY '.$key.' ASC'.(is_null($start_at) ? '' : ' LIMIT '.PER_PAGE), false) or error('Unable to select from old table', __FILE__, __LINE__, $db->error());
// Change back to utf8 mode so we can insert it into the new table
$db->set_names('utf8');
@@ -386,15 +386,15 @@ function convert_table_utf8($table, $callback, $old_charset, $key = null, $start
$temp = array();
foreach ($cur_item as $idx => $value)
- $temp[$idx] = $value === null ? 'NULL' : '\''.$db->escape($value).'\'';
+ $temp[$idx] = is_null($value) ? 'NULL' : '\''.$db->escape($value).'\'';
- $db->query('INSERT INTO '.$table.'_utf8('.implode(',', array_keys($temp)).') VALUES ('.implode(',', array_values($temp)).')') or ($error_callback === null ? error('Unable to insert data to new table', __FILE__, __LINE__, $db->error()) : call_user_func($error_callback, $cur_item));
+ $db->query('INSERT INTO '.$table.'_utf8('.implode(',', array_keys($temp)).') VALUES ('.implode(',', array_values($temp)).')') or (is_null($error_callback) ? error('Unable to insert data to new table', __FILE__, __LINE__, $db->error()) : call_user_func($error_callback, $cur_item));
$end_at = $cur_item[$key];
}
// If we aren't doing this all in 1 go and $end_at has a value (i.e. we have processed at least 1 row), figure out if we have more to do or not
- if ($start_at !== null && $end_at > 0)
+ if (!is_null($start_at) && $end_at > 0)
{
$result = $db->query('SELECT 1 FROM '.$table.' WHERE '.$key.'>'.$end_at.' ORDER BY '.$key.' ASC LIMIT 1') or error('Unable to check for next row', __FILE__, __LINE__, $db->error());
$finished = $db->num_rows($result) == 0;
@@ -417,14 +417,14 @@ function convert_table_utf8($table, $callback, $old_charset, $key = null, $start
else
{
// Convert everything
- $result = $db->query('SELECT * FROM '.$table.($start_at === null ? '' : ' WHERE '.$key.'>'.$start_at).' ORDER BY '.$key.' ASC'.($start_at === null ? '' : ' LIMIT '.PER_PAGE)) or error('Unable to select from table', __FILE__, __LINE__, $db->error());
+ $result = $db->query('SELECT * FROM '.$table.(is_null($start_at) ? '' : ' WHERE '.$key.'>'.$start_at).' ORDER BY '.$key.' ASC'.(is_null($start_at ) ? '' : ' LIMIT '.PER_PAGE)) or error('Unable to select from table', __FILE__, __LINE__, $db->error());
while ($cur_item = $db->fetch_assoc($result))
{
$cur_item = call_user_func($callback, $cur_item, $old_charset);
$temp = array();
foreach ($cur_item as $idx => $value)
- $temp[] = $idx.'='.($value === null ? 'NULL' : '\''.$db->escape($value).'\'');
+ $temp[] = $idx.'='.(is_null($value) ? 'NULL' : '\''.$db->escape($value).'\'');
if (!empty($temp))
$db->query('UPDATE '.$table.' SET '.implode(', ', $temp).' WHERE '.$key.'=\''.$db->escape($cur_item[$key]).'\'') or error('Unable to update data', __FILE__, __LINE__, $db->error());
@@ -432,7 +432,7 @@ function convert_table_utf8($table, $callback, $old_charset, $key = null, $start
$end_at = $cur_item[$key];
}
- if ($start_at !== null && $end_at > 0)
+ if (!is_null($start_at) && $end_at > 0)
{
$result = $db->query('SELECT 1 FROM '.$table.' WHERE '.$key.'>'.$end_at.' ORDER BY '.$key.' ASC LIMIT 1') or error('Unable to check for next row', __FILE__, __LINE__, $db->error());
if ($db->num_rows($result) == 0)
@@ -621,7 +621,7 @@ $lock_error = false;
// Generate or fetch the UID - this confirms we have a valid admin
if (isset($_POST['req_db_pass']))
{
- $req_db_pass = strtolower(trim($_POST['req_db_pass']));
+ $req_db_pass = strtolower(pun_trim($_POST['req_db_pass']));
switch ($db_type)
{
@@ -674,7 +674,7 @@ if (isset($_POST['req_db_pass']))
}
else if (isset($_GET['uid']))
{
- $uid = trim($_GET['uid']);
+ $uid = pun_trim($_GET['uid']);
if (!$lock || $lock != $uid) // The lock doesn't exist or doesn't match the given UID
$lock_error = true;
}
@@ -1557,7 +1557,7 @@ switch ($stage)
$temp = array();
foreach ($cur_user as $idx => $value)
- $temp[$idx] = $value === null ? 'NULL' : '\''.$db->escape($value).'\'';
+ $temp[$idx] = is_null($value) ? 'NULL' : '\''.$db->escape($value).'\'';
// Insert the renamed user
$db->query('INSERT INTO '.$db->prefix.'users('.implode(',', array_keys($temp)).') VALUES ('.implode(',', array_values($temp)).')') or error('Unable to insert data to new table', __FILE__, __LINE__, $db->error());
diff --git a/delete.php b/delete.php
index ba92f19..f022f53 100644
--- a/delete.php
+++ b/delete.php
@@ -11,17 +11,17 @@ require PUN_ROOT.'include/common.php';
if ($pun_user['g_read_board'] == '0')
- message($lang_common['No view']);
+ message($lang_common['No view'], false, '403 Forbidden');
$id = isset($_GET['id']) ? intval($_GET['id']) : 0;
if ($id < 1)
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
// Fetch some info about the post, the topic and the forum
$result = $db->query('SELECT f.id AS fid, f.forum_name, f.moderators, f.redirect_url, fp.post_replies, fp.post_topics, t.id AS tid, t.subject, t.first_post_id, t.closed, p.posted, p.poster, p.poster_id, p.message, p.hide_smilies FROM '.$db->prefix.'posts AS p INNER JOIN '.$db->prefix.'topics AS t ON t.id=p.topic_id INNER JOIN '.$db->prefix.'forums AS f ON f.id=t.forum_id LEFT JOIN '.$db->prefix.'forum_perms AS fp ON (fp.forum_id=f.id AND fp.group_id='.$pun_user['g_id'].') WHERE (fp.read_forum IS NULL OR fp.read_forum=1) AND p.id='.$id) or error('Unable to fetch post info', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
$cur_post = $db->fetch_assoc($result);
@@ -40,7 +40,7 @@ if (($pun_user['g_delete_posts'] == '0' ||
$cur_post['poster_id'] != $pun_user['id'] ||
$cur_post['closed'] == '1') &&
!$is_admmod)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the delete.php language file
require PUN_ROOT.'lang/'.$pun_user['language'].'/delete.php';
diff --git a/edit.php b/edit.php
index 58f8be3..f9b036b 100644
--- a/edit.php
+++ b/edit.php
@@ -11,17 +11,17 @@ require PUN_ROOT.'include/common.php';
if ($pun_user['g_read_board'] == '0')
- message($lang_common['No view']);
+ message($lang_common['No view'], false, '403 Forbidden');
$id = isset($_GET['id']) ? intval($_GET['id']) : 0;
if ($id < 1)
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
// Fetch some info about the post, the topic and the forum
$result = $db->query('SELECT f.id AS fid, f.forum_name, f.moderators, f.redirect_url, fp.post_replies, fp.post_topics, t.id AS tid, t.subject, t.posted, t.first_post_id, t.sticky, t.closed, p.poster, p.poster_id, p.message, p.hide_smilies FROM '.$db->prefix.'posts AS p INNER JOIN '.$db->prefix.'topics AS t ON t.id=p.topic_id INNER JOIN '.$db->prefix.'forums AS f ON f.id=t.forum_id LEFT JOIN '.$db->prefix.'forum_perms AS fp ON (fp.forum_id=f.id AND fp.group_id='.$pun_user['g_id'].') WHERE (fp.read_forum IS NULL OR fp.read_forum=1) AND p.id='.$id) or error('Unable to fetch post info', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
$cur_post = $db->fetch_assoc($result);
@@ -42,7 +42,7 @@ if (($pun_user['g_edit_posts'] == '0' ||
$cur_post['poster_id'] != $pun_user['id'] ||
$cur_post['closed'] == '1') &&
!$is_admmod)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the post.php/edit.php language file
require PUN_ROOT.'lang/'.$pun_user['language'].'/post.php';
diff --git a/help.php b/help.php
index 39e5d07..caa7c23 100644
--- a/help.php
+++ b/help.php
@@ -14,7 +14,7 @@ require PUN_ROOT.'include/common.php';
if ($pun_user['g_read_board'] == '0')
- message($lang_common['No view']);
+ message($lang_common['No view'], false, '403 Forbidden');
// Load the help.php language file
diff --git a/include/common.php b/include/common.php
index 6b9319e..92cef00 100644
--- a/include/common.php
+++ b/include/common.php
@@ -10,7 +10,7 @@ if (!defined('PUN_ROOT'))
exit('The constant PUN_ROOT must be defined and point to a valid FluxBB installation root directory.');
// Define the version and database revision that this code was written for
-define('FORUM_VERSION', '1.4.8');
+define('FORUM_VERSION', '1.4.9');
define('FORUM_DB_REVISION', 15);
define('FORUM_SI_REVISION', 2);
diff --git a/include/dblayer/mysql.php b/include/dblayer/mysql.php
index 6f0e3af..256125e 100644
--- a/include/dblayer/mysql.php
+++ b/include/dblayer/mysql.php
@@ -318,10 +318,10 @@ class DBLayer
$field_type = preg_replace(array_keys($this->datatype_transformations), array_values($this->datatype_transformations), $field_type);
- if ($default_value !== null && !is_int($default_value) && !is_float($default_value))
+ if (!is_null($default_value) && !is_int($default_value) && !is_float($default_value))
$default_value = '\''.$this->escape($default_value).'\'';
- return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' ADD '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').($default_value !== null ? ' DEFAULT '.$default_value : ' ').($after_field != null ? ' AFTER '.$after_field : '')) ? true : false;
+ return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' ADD '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').(!is_null($default_value) ? ' DEFAULT '.$default_value : ' ').(!is_null($after_field) ? ' AFTER '.$after_field : '')) ? true : false;
}
@@ -332,10 +332,10 @@ class DBLayer
$field_type = preg_replace(array_keys($this->datatype_transformations), array_values($this->datatype_transformations), $field_type);
- if ($default_value !== null && !is_int($default_value) && !is_float($default_value))
+ if (!is_null($default_value) && !is_int($default_value) && !is_float($default_value))
$default_value = '\''.$this->escape($default_value).'\'';
- return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' MODIFY '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').($default_value !== null ? ' DEFAULT '.$default_value : ' ').($after_field != null ? ' AFTER '.$after_field : '')) ? true : false;
+ return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' MODIFY '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').(!is_null($default_value) ? ' DEFAULT '.$default_value : ' ').(!is_null($after_field) ? ' AFTER '.$after_field : '')) ? true : false;
}
diff --git a/include/dblayer/mysql_innodb.php b/include/dblayer/mysql_innodb.php
index 2b14ab2..01ca724 100644
--- a/include/dblayer/mysql_innodb.php
+++ b/include/dblayer/mysql_innodb.php
@@ -332,10 +332,10 @@ class DBLayer
$field_type = preg_replace(array_keys($this->datatype_transformations), array_values($this->datatype_transformations), $field_type);
- if ($default_value !== null && !is_int($default_value) && !is_float($default_value))
+ if (!is_null($default_value) && !is_int($default_value) && !is_float($default_value))
$default_value = '\''.$this->escape($default_value).'\'';
- return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' ADD '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').($default_value !== null ? ' DEFAULT '.$default_value : ' ').($after_field != null ? ' AFTER '.$after_field : '')) ? true : false;
+ return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' ADD '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').(!is_null($default_value) ? ' DEFAULT '.$default_value : ' ').(!is_null($after_field) ? ' AFTER '.$after_field : '')) ? true : false;
}
@@ -346,10 +346,10 @@ class DBLayer
$field_type = preg_replace(array_keys($this->datatype_transformations), array_values($this->datatype_transformations), $field_type);
- if ($default_value !== null && !is_int($default_value) && !is_float($default_value))
+ if (!is_null($default_value) && !is_int($default_value) && !is_float($default_value))
$default_value = '\''.$this->escape($default_value).'\'';
- return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' MODIFY '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').($default_value !== null ? ' DEFAULT '.$default_value : ' ').($after_field != null ? ' AFTER '.$after_field : '')) ? true : false;
+ return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' MODIFY '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').(!is_null($default_value) ? ' DEFAULT '.$default_value : ' ').(!is_null($after_field) ? ' AFTER '.$after_field : '')) ? true : false;
}
diff --git a/include/dblayer/mysqli.php b/include/dblayer/mysqli.php
index 9da4cf1..8b2675b 100644
--- a/include/dblayer/mysqli.php
+++ b/include/dblayer/mysqli.php
@@ -325,10 +325,10 @@ class DBLayer
$field_type = preg_replace(array_keys($this->datatype_transformations), array_values($this->datatype_transformations), $field_type);
- if ($default_value !== null && !is_int($default_value) && !is_float($default_value))
+ if (!is_null($default_value) && !is_int($default_value) && !is_float($default_value))
$default_value = '\''.$this->escape($default_value).'\'';
- return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' ADD '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').($default_value !== null ? ' DEFAULT '.$default_value : ' ').($after_field != null ? ' AFTER '.$after_field : '')) ? true : false;
+ return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' ADD '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').(!is_null($default_value) ? ' DEFAULT '.$default_value : ' ').(!is_null($after_field) ? ' AFTER '.$after_field : '')) ? true : false;
}
@@ -339,10 +339,10 @@ class DBLayer
$field_type = preg_replace(array_keys($this->datatype_transformations), array_values($this->datatype_transformations), $field_type);
- if ($default_value !== null && !is_int($default_value) && !is_float($default_value))
+ if (!is_null($default_value) && !is_int($default_value) && !is_float($default_value))
$default_value = '\''.$this->escape($default_value).'\'';
- return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' MODIFY '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').($default_value !== null ? ' DEFAULT '.$default_value : ' ').($after_field != null ? ' AFTER '.$after_field : '')) ? true : false;
+ return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' MODIFY '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').(!is_null($default_value) ? ' DEFAULT '.$default_value : ' ').(!is_null($after_field) ? ' AFTER '.$after_field : '')) ? true : false;
}
diff --git a/include/dblayer/mysqli_innodb.php b/include/dblayer/mysqli_innodb.php
index 1538c71..3a07431 100644
--- a/include/dblayer/mysqli_innodb.php
+++ b/include/dblayer/mysqli_innodb.php
@@ -338,10 +338,10 @@ class DBLayer
$field_type = preg_replace(array_keys($this->datatype_transformations), array_values($this->datatype_transformations), $field_type);
- if ($default_value !== null && !is_int($default_value) && !is_float($default_value))
+ if (!is_null($default_value) && !is_int($default_value) && !is_float($default_value))
$default_value = '\''.$this->escape($default_value).'\'';
- return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' ADD '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').($default_value !== null ? ' DEFAULT '.$default_value : ' ').($after_field != null ? ' AFTER '.$after_field : '')) ? true : false;
+ return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' ADD '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').(!is_null($default_value) ? ' DEFAULT '.$default_value : ' ').(!is_null($after_field) ? ' AFTER '.$after_field : '')) ? true : false;
}
@@ -352,10 +352,10 @@ class DBLayer
$field_type = preg_replace(array_keys($this->datatype_transformations), array_values($this->datatype_transformations), $field_type);
- if ($default_value !== null && !is_int($default_value) && !is_float($default_value))
+ if (!is_null($default_value) && !is_int($default_value) && !is_float($default_value))
$default_value = '\''.$this->escape($default_value).'\'';
- return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' MODIFY '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').($default_value !== null ? ' DEFAULT '.$default_value : ' ').($after_field != null ? ' AFTER '.$after_field : '')) ? true : false;
+ return $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' MODIFY '.$field_name.' '.$field_type.($allow_null ? ' ' : ' NOT NULL').(!is_null($default_value) ? ' DEFAULT '.$default_value : ' ').(!is_null($after_field) ? ' AFTER '.$after_field : '')) ? true : false;
}
diff --git a/include/dblayer/pgsql.php b/include/dblayer/pgsql.php
index 577b5a0..3a73118 100644
--- a/include/dblayer/pgsql.php
+++ b/include/dblayer/pgsql.php
@@ -371,7 +371,7 @@ class DBLayer
$result = $this->query('ALTER TABLE '.($no_prefix ? '' : $this->prefix).$table_name.' ADD '.$field_name.' '.$field_type) ? true : false;
- if ($default_value !== null)
+ if (!is_null($default_value))
{
if (!is_int($default_value) && !is_float($default_value))
$default_value = '\''.$this->escape($default_value).'\'';
diff --git a/include/dblayer/sqlite.php b/include/dblayer/sqlite.php
index f634d5e..e83ec70 100644
--- a/include/dblayer/sqlite.php
+++ b/include/dblayer/sqlite.php
@@ -438,7 +438,7 @@ class DBLayer
$query = $field_type;
if (!$allow_null)
$query .= ' NOT NULL';
- if ($default_value === null || $default_value === '')
+ if (is_null($default_value) || $default_value === '')
$default_value = '\'\'';
$query .= ' DEFAULT '.$default_value;
diff --git a/include/functions.php b/include/functions.php
index e430b29..855eb9f 100644
--- a/include/functions.php
+++ b/include/functions.php
@@ -589,7 +589,7 @@ function generate_page_title($page_title, $p = null)
$page_title = array_reverse($page_title);
- if ($p != null)
+ if (!is_null($p))
$page_title[0] .= ' ('.sprintf($lang_common['Page'], forum_number_format($p)).')';
$crumbs = implode($lang_common['Title separator'], $page_title);
@@ -642,7 +642,7 @@ function get_tracked_topics()
if (!$cookie_data)
return array('topics' => array(), 'forums' => array());
- if (strlen($cookie_data) > 4048)
+ if (strlen($cookie_data) > FORUM_MAX_COOKIE_SIZE)
return array('topics' => array(), 'forums' => array());
// Unserialize data from cookie
@@ -905,7 +905,7 @@ function paginate($num_pages, $cur_page, $link)
{
// Add a previous page link
if ($num_pages > 1 && $cur_page > 1)
- $pages[] = '<a'.(empty($pages) ? ' class="item1"' : '').' href="'.$link.'&p='.($cur_page - 1).'">'.$lang_common['Previous'].'</a>';
+ $pages[] = '<a rel="prev" '.(empty($pages) ? ' class="item1"' : '').' href="'.$link.'&p='.($cur_page - 1).'">'.$lang_common['Previous'].'</a>';
if ($cur_page > 3)
{
@@ -936,7 +936,7 @@ function paginate($num_pages, $cur_page, $link)
// Add a next page link
if ($num_pages > 1 && !$link_to_all && $cur_page < $num_pages)
- $pages[] = '<a'.(empty($pages) ? ' class="item1"' : '').' href="'.$link.'&p='.($cur_page +1).'">'.$lang_common['Next'].'</a>';
+ $pages[] = '<a rel="next" '.(empty($pages) ? ' class="item1"' : '').' href="'.$link.'&p='.($cur_page +1).'">'.$lang_common['Next'].'</a>';
}
return implode(' ', $pages);
@@ -946,10 +946,15 @@ function paginate($num_pages, $cur_page, $link)
//
// Display a message
//
-function message($message, $no_back_link = false)
+function message($message, $no_back_link = false, $http_status = null)
{
global $db, $lang_common, $pun_config, $pun_start, $tpl_main, $pun_user;
+ // Did we receive a custom header?
+ if(!is_null($http_status)) {
+ header('HTTP/1.1 ' . $http_status);
+ }
+
if (!defined('PUN_HEADER'))
{
$page_title = array(pun_htmlspecialchars($pun_config['o_board_title']), $lang_common['Info']);
@@ -988,10 +993,10 @@ function format_time($timestamp, $date_only = false, $date_format = null, $time_
$timestamp += $diff;
$now = time();
- if($date_format == null)
+ if(is_null($date_format))
$date_format = $forum_date_formats[$pun_user['date_format']];
- if($time_format == null)
+ if(is_null($time_format))
$time_format = $forum_time_formats[$pun_user['time_format']];
$date = gmdate($date_format, $timestamp);
@@ -1178,7 +1183,7 @@ function pun_linebreaks($str)
//
function pun_trim($str, $charlist = false)
{
- return utf8_trim($str, $charlist);
+ return is_string($str) ? utf8_trim($str, $charlist) : '';
}
//
@@ -1198,7 +1203,7 @@ function is_all_uppercase($string)
//
function array_insert(&$input, $offset, $element, $key = null)
{
- if ($key == null)
+ if (is_null($key))
$key = $offset;
// Determine the proper offset if we're using a string
@@ -1524,7 +1529,7 @@ H2 {MARGIN: 0; COLOR: #FFFFFF; BACKGROUND-COLOR: #B84623; FONT-SIZE: 1.1em; PADD
<div>
<?php
- if (defined('PUN_DEBUG') && $file !== null && $line !== null)
+ if (defined('PUN_DEBUG') && !is_null($file) && !is_null($line))
{
echo "\t\t".'<strong>File:</strong> '.$file.'<br />'."\n\t\t".'<strong>Line:</strong> '.$line.'<br /><br />'."\n\t\t".'<strong>FluxBB reported</strong>: '.$message."\n";
@@ -1674,7 +1679,7 @@ function file_size($size)
for ($i = 0; $size > 1024; $i++)
$size /= 1024;
- return sprintf($lang_common['Size unit '.$units[$i]], round($size, 2));;
+ return sprintf($lang_common['Size unit '.$units[$i]], round($size, 2));
}
@@ -2000,13 +2005,13 @@ function ucp_preg_replace($pattern, $replace, $subject)
//
// As MySQL cannot properly handle four-byte characters with the default utf-8
// charset up until version 5.5.3 (where a special charset has to be used), they
-// need to be replaced, by question marks in this case.
+// need to be replaced, by question marks in this case.
//
function strip_bad_multibyte_chars($str)
{
$result = '';
$length = strlen($str);
-
+
for ($i = 0; $i < $length; $i++)
{
// Replace four-byte characters (11110www 10zzzzzz 10yyyyyy 10xxxxxx)
@@ -2021,7 +2026,7 @@ function strip_bad_multibyte_chars($str)
$result .= $str[$i];
}
}
-
+
return $result;
}
diff --git a/include/parser.php b/include/parser.php
index 5bb208a..238932d 100644
--- a/include/parser.php
+++ b/include/parser.php
@@ -82,7 +82,7 @@ function preparse_bbcode($text, &$errors, $is_signature = false)
$temp = preg_replace($re_list, 'preparse_list_tag(\'$2\', \'$1\')', $text);
// If the regex failed
- if ($temp === null)
+ if (is_null($temp))
$errors[] = $lang_common['BBCode list size error'];
else
$text = str_replace('*'."\0".']', '*]', $temp);
@@ -144,7 +144,7 @@ function strip_empty_bbcode($text)
list($inside, $text) = extract_blocks($text, '[code]', '[/code]');
// Remove empty tags
- while (($new_text = preg_replace('%\[(b|u|s|ins|del|em|i|h|colou?r|quote|img|url|email|list|topic|post|forum|user)(?:\=[^\]]*)?\]\s*\[/\1\]%', '', $text)) !== NULL)
+ while (!is_null($new_text = preg_replace('%\[(b|u|s|ins|del|em|i|h|colou?r|quote|img|url|email|list|topic|post|forum|user)(?:\=[^\]]*)?\]\s*\[/\1\]%', '', $text)))
{
if ($new_text != $text)
$text = $new_text;
@@ -166,7 +166,7 @@ function strip_empty_bbcode($text)
}
// Remove empty code tags
- while (($new_text = preg_replace('%\[(code)\]\s*\[/\1\]%', '', $text)) !== NULL)
+ while (!is_null($new_text = preg_replace('%\[(code)\]\s*\[/\1\]%', '', $text)))
{
if ($new_text != $text)
$text = $new_text;
@@ -675,7 +675,7 @@ function handle_img_tag($url, $is_signature = false, $alt = null)
{
global $lang_common, $pun_user;
- if ($alt == null)
+ if (is_null($alt))
$alt = basename($url);
$img_tag = '<a href="'.$url.'"><'.$lang_common['Image link'].' - '.$alt.'></a>';
diff --git a/include/search_idx.php b/include/search_idx.php
index 0a886f4..550f348 100644
--- a/include/search_idx.php
+++ b/include/search_idx.php
@@ -47,6 +47,9 @@ define('PUN_CJK_HANGUL_REGEX', '['.
//
function split_words($text, $idx)
{
+ // Remove BBCode
+ $text = preg_replace('%\[/?(b|u|s|ins|del|em|i|h|colou?r|quote|code|img|url|email|list|topic|post|forum|user)(?:\=[^\]]*)?\]%', ' ', $text);
+
// Remove any apostrophes or dashes which aren't part of words
$text = substr(ucp_preg_replace('%((?<=[^\p{L}\p{N}])[\'\-]|[\'\-](?=[^\p{L}\p{N}]))%u', '', ' '.$text.' '), 1, -1);
@@ -144,8 +147,8 @@ function strip_bbcode($text)
$patterns = array(
'%\[img=([^\]]*+)\]([^[]*+)\[/img\]%' => '$2 $1', // Keep the url and description
'%\[(url|email)=([^\]]*+)\]([^[]*+(?:(?!\[/\1\])\[[^[]*+)*)\[/\1\]%' => '$2 $3', // Keep the url and text
+ '%\[(img|url|email)\]([^[]*+(?:(?!\[/\1\])\[[^[]*+)*)\[/\1\]%' => '$2', // Keep the url
'%\[(topic|post|forum|user)\][1-9]\d*\[/\1\]%' => ' ', // Do not index topic/post/forum/user ID
- '%\[/?(b|u|s|ins|del|em|i|h|colou?r|quote|code|img|url|email|list|topic|post|forum|user)(?:\=[^\]]*)?\]%' => ' ' // Remove BBCode
);
}
diff --git a/include/utf8/strcspn.php b/include/utf8/strcspn.php
index 1e3756d..b05e327 100644
--- a/include/utf8/strcspn.php
+++ b/include/utf8/strcspn.php
@@ -24,7 +24,7 @@ function utf8_strcspn($str, $mask, $start=null, $length=null)
$mask = preg_replace('!([\\\\\\-\\]\\[/^])!','\\\${1}', $mask);
- if ($start !== null || $length !== null)
+ if (!is_null($start) || !is_null($length))
$str = utf8_substr($str, $start, $length);
preg_match('/^[^'.$mask.']+/u', $str, $matches);
diff --git a/include/utf8/strspn.php b/include/utf8/strspn.php
index 424ceb7..49d300a 100644
--- a/include/utf8/strspn.php
+++ b/include/utf8/strspn.php
@@ -20,7 +20,7 @@ function utf8_strspn($str, $mask, $start=null, $length=null)
{
$mask = preg_replace('!([\\\\\\-\\]\\[/^])!', '\\\${1}', $mask);
- if ($start !== null || $length !== null)
+ if (!is_null($start)|| !is_null($length))
$str = utf8_substr($str, $start, $length);
preg_match('/^['.$mask.']+/u', $str, $matches);
diff --git a/include/utf8/substr_replace.php b/include/utf8/substr_replace.php
index 7fc7369..20a43b5 100644
--- a/include/utf8/substr_replace.php
+++ b/include/utf8/substr_replace.php
@@ -18,7 +18,7 @@ function utf8_substr_replace($str, $repl, $start , $length=null)
preg_match_all('/./us', $str, $ar);
preg_match_all('/./us', $repl, $rar);
- if($length === null)
+ if(is_null($length))
$length = utf8_strlen($str);
array_splice($ar[0], $start, $length, $rar[0]);
diff --git a/index.php b/index.php
index 4cfbe71..0f257ac 100644
--- a/index.php
+++ b/index.php
@@ -11,7 +11,7 @@ require PUN_ROOT.'include/common.php';
if ($pun_user['g_read_board'] == '0')
- message($lang_common['No view']);
+ message($lang_common['No view'], false, '403 Forbidden');
// Load the index.php language file
diff --git a/login.php b/login.php
index 35f8673..e916ffc 100644
--- a/login.php
+++ b/login.php
@@ -140,7 +140,7 @@ else if ($action == 'forget' || $action == 'forget_2')
require PUN_ROOT.'include/email.php';
// Validate the email address
- $email = strtolower(trim($_POST['req_email']));
+ $email = strtolower(pun_trim($_POST['req_email']));
if (!is_valid_email($email))
$errors[] = $lang_common['Invalid email'];
diff --git a/misc.php b/misc.php
index 06a661b..46d2707 100644
--- a/misc.php
+++ b/misc.php
@@ -49,7 +49,7 @@ if ($action == 'rules')
else if ($action == 'markread')
{
if ($pun_user['is_guest'])
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
$db->query('UPDATE '.$db->prefix.'users SET last_visit='.$pun_user['logged'].' WHERE id='.$pun_user['id']) or error('Unable to update user last visit data', __FILE__, __LINE__, $db->error());
@@ -64,7 +64,7 @@ else if ($action == 'markread')
else if ($action == 'markforumread')
{
if ($pun_user['is_guest'])
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
$fid = isset($_GET['fid']) ? intval($_GET['fid']) : 0;
if ($fid < 1)
@@ -81,7 +81,7 @@ else if ($action == 'markforumread')
else if (isset($_GET['email']))
{
if ($pun_user['is_guest'] || $pun_user['g_send_email'] == '0')
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
$recipient_id = intval($_GET['email']);
if ($recipient_id < 2)
@@ -145,11 +145,19 @@ else if (isset($_GET['email']))
if (strpos($referrer['host'], 'www.') === 0)
$referrer['host'] = substr($referrer['host'], 4);
+ // Make sure the path component exists
+ if (!isset($referrer['path']))
+ $referrer['path'] = '';
+
$valid = parse_url(get_base_url());
// Remove www subdomain if it exists
if (strpos($valid['host'], 'www.') === 0)
$valid['host'] = substr($valid['host'], 4);
+ // Make sure the path component exists
+ if (!isset($valid['path']))
+ $valid['path'] = '';
+
if ($referrer['host'] == $valid['host'] && preg_match('%^'.preg_quote($valid['path'], '%').'/(.*?)\.php%i', $referrer['path']))
$redirect_url = $_SERVER['HTTP_REFERER'];
}
diff --git a/moderate.php b/moderate.php
index b4dad37..4555e31 100644
--- a/moderate.php
+++ b/moderate.php
@@ -15,7 +15,7 @@ require PUN_ROOT.'include/common.php';
if (isset($_GET['get_host']))
{
if (!$pun_user['is_admmod'])
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Is get_host an IP address or a post ID?
if (@preg_match('%^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$%', $_GET['get_host']) || @preg_match('%^((([0-9A-Fa-f]{1,4}:){7}[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){6}:[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){5}:([0-9A-Fa-f]{1,4}:)?[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){4}:([0-9A-Fa-f]{1,4}:){0,2}[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){3}:([0-9A-Fa-f]{1,4}:){0,3}[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){2}:([0-9A-Fa-f]{1,4}:){0,4}[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){6}((\b((25[0-5])|(1\d{2})|(2[0-4]\d)|(\d{1,2}))\b)\.){3}(\b((25[0-5])|(1\d{2})|(2[0-4]\d)|(\d{1,2}))\b))|(([0-9A-Fa-f]{1,4}:){0,5}:((\b((25[0-5])|(1\d{2})|(2[0-4]\d)|(\d{1,2}))\b)\.){3}(\b((25[0-5])|(1\d{2})|(2[0-4]\d)|(\d{1,2}))\b))|(::([0-9A-Fa-f]{1,4}:){0,5}((\b((25[0-5])|(1\d{2})|(2[0-4]\d)|(\d{1,2}))\b)\.){3}(\b((25[0-5])|(1\d{2})|(2[0-4]\d)|(\d{1,2}))\b))|([0-9A-Fa-f]{1,4}::([0-9A-Fa-f]{1,4}:){0,5}[0-9A-Fa-f]{1,4})|(::([0-9A-Fa-f]{1,4}:){0,6}[0-9A-Fa-f]{1,4})|(([0-9A-Fa-f]{1,4}:){1,7}:))$%', $_GET['get_ho
st']))
@@ -28,7 +28,7 @@ if (isset($_GET['get_host']))
$result = $db->query('SELECT poster_ip FROM '.$db->prefix.'posts WHERE id='.$get_host) or error('Unable to fetch post IP address', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
$ip = $db->result($result);
}
@@ -43,7 +43,7 @@ if (isset($_GET['get_host']))
// All other functions require moderator/admin access
$fid = isset($_GET['fid']) ? intval($_GET['fid']) : 0;
if ($fid < 1)
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
$result = $db->query('SELECT moderators FROM '.$db->prefix.'forums WHERE id='.$fid) or error('Unable to fetch forum info', __FILE__, __LINE__, $db->error());
@@ -51,7 +51,7 @@ $moderators = $db->result($result);
$mods_array = ($moderators != '') ? unserialize($moderators) : array();
if ($pun_user['g_id'] != PUN_ADMIN && ($pun_user['g_moderator'] == '0' || !array_key_exists($pun_user['username'], $mods_array)))
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Get topic/forum tracking data
if (!$pun_user['is_guest'])
@@ -66,12 +66,12 @@ if (isset($_GET['tid']))
{
$tid = intval($_GET['tid']);
if ($tid < 1)
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
// Fetch some info about the topic
$result = $db->query('SELECT t.subject, t.num_replies, t.first_post_id, f.id AS forum_id, forum_name FROM '.$db->prefix.'topics AS t INNER JOIN '.$db->prefix.'forums AS f ON f.id=t.forum_id LEFT JOIN '.$db->prefix.'forum_perms AS fp ON (fp.forum_id=f.id AND fp.group_id='.$pun_user['g_id'].') WHERE (fp.read_forum IS NULL OR fp.read_forum=1) AND f.id='.$fid.' AND t.id='.$tid.' AND t.moved_to IS NULL') or error('Unable to fetch topic info', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
$cur_topic = $db->fetch_assoc($result);
@@ -195,6 +195,9 @@ if (isset($_GET['tid']))
// Move the posts to the new topic
$db->query('UPDATE '.$db->prefix.'posts SET topic_id='.$new_tid.' WHERE id IN('.$posts.')') or error('Unable to move posts into new topic', __FILE__, __LINE__, $db->error());
+ // Apply every subscription to both topics
+ $db->query('INSERT INTO '.$db->prefix.'topic_subscriptions (user_id, topic_id) SELECT user_id, '.$new_tid.' FROM '.$db->prefix.'topic_subscriptions WHERE topic_id='.$tid) or error('Unable to copy existing subscriptions', __FILE__, __LINE__, $db->error());
+
// Get last_post, last_post_id, and last_poster from the topic and update it
$result = $db->query('SELECT id, poster, posted FROM '.$db->prefix.'posts WHERE topic_id='.$tid.' ORDER BY id DESC LIMIT 1') or error('Unable to fetch post info', __FILE__, __LINE__, $db->error());
$last_post_data = $db->fetch_assoc($result);
@@ -575,8 +578,18 @@ else if (isset($_POST['merge_topics']) || isset($_POST['merge_topics_comply']))
// Merge the posts into the topic
$db->query('UPDATE '.$db->prefix.'posts SET topic_id='.$merge_to_tid.' WHERE topic_id IN('.implode(',', $topics).')') or error('Unable to merge the posts into the topic', __FILE__, __LINE__, $db->error());
- // Delete any subscriptions
- $db->query('DELETE FROM '.$db->prefix.'topic_subscriptions WHERE topic_id IN('.implode(',', $topics).') AND topic_id != '.$merge_to_tid) or error('Unable to delete subscriptions', __FILE__, __LINE__, $db->error());
+ // Update any subscriptions
+ $result = $db->query('SELECT user_id FROM '.$db->prefix.'topic_subscriptions WHERE topic_id IN ('.implode(',', $topics).')') or error('Unable to fetch subscriptions of merged topics', __FILE__, __LINE__, $db->error());
+
+ $subscribed_users = array();
+ while ($cur_user_id = $db->result($result))
+ $subscribed_users[] = $cur_user_id;
+ $subscribed_users = array_unique($subscribed_users);
+
+ $db->query('DELETE FROM '.$db->prefix.'topic_subscriptions WHERE topic_id IN ('.implode(',', $topics).')') or error('Unable to delete subscriptions of merged topics', __FILE__, __LINE__, $db->error());
+
+ foreach ($subscribed_users as $cur_user_id)
+ $db->query('INSERT INTO '.$db->prefix.'topic_subscriptions (topic_id, user_id) VALUES ('.$merge_to_tid.', '.$cur_user_id.')') or error('Unable to re-enter subscriptions for merge topic', __FILE__, __LINE__, $db->error());
// Without redirection the old topics are removed
if (!isset($_POST['with_redirect']))
@@ -781,7 +794,7 @@ require PUN_ROOT.'lang/'.$pun_user['language'].'/forum.php';
// Fetch some info about the forum
$result = $db->query('SELECT f.forum_name, f.redirect_url, f.num_topics, f.sort_by FROM '.$db->prefix.'forums AS f LEFT JOIN '.$db->prefix.'forum_perms AS fp ON (fp.forum_id=f.id AND fp.group_id='.$pun_user['g_id'].') WHERE (fp.read_forum IS NULL OR fp.read_forum=1) AND f.id='.$fid) or error('Unable to fetch forum info', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
$cur_forum = $db->fetch_assoc($result);
@@ -875,7 +888,7 @@ if ($db->num_rows($result))
$item_status = ($topic_count % 2 == 0) ? 'roweven' : 'rowodd';
$icon_type = 'icon';
- if ($cur_topic['moved_to'] == null)
+ if (is_null($cur_topic['moved_to']))
{
$last_post = '<a href="viewtopic.php?pid='.$cur_topic['last_post_id'].'#p'.$cur_topic['last_post_id'].'">'.format_time($cur_topic['last_post']).'</a> <span class="byuser">'.$lang_common['by'].' '.pun_htmlspecialchars($cur_topic['last_poster']).'</span>';
$ghost_topic = false;
diff --git a/post.php b/post.php
index e0b7192..a01fc1c 100644
--- a/post.php
+++ b/post.php
@@ -11,13 +11,13 @@ require PUN_ROOT.'include/common.php';
if ($pun_user['g_read_board'] == '0')
- message($lang_common['No view']);
+ message($lang_common['No view'], false, '403 Forbidden');
$tid = isset($_GET['tid']) ? intval($_GET['tid']) : 0;
$fid = isset($_GET['fid']) ? intval($_GET['fid']) : 0;
if ($tid < 1 && $fid < 1 || $tid > 0 && $fid > 0)
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
// Fetch some info about the topic and/or the forum
if ($tid)
@@ -26,7 +26,7 @@ else
$result = $db->query('SELECT f.id, f.forum_name, f.moderators, f.redirect_url, fp.post_replies, fp.post_topics FROM '.$db->prefix.'forums AS f LEFT JOIN '.$db->prefix.'forum_perms AS fp ON (fp.forum_id=f.id AND fp.group_id='.$pun_user['g_id'].') WHERE (fp.read_forum IS NULL OR fp.read_forum=1) AND f.id='.$fid) or error('Unable to fetch forum info', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
$cur_posting = $db->fetch_assoc($result);
$is_subscribed = $tid && $cur_posting['is_subscribed'];
@@ -47,7 +47,7 @@ if ((($tid && (($cur_posting['post_replies'] == '' && $pun_user['g_post_replies'
($fid && (($cur_posting['post_topics'] == '' && $pun_user['g_post_topics'] == '0') || $cur_posting['post_topics'] == '0')) ||
(isset($cur_posting['closed']) && $cur_posting['closed'] == '1')) &&
!$is_admmod)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the post.php language file
require PUN_ROOT.'lang/'.$pun_user['language'].'/post.php';
@@ -91,7 +91,7 @@ if (isset($_POST['form_sent']))
else
{
$username = pun_trim($_POST['req_username']);
- $email = strtolower(trim(($pun_config['p_force_guest_email'] == '1') ? $_POST['req_email'] : $_POST['email']));
+ $email = strtolower(pun_trim(($pun_config['p_force_guest_email'] == '1') ? $_POST['req_email'] : $_POST['email']));
$banned_email = false;
// Load the register.php/prof_reg.php language files
@@ -191,12 +191,8 @@ if (isset($_POST['form_sent']))
$new_pid = $db->insert_id();
}
- // Count number of replies in the topic
- $result = $db->query('SELECT COUNT(id) FROM '.$db->prefix.'posts WHERE topic_id='.$tid) or error('Unable to fetch post count for topic', __FILE__, __LINE__, $db->error());
- $num_replies = $db->result($result, 0) - 1;
-
// Update topic
- $db->query('UPDATE '.$db->prefix.'topics SET num_replies='.$num_replies.', last_post='.$now.', last_post_id='.$new_pid.', last_poster=\''.$db->escape($username).'\' WHERE id='.$tid) or error('Unable to update topic', __FILE__, __LINE__, $db->error());
+ $db->query('UPDATE '.$db->prefix.'topics SET num_replies=num_replies+1, last_post='.$now.', last_post_id='.$new_pid.', last_poster=\''.$db->escape($username).'\' WHERE id='.$tid) or error('Unable to update topic', __FILE__, __LINE__, $db->error());
update_search_index('post', $new_pid, $message);
@@ -443,11 +439,11 @@ if ($tid)
{
$qid = intval($_GET['qid']);
if ($qid < 1)
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
$result = $db->query('SELECT poster, message FROM '.$db->prefix.'posts WHERE id='.$qid.' AND topic_id='.$tid) or error('Unable to fetch quote info', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
list($q_poster, $q_message) = $db->fetch_row($result);
diff --git a/profile.php b/profile.php
index 3bf2385..cd43c7e 100644
--- a/profile.php
+++ b/profile.php
@@ -18,14 +18,14 @@ $action = isset($_GET['action']) ? $_GET['action'] : null;
$section = isset($_GET['section']) ? $_GET['section'] : null;
$id = isset($_GET['id']) ? intval($_GET['id']) : 0;
if ($id < 2)
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
if ($action != 'change_pass' || !isset($_GET['key']))
{
if ($pun_user['g_read_board'] == '0')
- message($lang_common['No view']);
+ message($lang_common['No view'], false, '403 Forbidden');
else if ($pun_user['g_view_users'] == '0' && ($pun_user['is_guest'] || $pun_user['id'] != $id))
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
}
// Load the profile.php/register.php language file
@@ -65,17 +65,17 @@ if ($action == 'change_pass')
if ($pun_user['id'] != $id)
{
if (!$pun_user['is_admmod']) // A regular user trying to change another users password?
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
else if ($pun_user['g_moderator'] == '1') // A moderator trying to change a users password?
{
$result = $db->query('SELECT u.group_id, g.g_moderator FROM '.$db->prefix.'users AS u INNER JOIN '.$db->prefix.'groups AS g ON (g.g_id=u.group_id) WHERE u.id='.$id) or error('Unable to fetch user info', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
list($group_id, $is_moderator) = $db->fetch_row($result);
if ($pun_user['g_mod_edit_users'] == '0' || $pun_user['g_mod_change_passwords'] == '0' || $group_id == PUN_ADMIN || $is_moderator == '1')
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
}
}
@@ -161,17 +161,17 @@ else if ($action == 'change_email')
if ($pun_user['id'] != $id)
{
if (!$pun_user['is_admmod']) // A regular user trying to change another users email?
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
else if ($pun_user['g_moderator'] == '1') // A moderator trying to change a users email?
{
$result = $db->query('SELECT u.group_id, g.g_moderator FROM '.$db->prefix.'users AS u INNER JOIN '.$db->prefix.'groups AS g ON (g.g_id=u.group_id) WHERE u.id='.$id) or error('Unable to fetch user info', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
list($group_id, $is_moderator) = $db->fetch_row($result);
if ($pun_user['g_mod_edit_users'] == '0' || $group_id == PUN_ADMIN || $is_moderator == '1')
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
}
}
@@ -199,7 +199,7 @@ else if ($action == 'change_email')
require PUN_ROOT.'include/email.php';
// Validate the email address
- $new_email = strtolower(trim($_POST['req_new_email']));
+ $new_email = strtolower(pun_trim($_POST['req_new_email']));
if (!is_valid_email($new_email))
message($lang_common['Invalid email']);
@@ -316,7 +316,7 @@ else if ($action == 'upload_avatar' || $action == 'upload_avatar2')
message($lang_profile['Avatars disabled']);
if ($pun_user['id'] != $id && !$pun_user['is_admmod'])
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
if (isset($_POST['form_sent']))
{
@@ -439,7 +439,7 @@ else if ($action == 'upload_avatar' || $action == 'upload_avatar2')
else if ($action == 'delete_avatar')
{
if ($pun_user['id'] != $id && !$pun_user['is_admmod'])
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
confirm_referrer('profile.php');
@@ -452,7 +452,7 @@ else if ($action == 'delete_avatar')
else if (isset($_POST['update_group_membership']))
{
if ($pun_user['g_id'] > PUN_ADMIN)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
confirm_referrer('profile.php');
@@ -496,7 +496,7 @@ else if (isset($_POST['update_group_membership']))
else if (isset($_POST['update_forums']))
{
if ($pun_user['g_id'] > PUN_ADMIN)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
confirm_referrer('profile.php');
@@ -537,7 +537,7 @@ else if (isset($_POST['update_forums']))
else if (isset($_POST['ban']))
{
if ($pun_user['g_id'] != PUN_ADMIN && ($pun_user['g_moderator'] != '1' || $pun_user['g_mod_ban_users'] == '0'))
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Get the username of the user we are banning
$result = $db->query('SELECT username FROM '.$db->prefix.'users WHERE id='.$id) or error('Unable to fetch username', __FILE__, __LINE__, $db->error());
@@ -558,7 +558,7 @@ else if (isset($_POST['ban']))
else if (isset($_POST['delete_user']) || isset($_POST['delete_user_comply']))
{
if ($pun_user['g_id'] > PUN_ADMIN)
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
confirm_referrer('profile.php');
@@ -679,7 +679,7 @@ else if (isset($_POST['form_sent']))
// Fetch the user group of the user we are editing
$result = $db->query('SELECT u.username, u.group_id, g.g_moderator FROM '.$db->prefix.'users AS u INNER JOIN '.$db->prefix.'groups AS g ON (g.g_id=u.group_id) WHERE u.id='.$id) or error('Unable to fetch user info', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
list($old_username, $group_id, $is_moderator) = $db->fetch_row($result);
@@ -689,7 +689,7 @@ else if (isset($_POST['form_sent']))
($pun_user['g_mod_edit_users'] == '0' || // mods aren't allowed to edit users
$group_id == PUN_ADMIN || // or the user is an admin
$is_moderator)))) // or the user is another mod
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
if ($pun_user['is_admmod'])
confirm_referrer('profile.php');
@@ -714,7 +714,7 @@ else if (isset($_POST['form_sent']))
$languages = forum_list_langs();
$form['language'] = pun_trim($_POST['form']['language']);
if (!in_array($form['language'], $languages))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
}
if ($pun_user['is_admmod'])
@@ -750,7 +750,7 @@ else if (isset($_POST['form_sent']))
require PUN_ROOT.'include/email.php';
// Validate the email address
- $form['email'] = strtolower(trim($_POST['req_email']));
+ $form['email'] = strtolower(pun_trim($_POST['req_email']));
if (!is_valid_email($form['email']))
message($lang_common['Invalid email']);
}
@@ -884,7 +884,7 @@ else if (isset($_POST['form_sent']))
$styles = forum_list_styles();
$form['style'] = pun_trim($_POST['form']['style']);
if (!in_array($form['style'], $styles))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
}
break;
@@ -927,6 +927,10 @@ else if (isset($_POST['form_sent']))
// If we changed the username we have to update some stuff
if ($username_updated)
{
+ $db->query('UPDATE '.$db->prefix.'bans SET username=\''.$db->escape($form['username']).'\' WHERE username=\''.$db->escape($old_username).'\'') or error('Unable to update bans', __FILE__, __LINE__, $db->error());
+ // If any bans were updated, we will need to know because the cache will need to be regenerated.
+ if ($db->affected_rows() > 0)
+ $bans_updated = true;
$db->query('UPDATE '.$db->prefix.'posts SET poster=\''.$db->escape($form['username']).'\' WHERE poster_id='.$id) or error('Unable to update posts', __FILE__, __LINE__, $db->error());
$db->query('UPDATE '.$db->prefix.'posts SET edited_by=\''.$db->escape($form['username']).'\' WHERE edited_by=\''.$db->escape($old_username).'\'') or error('Unable to update posts', __FILE__, __LINE__, $db->error());
$db->query('UPDATE '.$db->prefix.'topics SET poster=\''.$db->escape($form['username']).'\' WHERE poster=\''.$db->escape($old_username).'\'') or error('Unable to update topics', __FILE__, __LINE__, $db->error());
@@ -965,6 +969,10 @@ else if (isset($_POST['form_sent']))
require PUN_ROOT.'include/cache.php';
generate_users_info_cache();
+
+ // Check if the bans table was updated and regenerate the bans cache when needed
+ if (isset($bans_updated))
+ generate_bans_cache();
}
redirect('profile.php?section='.$section.'&id='.$id, $lang_profile['Profile redirect']);
@@ -973,7 +981,7 @@ else if (isset($_POST['form_sent']))
$result = $db->query('SELECT u.username, u.email, u.title, u.realname, u.url, u.jabber, u.icq, u.msn, u.aim, u.yahoo, u.location, u.signature, u.disp_topics, u.disp_posts, u.email_setting, u.notify_with_post, u.auto_notify, u.show_smilies, u.show_img, u.show_img_sig, u.show_avatars, u.show_sig, u.timezone, u.dst, u.language, u.style, u.num_posts, u.last_post, u.registered, u.registration_ip, u.admin_note, u.date_format, u.time_format, u.last_visit, g.g_id, g.g_user_title, g.g_moderator FROM '.$db->prefix.'users AS u LEFT JOIN '.$db->prefix.'groups AS g ON g.g_id=u.group_id WHERE u.id='.$id) or error('Unable to fetch user info', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
$user = $db->fetch_assoc($result);
@@ -1674,7 +1682,7 @@ else
else if ($section == 'admin')
{
if (!$pun_user['is_admmod'] || ($pun_user['g_moderator'] == '1' && $pun_user['g_mod_ban_users'] == '0'))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '403 Forbidden');
$page_title = array(pun_htmlspecialchars($pun_config['o_board_title']), $lang_common['Profile'], $lang_profile['Section admin']);
define('PUN_ACTIVE_PAGE', 'profile');
diff --git a/register.php b/register.php
index 8e7bceb..9055fde 100644
--- a/register.php
+++ b/register.php
@@ -77,11 +77,11 @@ if (isset($_POST['form_sent']))
$username = pun_trim($_POST['req_user']);
- $email1 = strtolower(trim($_POST['req_email1']));
+ $email1 = strtolower(pun_trim($_POST['req_email1']));
if ($pun_config['o_regs_verify'] == '1')
{
- $email2 = strtolower(trim($_POST['req_email2']));
+ $email2 = strtolower(pun_trim($_POST['req_email2']));
$password1 = random_pass(8);
$password2 = $password1;
diff --git a/search.php b/search.php
index 5174c61..8d092af 100644
--- a/search.php
+++ b/search.php
@@ -18,9 +18,9 @@ require PUN_ROOT.'lang/'.$pun_user['language'].'/forum.php';
if ($pun_user['g_read_board'] == '0')
- message($lang_common['No view']);
+ message($lang_common['No view'], false, '403 Forbidden');
else if ($pun_user['g_search'] == '0')
- message($lang_search['No search permission']);
+ message($lang_search['No search permission'], false, '403 Forbidden');
require PUN_ROOT.'include/search_idx.php';
@@ -44,7 +44,7 @@ if (isset($_GET['action']) || isset($_GET['search_id']))
{
$search_id = intval($_GET['search_id']);
if ($search_id < 1)
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
}
// If it's a regular search (keywords and/or author)
else if ($action == 'search')
@@ -73,11 +73,11 @@ if (isset($_GET['action']) || isset($_GET['search_id']))
{
$user_id = (isset($_GET['user_id'])) ? intval($_GET['user_id']) : $pun_user['id'];
if ($user_id < 2)
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
// Subscribed topics can only be viewed by admins, moderators and the users themselves
if ($action == 'show_subscriptions' && !$pun_user['is_admmod'] && $user_id != $pun_user['id'])
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
}
else if ($action == 'show_recent')
$interval = isset($_GET['value']) ? intval($_GET['value']) : 86400;
@@ -323,7 +323,7 @@ if (isset($_GET['action']) || isset($_GET['search_id']))
if ($action == 'show_new')
{
if ($pun_user['is_guest'])
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
$result = $db->query('SELECT t.id FROM '.$db->prefix.'topics AS t LEFT JOIN '.$db->prefix.'forum_perms AS fp ON (fp.forum_id=t.forum_id AND fp.group_id='.$pun_user['g_id'].') WHERE (fp.read_forum IS NULL OR fp.read_forum=1) AND t.last_post>'.$pun_user['last_visit'].' AND t.moved_to IS NULL'.(isset($_GET['fid']) ? ' AND t.forum_id='.intval($_GET['fid']) : '').' ORDER BY t.last_post DESC') or error('Unable to fetch topic list', __FILE__, __LINE__, $db->error());
$num_hits = $db->num_rows($result);
@@ -517,7 +517,7 @@ if (isset($_GET['action']) || isset($_GET['search_id']))
if ($db->num_rows($result))
$subscriber_name = $db->result($result);
else
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
$crumbs_text['search_type'] = '<a href="search.php?action=show_subscriptions&user_id='.$subscriber_id.'">'.sprintf($lang_search['Quick search show_subscriptions'], pun_htmlspecialchars($subscriber_name)).'</a>';
}
diff --git a/style/Technetium.css b/style/Technetium.css
index c4633cb..d8fd7be 100644
--- a/style/Technetium.css
+++ b/style/Technetium.css
@@ -1029,7 +1029,7 @@ body {
overflow-y: auto
}
-.pun .postmsg img.postimg, .pun .postmsg a img.postimg {
+.pun .postmsg .postimg img, .pun .postmsg a .postimg img {
max-width: 100%;
vertical-align: middle;
}
diff --git a/userlist.php b/userlist.php
index 4b2473b..0f1480d 100644
--- a/userlist.php
+++ b/userlist.php
@@ -11,9 +11,9 @@ require PUN_ROOT.'include/common.php';
if ($pun_user['g_read_board'] == '0')
- message($lang_common['No view']);
+ message($lang_common['No view'], false, '403 Forbidden');
else if ($pun_user['g_view_users'] == '0')
- message($lang_common['No permission']);
+ message($lang_common['No permission'], false, '403 Forbidden');
// Load the userlist.php language file
require PUN_ROOT.'lang/'.$pun_user['language'].'/userlist.php';
diff --git a/viewforum.php b/viewforum.php
index d9fe7a1..b629019 100644
--- a/viewforum.php
+++ b/viewforum.php
@@ -11,12 +11,12 @@ require PUN_ROOT.'include/common.php';
if ($pun_user['g_read_board'] == '0')
- message($lang_common['No view']);
+ message($lang_common['No view'], false, '403 Forbidden');
$id = isset($_GET['id']) ? intval($_GET['id']) : 0;
if ($id < 1)
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
// Load the viewforum.php language file
require PUN_ROOT.'lang/'.$pun_user['language'].'/forum.php';
@@ -28,7 +28,7 @@ else
$result = $db->query('SELECT f.forum_name, f.redirect_url, f.moderators, f.num_topics, f.sort_by, fp.post_topics, 0 AS is_subscribed FROM '.$db->prefix.'forums AS f LEFT JOIN '.$db->prefix.'forum_perms AS fp ON (fp.forum_id=f.id AND fp.group_id='.$pun_user['g_id'].') WHERE (fp.read_forum IS NULL OR fp.read_forum=1) AND f.id='.$id) or error('Unable to fetch forum info', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
$cur_forum = $db->fetch_assoc($result);
@@ -169,7 +169,7 @@ if ($db->num_rows($result))
$item_status = ($topic_count % 2 == 0) ? 'roweven' : 'rowodd';
$icon_type = 'icon';
- if ($cur_topic['moved_to'] == null)
+ if (is_null($cur_topic['moved_to']))
$last_post = '<a href="viewtopic.php?pid='.$cur_topic['last_post_id'].'#p'.$cur_topic['last_post_id'].'">'.format_time($cur_topic['last_post']).'</a> <span class="byuser">'.$lang_common['by'].' '.pun_htmlspecialchars($cur_topic['last_poster']).'</span>';
else
$last_post = '- - -';
@@ -198,7 +198,7 @@ if ($db->num_rows($result))
$item_status .= ' iclosed';
}
- if (!$pun_user['is_guest'] && $cur_topic['last_post'] > $pun_user['last_visit'] && (!isset($tracked_topics['topics'][$cur_topic['id']]) || $tracked_topics['topics'][$cur_topic['id']] < $cur_topic['last_post']) && (!isset($tracked_topics['forums'][$id]) || $tracked_topics['forums'][$id] < $cur_topic['last_post']) && $cur_topic['moved_to'] == null)
+ if (!$pun_user['is_guest'] && $cur_topic['last_post'] > $pun_user['last_visit'] && (!isset($tracked_topics['topics'][$cur_topic['id']]) || $tracked_topics['topics'][$cur_topic['id']] < $cur_topic['last_post']) && (!isset($tracked_topics['forums'][$id]) || $tracked_topics['forums'][$id] < $cur_topic['last_post']) && is_null($cur_topic['moved_to']))
{
$item_status .= ' inew';
$icon_type = 'icon icon-new';
@@ -245,8 +245,8 @@ if ($db->num_rows($result))
</div>
</div>
</td>
- <td class="tc2"><?php echo ($cur_topic['moved_to'] == null) ? forum_number_format($cur_topic['num_replies']) : '-' ?></td>
-<?php if ($pun_config['o_topic_views'] == '1'): ?> <td class="tc3"><?php echo ($cur_topic['moved_to'] == null) ? forum_number_format($cur_topic['num_views']) : '-' ?></td>
+ <td class="tc2"><?php echo (is_null($cur_topic['moved_to'])) ? forum_number_format($cur_topic['num_replies']) : '-' ?></td>
+<?php if ($pun_config['o_topic_views'] == '1'): ?> <td class="tc3"><?php echo (is_null($cur_topic['moved_to'])) ? forum_number_format($cur_topic['num_views']) : '-' ?></td>
<?php endif; ?> <td class="tcr"><?php echo $last_post ?></td>
</tr>
<?php
diff --git a/viewtopic.php b/viewtopic.php
index 7d1eab6..dd47aaa 100644
--- a/viewtopic.php
+++ b/viewtopic.php
@@ -11,14 +11,14 @@ require PUN_ROOT.'include/common.php';
if ($pun_user['g_read_board'] == '0')
- message($lang_common['No view']);
+ message($lang_common['No view'], false, '403 Forbidden');
$action = isset($_GET['action']) ? $_GET['action'] : null;
$id = isset($_GET['id']) ? intval($_GET['id']) : 0;
$pid = isset($_GET['pid']) ? intval($_GET['pid']) : 0;
if ($id < 1 && $pid < 1)
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
// Load the viewtopic.php language file
require PUN_ROOT.'lang/'.$pun_user['language'].'/topic.php';
@@ -29,7 +29,7 @@ if ($pid)
{
$result = $db->query('SELECT topic_id, posted FROM '.$db->prefix.'posts WHERE id='.$pid) or error('Unable to fetch topic ID', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
list($id, $posted) = $db->fetch_row($result);
@@ -85,7 +85,7 @@ else
$result = $db->query('SELECT t.subject, t.closed, t.num_replies, t.sticky, t.first_post_id, f.id AS forum_id, f.forum_name, f.moderators, fp.post_replies, 0 AS is_subscribed FROM '.$db->prefix.'topics AS t INNER JOIN '.$db->prefix.'forums AS f ON f.id=t.forum_id LEFT JOIN '.$db->prefix.'forum_perms AS fp ON (fp.forum_id=f.id AND fp.group_id='.$pun_user['g_id'].') WHERE (fp.read_forum IS NULL OR fp.read_forum=1) AND t.id='.$id.' AND t.moved_to IS NULL') or error('Unable to fetch topic info', __FILE__, __LINE__, $db->error());
if (!$db->num_rows($result))
- message($lang_common['Bad request']);
+ message($lang_common['Bad request'], false, '404 Not Found');
$cur_topic = $db->fetch_assoc($result);
More information about the Xfce4-commits
mailing list