[Xfce4-commits] <midori:master> Reverse certificate check in navigation_decision_cb

[Christian Dywan]

Updating branch refs/heads/master
         to 49dae87d36c4b4e48d7f67c51552959ed83dc697 (commit)
       from cfb0db3b600d86298946c891663f8a7bb4676e04 (commit)

commit 49dae87d36c4b4e48d7f67c51552959ed83dc697
Author: Christian Dywan <christian at twotoasts.de>
Date:   Mon Aug 27 19:02:37 2012 +0200

    Reverse certificate check in navigation_decision_cb

 midori/midori-view.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/midori/midori-view.c b/midori/midori-view.c
index f9d3414..267cd1b 100644
--- a/midori/midori-view.c
+++ b/midori/midori-view.c
@@ -988,15 +988,15 @@ midori_view_web_view_navigation_decision_cb (WebKitWebView*             web_view
                 g_object_get (tls_cert, "certificate", &der_cert, NULL);
                 gcr_cert = gcr_simple_certificate_new (der_cert->data, der_cert->len);
                 g_byte_array_unref (der_cert);
-                if (soup_uri && soup_uri->host && gcr_trust_is_certificate_pinned (gcr_cert, GCR_PURPOSE_SERVER_AUTH, soup_uri->host, NULL, NULL))
+                if (soup_uri && soup_uri->host && !gcr_trust_is_certificate_pinned (gcr_cert, GCR_PURPOSE_SERVER_AUTH, soup_uri->host, NULL, NULL))
                 {
                     GError* error = NULL;
                     gcr_trust_add_pinned_certificate (gcr_cert, GCR_PURPOSE_SERVER_AUTH, soup_uri->host, NULL, &error);
                     if (error != NULL)
                     {
-                        midori_view_stop_loading (view);
                         gchar* slots = g_strjoinv (" , ", (gchar**)gcr_pkcs11_get_trust_lookup_uris ());
                         gchar* title = g_strdup_printf ("Error granting trust: %s", error->message);
+                        midori_view_stop_loading (view);
                         midori_view_display_error (view, view->uri,
                             view->title ? view->title : view->uri, title, slots,
                             _("Trust this website"), NULL);
@@ -1121,6 +1121,7 @@ webkit_web_view_load_committed_cb (WebKitWebView*  web_view,
 
             message = midori_map_get_message (message);
             g_object_get (message, "tls-certificate", &tls_cert, NULL);
+            g_return_if_fail (tls_cert != NULL);
             g_object_get (tls_cert, "certificate", &der_cert, NULL);
             gcr_cert = gcr_simple_certificate_new (der_cert->data, der_cert->len);
             g_byte_array_unref (der_cert);