[Xfce4-commits] <midori:master> Only show close in speed dial if it can be saved

[Christian Dywan]

Updating branch refs/heads/master
         to 2f40eee0a504be86a1d2dd106f23db5c8f957426 (commit)
       from 19a8002eeee50c8145b6c13e28e9d4991a01ce10 (commit)

commit 2f40eee0a504be86a1d2dd106f23db5c8f957426
Author: Christian Dywan <christian at twotoasts.de>
Date:   Tue Oct 11 02:48:47 2011 +0200

    Only show close in speed dial if it can be saved
    
    And un-negate return value of sokoke_is_app_or_private().

 midori/midori-preferences.c |    2 +-
 midori/midori-view.c        |   12 +++++++++++-
 midori/sokoke.c             |    2 +-
 3 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/midori/midori-preferences.c b/midori/midori-preferences.c
index 4d4a771..59ade73 100644
--- a/midori/midori-preferences.c
+++ b/midori/midori-preferences.c
@@ -296,7 +296,7 @@ midori_preferences_set_settings (MidoriPreferences* preferences,
     #define SPANNED_ADD(__widget) \
      katze_preferences_add_widget (_preferences, __widget, "spanned")
     /* Page "General" */
-    if (sokoke_is_app_or_private ())
+    if (!sokoke_is_app_or_private ())
     {
     PAGE_NEW (GTK_STOCK_HOME, _("Startup"));
     FRAME_NEW (NULL);
diff --git a/midori/midori-view.c b/midori/midori-view.c
index 80fd9d2..8e2086c 100644
--- a/midori/midori-view.c
+++ b/midori/midori-view.c
@@ -2609,7 +2609,7 @@ midori_view_populate_popup (MidoriView* view,
                 gtk_action_group_get_action (actions, "BookmarkAdd"));
         gtk_menu_shell_append (menu_shell, menuitem);
 
-        if (!midori_view_is_blank (view) && sokoke_is_app_or_private ())
+        if (!midori_view_is_blank (view) && !sokoke_is_app_or_private ())
         {
             menuitem = sokoke_action_create_popup_menu_item (
                 gtk_action_group_get_action (actions, "AddSpeedDial"));
@@ -3332,6 +3332,12 @@ midori_view_settings_notify_cb (MidoriWebSettings* settings,
         view->middle_click_opens_selection = g_value_get_boolean (&value);
     else if (name == g_intern_string ("open-tabs-in-the-background"))
         view->open_tabs_in_the_background = g_value_get_boolean (&value);
+    else if (name == g_intern_string ("enable-scripts"))
+    {
+        /* Speed dial is only editable with scripts, so regenerate it */
+        if (midori_view_is_blank (view))
+            midori_view_reload (view, FALSE);
+    }
 
     g_value_unset (&value);
 }
@@ -3740,8 +3746,12 @@ prepare_speed_dial_html (MidoriView* view)
 
    /* percent width size of one slot */
    slot_size = (100 / grid_index);
+   /* No editing in private/ app mode or without scripts */
    g_string_append_printf (markup,
+        "%s<style>.cross { display:none }</style>%s"
         "<style> div.shortcut { height: %d%%; width: %d%%; }</style>\n",
+        sokoke_is_app_or_private () ? "" : "<noscript>",
+        sokoke_is_app_or_private () ? "" : "</noscript>",
         slot_size + 1, slot_size - 4);
 
     while (slot <= slot_count)
diff --git a/midori/sokoke.c b/midori/sokoke.c
index 1ed09cc..707490a 100644
--- a/midori/sokoke.c
+++ b/midori/sokoke.c
@@ -1633,7 +1633,7 @@ sokoke_set_config_dir (const gchar* new_config_dir)
 gboolean
 sokoke_is_app_or_private (void)
 {
-    return strcmp ("/", sokoke_set_config_dir (NULL));
+    return !strcmp ("/", sokoke_set_config_dir (NULL));
 }
 
 /**