[Xfce4-commits] <midori:master> Don't emit add-download before all preparations

Christian Dywan noreply at xfce.org
Sun Mar 6 17:28:01 CET 2011


Updating branch refs/heads/master
         to 663e7e9285807130999aa9615635f7a037422956 (commit)
       from bbc6bdea3005b02fad3091bd5c635c97f0a0de4d (commit)

commit 663e7e9285807130999aa9615635f7a037422956
Author: Christian Dywan <christian at twotoasts.de>
Date:   Sun Mar 6 17:20:18 2011 +0100

    Don't emit add-download before all preparations
    
    Notably verifying that there's space available and a file
    shouldn't be overriden has to come first. This already was
    the case for the transferbar which isn't using the signal.

 midori/midori-browser.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/midori/midori-browser.c b/midori/midori-browser.c
index 0efb183..325aef9 100644
--- a/midori/midori-browser.c
+++ b/midori/midori-browser.c
@@ -983,6 +983,7 @@ midori_browser_prepare_download (MidoriBrowser*  browser,
     }
 
     webkit_download_set_destination_uri (download, uri);
+    g_signal_emit (browser, signals[ADD_DOWNLOAD], 0, download);
     midori_transferbar_add_download_item (MIDORI_TRANSFERBAR (browser->transferbar), download);
     return TRUE;
 }
@@ -1416,7 +1417,6 @@ midori_view_download_requested_cb (GtkWidget*      view,
                                    WebKitDownload* download,
                                    MidoriBrowser*  browser)
 {
-    g_signal_emit (browser, signals[ADD_DOWNLOAD], 0, download);
     if (!webkit_download_get_destination_uri (download))
     {
         gchar* folder;



More information about the Xfce4-commits mailing list