[Xfce4-commits] <xfce4-timer-plugin:master> Fix segfault when creating plugin in 4.8 panel.

Nick Schermer noreply at xfce.org
Thu Jan 27 22:20:01 CET 2011


Updating branch refs/heads/master
         to 03ff202f818fe3f075a6c864ab688b57b1bb1cb4 (commit)
       from ba75dc5e5dee8b3addb1caceb5818d8b74f1250b (commit)

commit 03ff202f818fe3f075a6c864ab688b57b1bb1cb4
Author: Nick Schermer <nick at xfce.org>
Date:   Thu Jan 27 22:18:45 2011 +0100

    Fix segfault when creating plugin in 4.8 panel.
    
    Used invalid function type to construct the plugin.

 src/xfcetimer.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/xfcetimer.c b/src/xfcetimer.c
index c27d37a..de7bd2b 100644
--- a/src/xfcetimer.c
+++ b/src/xfcetimer.c
@@ -42,7 +42,7 @@
 
 #include "xfcetimer.h"
 
-static gboolean create_plugin_control (XfcePanelPlugin *plugin);
+static void create_plugin_control (XfcePanelPlugin *plugin);
 XFCE_PANEL_PLUGIN_REGISTER_EXTERNAL(create_plugin_control);
 
 void make_menu(plugin_data *pd);
@@ -1366,7 +1366,7 @@ static void plugin_create_options (XfcePanelPlugin *plugin,plugin_data *pd) {
  *
  * Returns %TRUE on success, %FALSE on failure.
  **/
-static gboolean
+static void
 create_plugin_control (XfcePanelPlugin *plugin)
 {
 
@@ -1461,7 +1461,6 @@ create_plugin_control (XfcePanelPlugin *plugin)
   xfce_panel_plugin_menu_show_configure (plugin);
   g_signal_connect (plugin, "configure-plugin",
                       G_CALLBACK (plugin_create_options), pd);
-  return(TRUE);
 }
 
 



More information about the Xfce4-commits mailing list