[Xfce4-commits] <tumbler:master> Fix a segfault when one of the thumbnailer dirs is deleted (bug #6134).

Jannis Pohlmann noreply at xfce.org
Sat Nov 13 14:38:01 CET 2010


Updating branch refs/heads/master
         to 6224fb7559ee76e2ffea90fbaf8835125c842de3 (commit)
       from 769428c295b7739e7e951aa709addb9105190333 (commit)

commit 6224fb7559ee76e2ffea90fbaf8835125c842de3
Author: Jannis Pohlmann <jannis at xfce.org>
Date:   Sat Nov 13 14:35:07 2010 +0100

    Fix a segfault when one of the thumbnailer dirs is deleted (bug #6134).
    
    These crashes were due to an uninitialized variable (delete_keys),
    causing an iteration over a broken GList of strings.

 NEWS                       |    5 +++++
 tumblerd/tumbler-manager.c |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/NEWS b/NEWS
index 7c913a7..be381a9 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,8 @@
+0.1.x
+=====
+- Fix a segmentation fault when one of the thumbnailer directories is
+  deleted (bug #6134).
+
 0.1.4
 =====
 - Use LGPL instead of GPL license headers in the library (bug #6781).
diff --git a/tumblerd/tumbler-manager.c b/tumblerd/tumbler-manager.c
index b653635..ea552bc 100644
--- a/tumblerd/tumbler-manager.c
+++ b/tumblerd/tumbler-manager.c
@@ -1408,7 +1408,7 @@ tumbler_manager_directory_deleted (TumblerManager *manager,
   GHashTableIter   iter;
   const gchar     *hash_key;
   GFile           *file;
-  GList           *delete_keys;
+  GList           *delete_keys = NULL;
   GList          **list;
   GList           *lp;
   GStrv            hash_keys;



More information about the Xfce4-commits mailing list