[Xfce4-commits] <xfce-utils:completion> Only allow to cycle backwards if we cycled forwards.

[Jérôme Guelfucci]

Updating branch refs/heads/completion
         to 8433c2053b8bb2e2ac7406eb675462e6e9f136bb (commit)
       from cd5372371dcf6479d55611259cf613efb059997d (commit)

commit 8433c2053b8bb2e2ac7406eb675462e6e9f136bb
Author: Jérôme Guelfucci <jeromeg at xfce.org>
Date:   Wed Nov 3 22:20:58 2010 +0100

    Only allow to cycle backwards if we cycled forwards.

 xfrun/xfrun-dialog.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xfrun/xfrun-dialog.c b/xfrun/xfrun-dialog.c
index 619edef..abe8a25 100644
--- a/xfrun/xfrun-dialog.c
+++ b/xfrun/xfrun-dialog.c
@@ -249,7 +249,7 @@ xfrun_dialog_key_press_event(GtkWidget *widget,
     if(evt->keyval == GDK_Escape) {
         xfrun_dialog_delete_event(widget, NULL);
         return TRUE;
-    } else if(evt->keyval == GDK_Down) {
+    } else if(evt->keyval == GDK_Down && dialog->priv->in_history_cycle) {
         XfrunHistoryItem *item;
 
         item = xfrun_history_get_previous(dialog->priv->history);
@@ -259,7 +259,6 @@ xfrun_dialog_key_press_event(GtkWidget *widget,
             gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON (dialog->priv->terminal_chk),
                                          item->in_terminal);
             gtk_editable_set_position (GTK_EDITABLE(dialog->priv->entry), -1);
-            dialog->priv->in_history_cycle = TRUE;
         }
 
         return TRUE;
@@ -273,6 +272,7 @@ xfrun_dialog_key_press_event(GtkWidget *widget,
             gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON (dialog->priv->terminal_chk),
                                          item->in_terminal);
             gtk_editable_set_position (GTK_EDITABLE(dialog->priv->entry), -1);
+            dialog->priv->in_history_cycle = TRUE;
         }
 
         return TRUE;