[Xfce4-commits] <xfce-utils:completion> Don't try to free the completion lists.

Jérôme Guelfucci noreply at xfce.org
Wed Nov 3 21:04:09 CET 2010


Updating branch refs/heads/completion
         to eb89a1cdeb78940fcd84640f0c81d30dd970f86c (commit)
       from a6d41a64f02a8af8e6f5127fa56d45952e164f87 (commit)

commit eb89a1cdeb78940fcd84640f0c81d30dd970f86c
Author: Jérôme Guelfucci <jeromeg at xfce.org>
Date:   Sun Oct 31 23:28:47 2010 +0100

    Don't try to free the completion lists.
    
    They are owned by the GCompletion object.

 xfrun/xfrun-history.c |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)

diff --git a/xfrun/xfrun-history.c b/xfrun/xfrun-history.c
index c69730a..c8f4a9c 100644
--- a/xfrun/xfrun-history.c
+++ b/xfrun/xfrun-history.c
@@ -92,11 +92,6 @@ xfrun_history_finalize (GObject *gobject)
   /* Free the completion stuff */
   if (self->priv->full_completion)
     g_completion_free (self->priv->full_completion);
-  if (self->priv->completion)
-    {
-      g_list_foreach (self->priv->completion, xfrun_history_free_list, NULL);
-      g_list_free (self->priv->completion);
-    }
 
   /* Chain up to the parent class */
   G_OBJECT_CLASS (xfrun_history_parent_class)->finalize (gobject);
@@ -359,10 +354,6 @@ XfrunHistoryItem
   if (history->priv->full_completion == NULL)
     return NULL;
 
-  if (history->priv->completion)
-    /* Note: we don't have to free the items, they are owned by the completion stuff */
-    g_list_free (history->priv->completion);
-
   /* Try to complete the given string and save the items */
   history->priv->completion = g_completion_complete_utf8 (history->priv->full_completion,
                                                           prefix,
@@ -463,10 +454,6 @@ xfrun_history_completion_reset (XfrunHistory *history)
 {
   g_return_if_fail (XFRUN_IS_HISTORY (history));
 
-  if (history->priv->completion)
-    /* Note: we don't have to free the items, they are owned by the completion stuff */
-    g_list_free (history->priv->completion);
-
   /* Reset the completion lists */
   history->priv->completion = NULL;
   history->priv->current_completion = NULL;



More information about the Xfce4-commits mailing list