[Xfce4-commits] <midori:master> Force items dragged onto non-folders to the toplevel

[Christian Dywan]

Updating branch refs/heads/master
         to 78cfcb64d9505a16a9ac1ce985b9dfe3e4d74bbb (commit)
       from 2caaed659c1ecd6ef47db813db90eb5daade88cb (commit)

commit 78cfcb64d9505a16a9ac1ce985b9dfe3e4d74bbb
Author: Christian Dywan <christian at twotoasts.de>
Date:   Sat Jul 3 23:05:09 2010 +0200

    Force items dragged onto non-folders to the toplevel

 panels/midori-bookmarks.c |   14 +++++++++++---
 1 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/panels/midori-bookmarks.c b/panels/midori-bookmarks.c
index 393cb66..1c2bd74 100644
--- a/panels/midori-bookmarks.c
+++ b/panels/midori-bookmarks.c
@@ -259,7 +259,6 @@ midori_bookmarks_row_changed_cb (GtkTreeModel*    model,
                                  GtkTreeIter*     iter,
                                  MidoriBookmarks* bookmarks)
 {
-    KatzeItem* parent_item;
     KatzeItem* item;
     GtkTreeIter parent;
     sqlite3* db;
@@ -270,8 +269,17 @@ midori_bookmarks_row_changed_cb (GtkTreeModel*    model,
 
     if (gtk_tree_model_iter_parent (model, &parent, iter))
     {
-        gtk_tree_model_get (model, &parent , 0, &parent_item, -1);
-        parent_name = g_strdup (katze_item_get_name (parent_item));
+        KatzeItem* new_parent;
+
+        gtk_tree_model_get (model, &parent, 0, &new_parent, -1);
+
+        /* Bookmarks must not be moved into non-folder items */
+        if (!KATZE_ITEM_IS_FOLDER (new_parent))
+            parent_name = g_strdup ("");
+        else
+            parent_name = g_strdup (katze_item_get_name (new_parent));
+
+        g_object_unref (new_parent);
     }
     else
         parent_name = g_strdup ("");