[Xfce4-commits] <xfwm4:master> Missing setting for cycle_apps_only cycle_apps_only defaults to false as it might be confusing at times

[Olivier Fourdan]

Updating branch refs/heads/master
         to c09471fa5f99207d8356357d63b8da9afcf2f9be (commit)
       from 62b44d6241a2a88a32b26e0908b350971892ce3a (commit)

commit c09471fa5f99207d8356357d63b8da9afcf2f9be
Author: Olivier Fourdan <fourdan at xfce.org>
Date:   Wed Feb 24 09:44:17 2010 +0100

    Missing setting for cycle_apps_only
    cycle_apps_only defaults to false as it might be confusing at times

 defaults/defaults |    2 +-
 src/settings.c    |   10 +++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/defaults/defaults b/defaults/defaults
index 9b1f892..fca5077 100644
--- a/defaults/defaults
+++ b/defaults/defaults
@@ -7,7 +7,7 @@ button_offset=0
 button_spacing=0
 click_to_focus=true
 cycle_draw_frame=true
-cycle_apps_only=true
+cycle_apps_only=false
 cycle_hidden=true
 cycle_minimum=true
 cycle_workspaces=false
diff --git a/src/settings.c b/src/settings.c
index 0e5bd47..ca0cd7a 100644
--- a/src/settings.c
+++ b/src/settings.c
@@ -1103,7 +1103,7 @@ cb_xfwm4_channel_property_changed(XfconfChannel *channel, const gchar *property_
                 }
                 else
                 {
-                    g_warning("The property '%s' is not supported", property_name);
+                    g_warning("The property '%s' of type string is not supported", property_name);
                 }
                 break;
             case G_TYPE_INT:
@@ -1188,7 +1188,7 @@ cb_xfwm4_channel_property_changed(XfconfChannel *channel, const gchar *property_
                 }
                 else
                 {
-                    g_warning("The property '%s' is not supported", property_name);
+                    g_warning("The property '%s' of type int is not supported", property_name);
                 }
                 break;
             case G_TYPE_BOOLEAN:
@@ -1264,6 +1264,10 @@ cb_xfwm4_channel_property_changed(XfconfChannel *channel, const gchar *property_
                 {
                     screen_info->params->cycle_workspaces = g_value_get_boolean (value);
                 }
+                else if (!strcmp (name, "cycle_apps_only"))
+                {
+                    screen_info->params->cycle_apps_only = g_value_get_boolean (value);
+                }
                 else if (!strcmp (name, "focus_hint"))
                 {
                     screen_info->params->focus_hint = g_value_get_boolean (value);
@@ -1333,7 +1337,7 @@ cb_xfwm4_channel_property_changed(XfconfChannel *channel, const gchar *property_
                 }
                 else
                 {
-                    g_warning("The property '%s' is not supported", property_name);
+                    g_warning("The property '%s' of type boolean is not supported", property_name);
                 }
                 break;
             default: