[Xfce4-commits] <midori:master> Disconnect insertion when MidoriHistory finalizes

Christian Dywan noreply at xfce.org
Fri Aug 13 02:56:05 CEST 2010


Updating branch refs/heads/master
         to 71549af0890ffb5f7eae01c40d7f334d31a8b3f3 (commit)
       from 8015f39fe61cb6b34da5c48b72734613622a6dff (commit)

commit 71549af0890ffb5f7eae01c40d7f334d31a8b3f3
Author: Christian Dywan <christian at twotoasts.de>
Date:   Tue Aug 10 22:58:11 2010 +0200

    Disconnect insertion when MidoriHistory finalizes

 panels/midori-history.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/panels/midori-history.c b/panels/midori-history.c
index f681ddc..17f79e3 100644
--- a/panels/midori-history.c
+++ b/panels/midori-history.c
@@ -988,8 +988,8 @@ midori_history_finalize (GObject* object)
     if (history->app)
         g_object_unref (history->app);
 
-    /* FIXME: We don't unref items (last argument is FALSE) because
-       our reference counting is incorrect. */
+    g_signal_handlers_disconnect_by_func (history->array,
+        midori_history_add_item_cb, history);
     g_object_unref (history->array);
     katze_assign (history->filter, NULL);
 }



More information about the Xfce4-commits mailing list