[Xfce4-commits] <xfconf:master> don't emit property-changed twice (bug 5718)

[Brian J. Tarricone]

Updating branch refs/heads/master
         to acb9b2085364aa860aed4df663cb95b8931d5a18 (commit)
       from 0aa4faca0929d45902e878fd859aba37c35d04e7 (commit)

commit acb9b2085364aa860aed4df663cb95b8931d5a18
Author: Brian J. Tarricone <brian at tarricone.org>
Date:   Thu Sep 3 20:03:24 2009 -0700

    don't emit property-changed twice (bug 5718)
    
    this can cause infinite loops because the XfconfCache will avoid
    emitting property-changed if set() is called which re-sets the value
    to the already-set value, but XfconfChannel would emit the signal
    no matter what.

 xfconf/xfconf-channel.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/xfconf/xfconf-channel.c b/xfconf/xfconf-channel.c
index 09f453e..5d3178a 100644
--- a/xfconf/xfconf-channel.c
+++ b/xfconf/xfconf-channel.c
@@ -396,9 +396,6 @@ xfconf_channel_set_internal(XfconfChannel *channel,
     if(real_property != property)
         g_free(real_property);
 
-    if(ret)
-        g_signal_emit(channel, signals[SIG_PROPERTY_CHANGED], 0, property, value);
-
     return ret;
 }