[Xfce4-commits] <garcon:master> Fix typo causing all items to appear only in the Others menu.

[Jannis Pohlmann]

Updating branch refs/heads/master
         to 6d08ace2b756d97b2e8c1d953d5ef2ce03ca62f0 (commit)
       from e4e3413e3158f7b340e5c7fac481ccc782262d5d (commit)

commit 6d08ace2b756d97b2e8c1d953d5ef2ce03ca62f0
Author: Jannis Pohlmann <jannis at xfce.org>
Date:   Tue Sep 1 23:24:35 2009 +0200

    Fix typo causing all items to appear only in the Others menu.
    
    Code and comment didn't match. We want to leave
    garcon_menu_item_set_categories() if the category pointers are *equal*,
    not if they are different.
    
    Thanks to Andrea Santilli for reporting and git-bisect for revealing
    the commit introducing the issue.

 garcon/garcon-menu-item.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/garcon/garcon-menu-item.c b/garcon/garcon-menu-item.c
index ec14ad8..ba21aed 100644
--- a/garcon/garcon-menu-item.c
+++ b/garcon/garcon-menu-item.c
@@ -996,7 +996,7 @@ garcon_menu_item_set_categories (GarconMenuItem *item,
   g_return_if_fail (GARCON_IS_MENU_ITEM (item));
 
   /* Abort if lists are equal */
-  if (G_UNLIKELY (item->priv->categories != categories))
+  if (G_UNLIKELY (item->priv->categories == categories))
     return;
 
   /* Free old list */