[Xfce4-commits] <parole:master> This is probably not the best thing, but the browser plugin fails to compile with --enable-debug=full so overried CXXFLAGS to get rid of -Wundef -Wredundant-decls -Wmissing-declarations

Ali Abdallah noreply at xfce.org
Thu Nov 19 11:20:01 CET 2009


Updating branch refs/heads/master
         to 6ddf2e9926c6f5618aa6f720dbf0099160a57e66 (commit)
       from 729ced4fb521636dd32e6d178f6708ce42fd72c6 (commit)

commit 6ddf2e9926c6f5618aa6f720dbf0099160a57e66
Author: Ali Abdallah <ali at ali-xfce.org>
Date:   Tue Nov 17 23:28:46 2009 +0100

    This is probably not the best thing, but the browser plugin
    fails to compile with --enable-debug=full so overried CXXFLAGS
    to get rid of -Wundef -Wredundant-decls -Wmissing-declarations

 browser-plugin/Makefile.am  |   14 ++++++++++++++
 browser-plugin/npp_gate.cpp |    5 ++++-
 browser-plugin/plugin.cpp   |    4 ++++
 configure.ac.in             |    1 +
 4 files changed, 23 insertions(+), 1 deletions(-)

diff --git a/browser-plugin/Makefile.am b/browser-plugin/Makefile.am
index b3f3a70..f30bf02 100644
--- a/browser-plugin/Makefile.am
+++ b/browser-plugin/Makefile.am
@@ -4,6 +4,20 @@ SUBDIRS = media-plugin
 
 DEFINES = -DMOZILLA_STRICT_API -DXP_UNIX
 
+# This is probably not the best thing, but the browser plugin 
+# fails to compile with --enable-debug=full so overried CXXFLAGS
+# to get rid of -Wundef -Wredundant-decls -Wmissing-declarations
+CXXFLAGS = -Wall
+if DEBUG_BROWSER_PLUGIN
+CXXFLAGS += -Wextra -Wno-missing-field-initializers	\
+	-Wno-unused-parameter 				\
+	-Wmissing-noreturn -Wshadow 			\
+	-Wpointer-arith -Wcast-align -Wformat-security 	\
+	-Winit-self -Wmissing-include-dirs		\
+	-Wmissing-format-attribute 		 	\
+	-fstack-protector -O0 -g3 -Werror
+endif
+
 INCLUDES =                                              \
         -fPIC                                           \
         -I$(top_builddir)                               \
diff --git a/browser-plugin/npp_gate.cpp b/browser-plugin/npp_gate.cpp
index 6c7023c..869f90d 100644
--- a/browser-plugin/npp_gate.cpp
+++ b/browser-plugin/npp_gate.cpp
@@ -274,9 +274,12 @@ int16 NPP_HandleEvent(NPP instance, void *event)
         return 0;
 
     int16 rv = 0;
+    /*
     CPlugin *pPlugin = (CPlugin *) instance->pdata;
+    
     if (pPlugin)
-       //rv = pPlugin->handleEvent(event);
+	rv = pPlugin->handleEvent(event);
+    */
 
     return rv;
 }
diff --git a/browser-plugin/plugin.cpp b/browser-plugin/plugin.cpp
index 0e817b1..877558f 100644
--- a/browser-plugin/plugin.cpp
+++ b/browser-plugin/plugin.cpp
@@ -39,6 +39,10 @@
 #include "plugin_setup.h"
 #include "plugin_types.h"
 
+NPError NS_PluginInitialize();
+void NS_PluginShutdown();
+NPError NS_PluginGetValue(NPPVariable aVariable, void *aValue);
+
 //////////////////////////////////////
 //
 // general initialization and shutdown
diff --git a/configure.ac.in b/configure.ac.in
index 816877d..10727b0 100644
--- a/configure.ac.in
+++ b/configure.ac.in
@@ -208,6 +208,7 @@ fi
 #              Check for debugging support              #
 #=======================================================#
 XDT_FEATURE_DEBUG()
+AM_CONDITIONAL([DEBUG_BROWSER_PLUGIN], [test x"$enable_debug" = x"full"])
 
 #=======================================================#
 #              Developement debugging                   #



More information about the Xfce4-commits mailing list