[Xfce4-commits] r29537 - in xfce-utils/trunk: . xfrun

[Brian Tarricone]

Author: kelnos
Date: 2009-02-22 19:09:58 +0000 (Sun, 22 Feb 2009)
New Revision: 29537

Modified:
   xfce-utils/trunk/NEWS
   xfce-utils/trunk/xfrun/xfrun-dbus.c
   xfce-utils/trunk/xfrun/xfrun-dialog.c
   xfce-utils/trunk/xfrun/xfrun-dialog.h
Log:
make sure text in dialog gets selected (bug 2836)

Modified: xfce-utils/trunk/NEWS
===================================================================
--- xfce-utils/trunk/NEWS	2009-02-22 16:58:44 UTC (rev 29536)
+++ xfce-utils/trunk/NEWS	2009-02-22 19:09:58 UTC (rev 29537)
@@ -1,10 +1,12 @@
-4.6.0 (Xfce 4.6.0)?
-===================
+4.6.0 (Xfce 4.6.0)
+==================
 
 - Fix sysconfdir and datadir not being expanded properly in 
   xinitrc (bug #4924).
 - Export GTK_PATH variable in xinitrc so that GTK+ has a chance to find
   the Xfce theme engine even in a custom prefix (bug #4925).
+- Ensure that xfrun dialog text is selected when the dialog is reshown
+  via the dbus interface (bug 2836).
 
 
 4.5.99.1 (Xfce 4.6rc1)

Modified: xfce-utils/trunk/xfrun/xfrun-dbus.c
===================================================================
--- xfce-utils/trunk/xfrun/xfrun-dbus.c	2009-02-22 16:58:44 UTC (rev 29536)
+++ xfce-utils/trunk/xfrun/xfrun-dbus.c	2009-02-22 19:09:58 UTC (rev 29537)
@@ -174,6 +174,7 @@
                 /* this handles setting the dialog to the right screen */
                 xfce_gtk_window_center_on_monitor(GTK_WINDOW(dialog),
                                                   gscreen, 0);
+                xfrun_dialog_select_text(XFRUN_DIALOG(dialog));
                 gtk_widget_show(dialog);
             
                 reply = dbus_message_new_method_return(message);

Modified: xfce-utils/trunk/xfrun/xfrun-dialog.c
===================================================================
--- xfce-utils/trunk/xfrun/xfrun-dialog.c	2009-02-22 16:58:44 UTC (rev 29536)
+++ xfce-utils/trunk/xfrun/xfrun-dialog.c	2009-02-22 19:09:58 UTC (rev 29537)
@@ -674,3 +674,10 @@
     g_return_val_if_fail(XFRUN_IS_DIALOG(dialog), NULL);
     return dialog->priv->working_directory;
 }
+
+void
+xfrun_dialog_select_text(XfrunDialog *dialog)
+{
+    gtk_editable_select_region(GTK_EDITABLE(XFRUN_DIALOG(dialog)->priv->entry),
+                               0, -1);
+}

Modified: xfce-utils/trunk/xfrun/xfrun-dialog.h
===================================================================
--- xfce-utils/trunk/xfrun/xfrun-dialog.h	2009-02-22 16:58:44 UTC (rev 29536)
+++ xfce-utils/trunk/xfrun/xfrun-dialog.h	2009-02-22 19:09:58 UTC (rev 29537)
@@ -63,6 +63,9 @@
 
 void xfrun_dialog_set_working_directory            (XfrunDialog *dialog,
                                                     const gchar *working_directory);
+
+void xfrun_dialog_select_text                      (XfrunDialog *dialog);
+
 G_CONST_RETURN gchar *xfrun_dialog_get_working_directory
                                                    (XfrunDialog *dialog);