[Xfce4-commits] <xfce4-dev-tools:master> print warning if attempting to compare git revision versions

Brian J. Tarricone brian at tarricone.org
Thu Aug 27 00:00:06 CEST 2009


Updating branch refs/heads/master
         to 65753f2d0307d51b2d15e66e76ef6599fac17264 (commit)
       from 2aea2c13e03ac17169bbfd5cb279cca513c2ffd8 (commit)

commit 65753f2d0307d51b2d15e66e76ef6599fac17264
Author: Brian J. Tarricone <brian at tarricone.org>
Date:   Wed Aug 26 14:46:13 2009 -0700

    print warning if attempting to compare git revision versions
    
    we can't tell version ordering, but it's possible it's fine, so just
    print a warning and proceed.  autogen.sh writers shouldn't depend on
    particular git revisions, only on release versions, but let's soft-allow
    it.

 scripts/xdt-autogen.in.in |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/scripts/xdt-autogen.in.in b/scripts/xdt-autogen.in.in
index 6856b04..f8932fe 100644
--- a/scripts/xdt-autogen.in.in
+++ b/scripts/xdt-autogen.in.in
@@ -186,9 +186,10 @@ do_version_check() {
       XDT_AUTOGEN_VERSION_REV_NUM=`echo "$XDT_AUTOGEN_VERSION_REVISION" | sed -e 's/svn-r\([[:digit:]]\+\)/\1/'`
       test $rev_num -le $XDT_AUTOGEN_VERSION_REV_NUM || return 1
     elif echo "$revision" | grep -q "git"; then
-      echo "Error: git revision comparison not yet implemented.  Please file a bug:"
-      echo "@PACKAGE_BUGREPORT@"
-      exit 1
+      # since git rev info is of the form "git-$SHORT_SHA1", they cannot
+      # be ordered without knowing the full git history.
+      echo "xdt-autogen: Git revision comparison is not reliable.  Continuing anyway." >&2
+      echo "             If you experience problems, upgrade xfce4-dev-tools." >&2
     fi
   fi
 



More information about the Xfce4-commits mailing list