[Xfce4-commits] <xfconf:master> fix crash; g_propagate_error() doesn't copy the src error

[Brian J. Tarricone]

Updating branch refs/heads/master
         to 86cfde6cddef120622d91af606ecaf417186a678 (commit)
       from 8f1c96c0fd9f4870d64ce88ebdac002b601f69b0 (commit)

commit 86cfde6cddef120622d91af606ecaf417186a678
Author: Brian J. Tarricone <brian at tarricone.org>
Date:   Sun Aug 23 00:59:11 2009 -0700

    fix crash; g_propagate_error() doesn't copy the src error
    
    ... so we can't free it afterwards, obviously

 xfconf/xfconf-cache.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/xfconf/xfconf-cache.c b/xfconf/xfconf-cache.c
index ec1e0c6..674bdef 100644
--- a/xfconf/xfconf-cache.c
+++ b/xfconf/xfconf-cache.c
@@ -717,7 +717,6 @@ xfconf_cache_set(XfconfCache *cache,
             {
                 /* this is bad... */
                 g_propagate_error(error, tmp_error);
-                g_error_free(tmp_error);
                 xfconf_cache_mutex_unlock(&cache->cache_lock);
                 return FALSE;
             }