[Xfce4-commits] <xfce-git-hooks:master> add more error info

[Brian J. Tarricone]

Updating branch refs/heads/master
         to 8b1e2988db144f4f045cc628281776a87115cf29 (commit)
       from 0f01c38f57b467a9a8ce45e4fe432b2dc6ba38cb (commit)

commit 8b1e2988db144f4f045cc628281776a87115cf29
Author: Brian J. Tarricone <brian at tarricone.org>
Date:   Wed Aug 12 11:40:11 2009 -0700

    add more error info

 hooks/update-03-send-commit-mails |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/hooks/update-03-send-commit-mails b/hooks/update-03-send-commit-mails
index 4eea1b3..3c7db3f 100755
--- a/hooks/update-03-send-commit-mails
+++ b/hooks/update-03-send-commit-mails
@@ -110,6 +110,11 @@ xfce_git_hook_merge_base()
   git merge-base "$1" "$2"
 }
 
+xfce_git_hook_warn()
+{
+    echo "$1" >&2
+}
+
 xfce_git_hook_error()
 {
   echo "$1" >&2
@@ -118,8 +123,9 @@ xfce_git_hook_error()
 
 # Check if we got an email address to send to
 if [ -z "$mailinglist" ]; then
+  xfce_git_hook_warn "xfcehooks.mailinglist not set. Cannot send commit mails."
+  xfce_git_hook_warn "Please send mail to xfce-repo-admin at xfce.org to get this fixed."
   exit 0
-  #xfce_git_hook_error "xfcehooks.mailinglist not set. Cannot send commit mails."
 fi
 
 # Parse the command line 
@@ -171,7 +177,7 @@ generate_mail()
       local committer=`xfce_git_hook_committer $rev`
       ;;
     *)
-      xfce_git_hook_error "Ref type of $refname unknown"
+      xfce_git_hook_error "Ref type (\"$reftype\") of $refname unknown"
       exit 1
   esac
 
@@ -250,7 +256,7 @@ EOF
         fi
         ;;
       *)
-        xfce_git_hook_error "Ref type of $refname unknown"
+        xfce_git_hook_error "Ref type (\"$reftype\") of $refname unknown"
         exit 1
         ;;
     esac