<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hello Andre,</p>
<p>I've created a pull request with the patch:
<a class="moz-txt-link-freetext" href="https://gitlab.xfce.org/xfce/xfce4-power-manager/-/merge_requests/22">https://gitlab.xfce.org/xfce/xfce4-power-manager/-/merge_requests/22</a></p>
<p>Thanks!</p>
<p>Paul<br>
</p>
<div class="moz-cite-prefix">Le 21/12/2021 à 20:02,
<a class="moz-txt-link-abbreviated" href="mailto:andre@andreldm.com">andre@andreldm.com</a> a écrit :<br>
</div>
<blockquote type="cite" cite="mid:MrTMsFr--3-2@andreldm.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div>Hi Paul,<br>
</div>
<div dir="auto">Thanks for the investigation and fixing this on
Firefox side.<br>
</div>
<div dir="auto">Yes, this patch seems to make sense, can you
please create a Merge Request for power-manager? (You now have
permission to create forks). Thanks.<br>
</div>
<div><br>
</div>
<div>Cheers,<br>
</div>
<div>Andre Miranda<br>
</div>
<div><br>
</div>
<div>Dec 20, 2021, 08:00 by <a class="moz-txt-link-abbreviated" href="mailto:xfce-request@xfce.org">xfce-request@xfce.org</a>:<br>
</div>
<blockquote class="tutanota_quote" style="border-left: 1px solid
#93A3B8; padding-left: 10px; margin-left: 5px;">
<div>Message: 1<br>
</div>
<div>Date: Sun, 19 Dec 2021 17:51:45 +0100<br>
</div>
<div>From: Paul Ezvan <a class="moz-txt-link-rfc2396E" href="mailto:paul@ezvan.fr"><paul@ezvan.fr></a><br>
</div>
<div>To: <a class="moz-txt-link-abbreviated" href="mailto:xfce@xfce.org">xfce@xfce.org</a><br>
</div>
<div>Subject: Firefox and inhibiting DPMS<br>
</div>
<div><br>
</div>
<div>Hello,<br>
</div>
<div><br>
</div>
<div>I've always had the issue with Xfce and Firefox that the
screen would <br>
</div>
<div>suspend while watching a video.<br>
</div>
<div><br>
</div>
<div>Note that when using Chromium the screen doesn't suspend as
expected.<br>
</div>
<div><br>
</div>
<div>My first assumption was that it is because Firefox is not
calling the <br>
</div>
<div>correct DBus API in Xfce as described in <br>
</div>
<div><a class="moz-txt-link-freetext" href="https://gitlab.xfce.org/xfce/xfce4-power-manager/-/issues/42">https://gitlab.xfce.org/xfce/xfce4-power-manager/-/issues/42</a><br>
</div>
<div><br>
</div>
<div>I made a code change in Firefox to fix this which landed in
Firefox 95: <br>
</div>
<div><a class="moz-txt-link-freetext" href="https://hg.mozilla.org/integration/autoland/rev/1a71a4f15928">https://hg.mozilla.org/integration/autoland/rev/1a71a4f15928</a><br>
</div>
<div><br>
</div>
<div>Now I correctly get from the Power manager applet "Firefox
is inhibiting <br>
</div>
<div>power management" (or something like that as my desktop
uses the French <br>
</div>
<div>locale), BUT the screen still suspends!<br>
</div>
<div><br>
</div>
<div>After some investigation, I believe that this is because <br>
</div>
<div>xfce4-power-manager doesn't inhibit DPMS when getting the
inhibit <br>
</div>
<div>request, whereas it does it when entering presentation
mode. I made a <br>
</div>
<div>small change to inhibit DPMS in this case (patch attached),
and this <br>
</div>
<div>fixes the issue for me, the screen doesn't suspend any more
while <br>
</div>
<div>watching a video with Firefox.<br>
</div>
<div><br>
</div>
<div>Does it look like a good approach to fix this issue?<br>
</div>
<div><br>
</div>
<div>Thanks!<br>
</div>
<div>Paul<br>
</div>
</blockquote>
<div dir="auto"><br>
</div>
<br>
<fieldset class="moz-mime-attachment-header"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
Xfce mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Xfce@xfce.org">Xfce@xfce.org</a>
<a class="moz-txt-link-freetext" href="https://mail.xfce.org/mailman/listinfo/xfce">https://mail.xfce.org/mailman/listinfo/xfce</a>
<a class="moz-txt-link-freetext" href="http://www.xfce.org">http://www.xfce.org</a></pre>
</blockquote>
</body>
</html>