xfce4-notes trunk fails to compile (was: Re: ANNOUNCE: xfce4-vala 4.10.2 released)

[Mike Massonnet]

Hi Liviu,

Not sure if you still have issue to compile the notes plugin.

Try catching the returned type from Xfce.panel_create_button() with
(Gtk.Widget). Besides I think this should not happen with the latest
VAPI from xfce4-vala. I remember hitting that issue, and the latest
version of the notes plugin in git should compile with the most recent
version of Vala and xfce4-vala.

If you still need help, don't hesitate, but I'm currently quite busy.

Cheers,
Mike
Mike


2013/2/22 Liviu Andronic <landronimirc at gmail.com>:
> On Tue, Feb 5, 2013 at 4:33 PM, Mike Massonnet wrote:
>> There is no source to be compiled, just run make install. The pkg-config
>> file will get installed, and the VAPI files.
>>
> I see, thanks.
>
> I was actually trying to compile latest GIT of xfce4-notes, for which
> xfce4-vala now seems to be a dep, but it fails to compile.
>>"/home/liv/Build/xfce4-notes-plugin-65eca0836c259510e1eca9480b58009c49541328/autogen.sh"  (25417)
> [..]
> Build Configuration:
>
> * Maintainer Mode:        yes
>
>     * Vala:               /usr/bin/valac 0.16.1
>     * Xfce4-vala:         4.10.2
>
> * GTK+:                   2.24.10
> * Xfce Panel:             4.10.0
> * Debug Support:          minimum
>
> Now type "make" to compile.
>>"/home/liv/Build/xfce4-notes ... 80b58009c49541328/autogen.sh" (25417) returned '0'
>
>>make  (28639)
> [..]
> Making all in lib
> make[2]: Entering directory
> `/home/liv/Build/xfce4-notes-plugin-65eca0836c259510e1eca9480b58009c49541328/lib'
>   VALAC  libnotes_la_vala.stamp
>   CC     libnotes_la-icon-button.lo
>   CC     libnotes_la-window-monitor.lo
>   CC     libnotes_la-application.lo
> application.c: In function 'xnp_application_update_notes_path':
> application.c:357:4: warning: format not a string literal and no
> format arguments [-Wformat-security]
> application.c:425:3: warning: format not a string literal and no
> format arguments [-Wformat-security]
> application.c: In function 'xnp_application_delete_window':
> application.c:2094:3: warning: format not a string literal and no
> format arguments [-Wformat-security]
> application.c: In function 'xnp_application_open_settings_dialog':
> application.c:2736:3: warning: format not a string literal and no
> format arguments [-Wformat-security]
>   CC     libnotes_la-hypertextview.lo
> hypertextview.c: In function
> '_xnp_hypertext_view_move_cursor_cb_gtk_text_view_move_cursor':
> hypertextview.c:124:2: warning: passing argument 2 of
> 'xnp_hypertext_view_move_cursor_cb' from incompatible pointer type
> [enabled by default]
> hypertextview.c:86:13: note: expected 'struct GtkWidget *' but
> argument is of type 'struct GtkTextView *'
>   CC     libnotes_la-note.lo
>   CC     libnotes_la-window.lo
> window.c: In function 'xnp_window_delete_note':
> window.c:3586:3: warning: format not a string literal and no format
> arguments [-Wformat-security]
>   CC     libnotes_la-color.lo
>   CC     libnotes_la-popup.lo
>   CCLD   libnotes.la
> make[2]: Leaving directory
> `/home/liv/Build/xfce4-notes-plugin-65eca0836c259510e1eca9480b58009c49541328/lib'
> Making all in src
> make[2]: Entering directory
> `/home/liv/Build/xfce4-notes-plugin-65eca0836c259510e1eca9480b58009c49541328/src'
>   GEN    main-panel-plugin.c
> main-panel-plugin.vala:39.3-39.38: error: Assignment: Cannot convert
> from `Gtk.Widget' to `Gtk.Button'
>                 button = Xfce.panel_create_button ();
>                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Compilation failed: 1 error(s), 0 warning(s)
> make[2]: *** [main-panel-plugin.c] Error 1
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2
> make[2]: Leaving directory
> `/home/liv/Build/xfce4-notes-plugin-65eca0836c259510e1eca9480b58009c49541328/src'
> make[1]: Leaving directory
> `/home/liv/Build/xfce4-notes-plugin-65eca0836c259510e1eca9480b58009c49541328'
>>make (28639) returned '2'
>
>
> Any ideas what goes wrong? Regards,
> Liviu