ANNOUNCE: xfce4-sensors-plugin 1.2.0 released

[Christoph Mende]

On Tue, 2011-05-10 at 09:22 +0200, Jérôme Guelfucci wrote:
> On 10/05/11 09:15, Christoph Mende wrote:
> > On Mon, 2011-05-09 at 22:16 +0200, Fabian Nowak wrote:
> >> Am Montag, den 09.05.2011, 21:38 +0200 schrieb Christoph Mende:
> >>> On Mon, 2011-05-09 at 21:06 +0200, Fabian Nowak wrote:
> >>>> This release fixes several bugs when configuring and making, especially
> >>>> support for GCC 4.6 came along and newer versions of libnotify are
> >>>> supported.
> >>>
> >>> Unfortunately (detection of) the latter is broken:
> >>> Support for libnotify<  0.7 will be built in.
> >>> Support for libnotify>= 0.7 will be built in.
> >>> which results in build failures because LIBNOTIFY4 is defined.
> >>> Instead of using your own macros you could also check for
> >>> NOTIFY_CHECK_VERSION and use its result.
> >>
> >> thanks for reporting, couldn't try out explicitly because I don't have
> >> version 0.7 unless I would install manually whih I am currently out of
> >> time for.
> >>
> >> a quick fix has been applied, set --disable-notification4 should work,
> >> at least I don't have libnotify support then. Will investigate the
> >> NOTIFY_CHECK_VERSION later, thanks again.
> >
> > Thanks, but I think I do have to disappoint you ;)
> > There's a tiny typo that makes the build fail at exactly the same point:
> > sensors-interface.c: In function 'fill_gtkTreeStore':
> > sensors-interface.c:110:2: error: invalid preprocessing directive
> > #elseif
> > sensors-interface.c:111:17: error: too many arguments to function
> > 'notify_notifi
> > cation_new'
> > That should've been #elif.
> > Don't worry though, I've added 1.2.1 to Gentoo (already had 1.2.0 too)
> > and fixed patched that for us with a simple sed. I'll try to find the
> > time to write a patch based on NOTIFY_CHECK_VERSION.
> >
> 
> Hello,
> 
> Be careful with NOTIFY_CHECK_VERSION, it's not available in all 
> libnotify versions! See 
> http://foo-projects.org/pipermail/xfce4-dev/2011-February/028714.html 
> for more details.
> 
> Cheers,

I know, but thanks for the hint. Attached is the patch, I'm facing the
same problem as Fabian though, I can only test against libnotify-0.7,
not against older versions. So please test this before applying.
Btw, the patch was created against current git master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libnotify-0.7.patch
Type: text/x-patch
Size: 7880 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce/attachments/20110510/0307c016/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 230 bytes
Desc: This is a digitally signed message part
URL: <http://mail.xfce.org/pipermail/xfce/attachments/20110510/0307c016/attachment.pgp>