Midori 0.1.9 hangs up when user tries to start a second instance

[Enrico Tröger]

On Sun, 9 Aug 2009 15:12:44 +0200, Christian wrote:

>Am Sun, 9 Aug 2009 11:19:06 +0200
>schrieb Enrico Tröger <enrico.troeger at uvena.de>:
>> >Midori 0.1.9 hangs up when I try to start a second instance by doing
>> >any of the following:
>> >
>> >* press Ctrl-N;
>> >* click File -> New Window;
>> >* execute "midori" in a terminal window.
>> 
>> 
>> Easily reproducable.
>> 
>> 
>> >I did not have this problem with version 0.1.7.  Then I upgraded to
>> >0.1.9 by installing "over" 0.1.7.  Could this be the problem?  If
>> >not,
>> 
>> Unlikely.
>> 
>> 
>> >how can I diagnose the problem?
>> 
>> E.g. run Midori in gdb, trigger the "hang" and then interrupt the
>> execution with Ctrl-C and type "bt" in gdb.
>> 
>> I just did this and got the attached backtrace.
>> It seems the midori_browser_settings_notify() handler gets called
>> even if it is blocked.
>> Christian, any ideas?
>
>It turns out only one of two places was guarded against recursive
>callback invocation. I pushed a fix. I also noticed a missing signal

Works fine now.


>Thanks for reporting and for checking gdb.

Thanks for fixing it :).


Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce/attachments/20090809/6ee41da2/attachment.pgp>