xfce-4.4.2 menu

[nettxzl]

On Tue, Aug 5, 2008 at 1:11 AM, Brian J. Tarricone <bjt23 at cornell.edu>wrote:

> nettxzl wrote:
> >
> > and it seems to be working fine except for one thing. The menu does not
> come
> > up when I click on the menu icon (the icon disappears instead) in the
> panel
> > or when I right click on the desktop background (no response). Middle
> > clicking brings up the window list as expected.
> >
> > The problem can be traced to this error message:
> >
> > ** (xfce4-menu-plugin:2455): CRITICAL **: XfceDesktopMenu init failed
> (The
> > XfceDesktopMenu module could not be loaded:
> > /usr/lib/xfce4/modules/xfce4_desktop_menu.so: undefined symbol:
> > desktop_menuspec_path_free)
>
> See:
> http://bugzilla.xfce.org/show_bug.cgi?id=4193
>
> I just attached the patch that was checked in to fix that if you want to
> try it yourself.  It should apply to 4.4.2.
>
>        -brian
>
>
Thanks for the patch. I tried it out but make aborted with the error
message:

desktop-menu-cache.c: In function 'desktop_menu_cache_cleanup':
desktop-menu-cache.c:454: error: 'l' undeclared (first use in this function)
desktop-menu-cache.c:454: error: (Each undeclared identifier is reported
only once
desktop-menu-cache.c:454: error: for each function it appears in.)
make[3]: *** [xfce4_desktop_menu_la-desktop-menu-cache.lo] Error 1
make[3]: Leaving directory
`/usr/local/src/xfce-4.4.2/xfdesktop-4.4.2/modules/menu'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory
`/usr/local/src/xfce-4.4.2/xfdesktop-4.4.2/modules'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/local/src/xfce-4.4.2/xfdesktop-4.4.2'
make: *** [all] Error 2

I think it's objecting to this chunk of the patch:

Index: modules/menu/desktop-menu-cache.c
===================================================================
--- modules/menu/desktop-menu-cache.c    (revision 27203)
+++ modules/menu/desktop-menu-cache.c    (revision 27204)
@@ -444,8 +444,6 @@
 void
 desktop_menu_cache_cleanup()
 {
-    GList *l;
-
     if(menu_tree) {
         g_node_traverse(menu_tree, G_IN_ORDER, G_TRAVERSE_ALL, -1,
                 (GNodeTraverseFunc)dmc_free_tree_data, NULL);

so I tried editing out that part of the patch. Make completed successfully
after that.

I should say that before applying this patch, I also applied another patch

xfdesktop-4.4.2-relocation-and-memleak.patch

that someone else sent me. There is some overlap between the two patches and
some differences.

Anyway, after the successful make and install with both patches I tried
running Xfce but the menu icon in the panel disappeared completely and the
menu did not even
appear as an option in the Add Items to the Panel dialog.

When I tried patching with only

xfdesktop-4.4.2-relocation-and-memleak.patch

I was at last able to get the menu. So the problem appears to be fixed. But
I'm afraid I'm giving up on the

remove-g_inline_func.diff

patch.

But thanks for the suggestion.

Toni
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.xfce.org/pipermail/xfce/attachments/20080805/d42cf33f/attachment.html>