xfce4-menueditor crashes when saving

LaPeq FCI lapeqmack at gmail.com
Sun Aug 13 18:16:17 CEST 2006


2006/8/13, Jean-François Wauthy <pollux at xfce.org>:
> Le samedi 12 août 2006 à 23:58 -0300, LaPeq FCI a écrit :
> > But looking at the source code I've found something strange under the
> > menueditor-main-window.c in the funciont
> >
> > static gboolean save_treeview_in_file (MenuEditorMainWindow *window) (line 1991)
> >
> > A fopen is realized and tested with an "if" (line 2001) but no "else"
> > is set and the function ever assumes TRUE as a return. What if the
> > file could not be opened for example because of permission problems?
> >
>
> In fact the returned value wasn't used :-s, I changed the function to
> return void and added a error dialog when the file couldn't be opened
> (rev 22742).

Works fine here =)

May I ask why have you removed the command existence check? It's now
possible to create a menu item even without a command.

> --
> Jean-François Wauthy <pollux at xfce.org>
>
>
> _______________________________________________
> Xfce mailing list
> Xfce at xfce.org
> http://foo-projects.org/mailman/listinfo/xfce
> http://www.xfce.org
>
>
>


-- 
LaPeq - Laboratório de Pesquisa Científica da FCI



More information about the Xfce mailing list