icons in desktop menu patch

[Tom Wesley]

On Mon, 2004-01-05 at 20:53, Christopher Carroll wrote:
> If anyone is interested - I made a patch to add icons to xfdesktop's
> desktop menu.  Just add icon="path/to/icon/file" to any app entry in
> menu.xml.  It also works with builtin.  Also, I'm not sure how to
> dertermine the best icon height automatically, so if you don't like the
> default of 16 you can also set icon_size="24" or whatever you like. The
> patch was made against xfdesktop-4.0.2 (should be applied with -Np1 from
> the xfdesktop top source dir).
> 
> You cannot add icons to menu items that are submenus themselves. 
> xfdesktop uses an item factory to create the menu - and I don't think
> there's a way to have an item factory do this.  If I have some free time
> before school starts back up I may write a patch that manually creates
> the items so you can set icons on these enties too.
> 
> To any developers who read this:  I noticed that this was marked as TODO
> in the source code.  My method probably isn't the best way to add icons
> (I'm really just learning gtk) so this patch probably won't be too
> useful.  But it may save you someone a little time to know that to get
> the item factory to create icons the extra_data field of the entries
> must point to a serialized GdkPixdata bytestream (rather than a
> GdkPixbuf as the comments suggest).
> 
> Hope someone finds this useful...
> Christopher

Fantastic, I was just thinking this should be implemented myself.  You
should get it included for the next release.

Any Gentoo users, I just modified the ebuild if anyone is feeling
particularly lazy.

-- 
Tom Wesley
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://mail.xfce.org/pipermail/xfce/attachments/20040105/9f848cae/attachment.pgp>