Re[patch]: xfce4 gtkspinbutton error

[edscott wilson garcia]

On Mon, 2003-10-06 at 15:56, edscott wilson garcia wrote:
> On Sun, 2003-10-05 at 09:20, Olivier Fourdan wrote:
> > Hehehe, it seems you get all the problems :)
> > 
> > We got a similar report about this, confirmed by Francois. I cannot
> > reproduce the problem.
> > 
> > Edscott?
> 
> I've found the that the g_strchug function is a buggy when used with
> temporary stack variables, at least on FreeBSD. Since the report comes
> from a BSD machine, it's probably related. I have modified the code
> around the g_strchug and will commit to CVS when the new repository is
> ready. The problem should go away with this.

Or it could be that with gtk 2.2.3/2.2.4 the gtk_getentrytext_function
does not return "" but NULL. Patch:

---
/usr/home/common/CVS/sourceforge/xfce/xfce-devel/xffm-1/libs/input.c	Thu
Oct  2 11:47:40 2003
+++ /home/common/CVS/sourceforge/xfce/xfce-devel/xffm/libs/input.c	Mon
Oct  6 11:04:56 2003
@@ -355,7 +355,7 @@
     print_status(treeview,NULL," ",NULL);
     entry = (GtkEntry *) lookup_widget(tree_details->window,
"input_entry");
     choice = g_strdup((gchar *)gtk_entry_get_text(entry));
-    g_strstrip(choice);
+    if (choice) g_strstrip(choice);
     hideit(tree_details->window, "input_box");
     if(tree_details->preferences & SHOW_F)
 	showit(tree_details->window, "filter_box");
 
> 
> regards,
> 
> Edscott
> 
> > 
> > Cheers,
> > Olivier.
> > 
> > On Sun, 2003-10-05 at 10:22, Guilherme Albuquerque Zalochi wrote:
> > > Greate, perfect
> > > 
> > > but, now the problem is 
> > > 
> > > $ xffm                                                                         
> > > 
> > > (xffm:26458): GLib-CRITICAL **: file /usr/ports/devel/glib2/w-glib2-2.2.3/glib-2      .2.3/glib/gstrfuncs.c: line 2081 (g_strchug): assertion `string != NULL' failed
> > > 
> > > (xffm:26458): GLib-CRITICAL **: file /usr/ports/devel/glib2/w-glib2-2.2.3/glib-2      .2.3/glib/gstrfuncs.c: line 2096 (g_strchomp): assertion `string != NULL' failed
> > > xffm: signal 11 received. Cleaning up before exiting
> > > 
> > > 
> > > why?
> > > 
> > > tks alot 
> > > 
> > > 
> > > Guilherme Zalochi
> > > 
> > > Words by Olivier Fourdan [Sun, Oct 05, 2003 at 09:23:29AM +0200]:
> > > > On Sun, 2003-10-05 at 09:21, Olivier Fourdan wrote:
> > > > 
> > > > > Where you using any of the beta/RC before? I mean are you upgrading from
> > > >   ^^^^^ 
> > > > 
> > > > "were" is what was meant here.
> > > > 
> > > > -- 
> > > > Olivier Fourdan - fourdan at xfce.org
> > > >    
> > > >    Interoperability is the keyword, uniformity is a dead end. 
> > > >    http://www.xfce.org
> > > > 
> > > > 
> > > > 
> > > > _______________________________________________
> > > > Xfce mailing list
> > > > Xfce at xfce.org
> > > > http://moongroup.com/mailman/listinfo/xfce
> > > _______________________________________________
> > > Xfce mailing list
> > > Xfce at xfce.org
> > > http://moongroup.com/mailman/listinfo/xfce
> 
> _______________________________________________
> Xfce mailing list
> Xfce at xfce.org
> http://moongroup.com/mailman/listinfo/xfce
>