[XFCE 0000032]: XFce4-panel crashes when trying to access non-existing launchers menu

[xfce-bugs at xfce.org]

The following bug has been RESOLVED.
=======================================================================
http://bugs.xfce.org/view_bug_page.php?f_id=0000032
=======================================================================
Reporter:                   asoo
Handler:                    huysmans
=======================================================================
Project:                    XFCE
Bug ID:                     0000032
Category:                   panel
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     resolved
Resolution:                 fixed
=======================================================================
Date Submitted:             2003-12-06 14:36 GMT
Last Modified:              2003-12-06 16:09 GMT
=======================================================================
Summary:                    XFce4-panel crashes when trying to access non-existing launchers menu
Description: 
There is two ways to crash the panel:
You need a laucher and a menu attached to it.
1)
Left-click and then before menu occures right-click on launcher so that
two menus appers at the same time. After removing launcher the other menu
stills stays open and will crash the panel if you are trying to add new
launcher to it.
2)
You need at least one item on menu, so that you can undoc the menu from
launcher. After removing launcher the undocked menu stays open and
accessing to it's items or trying to close it will crash panel. 
=======================================================================

-----------------------------------------------------------------------
 olivier - 2003-12-06 14:49 GMT 
-----------------------------------------------------------------------
Both crash confirmed.

Olivier.

-----------------------------------------------------------------------
 asoo - 2003-12-06 15:05 GMT 
-----------------------------------------------------------------------
in first case you should click on laucher and hold down you'r left mouse
button(not just click on it) and then right click on it...

-----------------------------------------------------------------------
 huysmans - 2003-12-06 16:09 GMT 
-----------------------------------------------------------------------
This should fix both issues. Please reopen if it doesn't.

Index: panel/popup.c
===================================================================
RCS file: /var/cvs/xfce/xfce4/xfce4-panel/panel/popup.c,v
retrieving revision 1.40
diff -u -r1.40 popup.c
--- panel/popup.c	3 Sep 2003 21:23:48 -0000	1.40
+++ panel/popup.c	6 Dec 2003 16:03:48 -0000
@@ -490,6 +490,8 @@
     /* only items contain non-gtk elements to be freed */
     GList *li;
 
+    gtk_widget_destroy (pp->window);
+    
     for (li = pp->items; li && li->data; li = li->next)
     {
 	Item *mi = li->data;