[Xfce-bugs] [Bug 16763] patch for xfce-shortcuts-grabber.c which wrongly ungrabs keys when updating grabbed ones

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=16763

--- Comment #19 from Landry Breuil <landry at xfce.org> ---
Many thanks Jethro for the steps to reproduce, definitely helpful (and many
thanks guido for the detailed bug report, and pushing it back upstream :).

Fwiw, i can reproduce the bug on OpenBSD with xfce 4.14 using xmodmap -e
'keysym Up = Print' - once in the 'broken situation', xev shows no
KeyPress/KeyRelease for the remapped key.
Trying to re-reset the shortcuts via xfce4-keyboard-settings doesnt 'fix' the
situation, nor re resetting the x keymap via setxkbmap.

on an (unrelated?) note, when resetting shortcuts, on stderr there are two glib
error msgs:
(xfce4-keyboard-settings:75089): GLib-GObject-CRITICAL **: 09:42:19.278:
g_value_get_string: assertion 'G_VALUE_HOLDS_STRING (value)' failed
(xfce4-keyboard-settings:75089): GLib-GObject-CRITICAL **: 09:42:19.289:
g_value_get_string: assertion 'G_VALUE_HOLDS_STRING (value)' failed

building libxfce4ui with your patch, restarting xfce4 session, remapping 'up'
to print definitely shows screenshooter when hitting up, then resetting the
xkeymap to the default ( setxkbmap gb -option -option compose:prsc here)
definitely fixes the 'up' key behaviour.

as for the patch itself, cant really comment on the code/logic, but why
hardcoding to 8 ? is it 'an amount of keys one might remap' in X ? 'an amount
of shortcuts one might setup in xfce4-keyboard-settings' ?

-- 
You are receiving this mail because:
You are the assignee for the bug.